)]}'
{"id":"openstack%2Fpython-tripleoclient~674107","triplet_id":"openstack%2Fpython-tripleoclient~master~Iaf08f7d7b919b154797cf8f10663f349424cd6a2","project":"openstack/python-tripleoclient","branch":"master","topic":"bug/1837393","hashtags":[],"change_id":"Iaf08f7d7b919b154797cf8f10663f349424cd6a2","subject":"Close resources correctly","status":"MERGED","created":"2019-08-01 18:49:04.000000000","updated":"2019-08-02 15:14:12.000000000","submitted":"2019-08-02 15:14:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674107-1564758852043-ede0708f","meta_rev_id":"2171d1e32590dd2d9d3c28625f008c0b34e6cd21","_number":674107,"virtual_id_number":674107,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-02 15:14:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-02 01:37:32.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-02 12:16:55.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":2,"date":"2019-08-02 07:15:10.000000000","_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":1,"date":"2019-08-02 12:16:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-02 12:16:55.000000000","_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-02 01:37:32.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-02 07:15:10.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2019-08-02 12:16:23.000000000","updated_by":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"reviewer":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"state":"REVIEWER"},{"updated":"2019-08-02 12:16:55.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2019-08-02 15:14:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d32f95f34dd53268a306764e09f4423d919bc828","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-01 18:49:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa1618555e3ba9398868b1751a85fdfa35def2e4","author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"date":"2019-08-01 19:57:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"808dbe0dcc43294da8cf452a9393b16ef4043908","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-01 21:48:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/07/674107/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/be2c11b/ : SUCCESS in 2h 43m 43s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/07/674107/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/ba1e868/ : SUCCESS in 2h 55m 43s","accounts_in_message":[],"_revision_number":1},{"id":"7b276ebc5e025cf8ab86b1aafca921aba16f2486","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-01 22:57:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2805d8a483238ba4a0b2969c006a938bcb2a036d","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-02 01:37:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/07/674107/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/207a353/ : SUCCESS in 2h 36m 11s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/07/674107/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/ac4fcfc/ : SUCCESS in 2h 36m 58s","accounts_in_message":[],"_revision_number":2},{"id":"20f5acd0c4d0dba7eaf418c6d18fff3835f65845","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 04:59:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://logs.opendev.org/07/674107/2/check/openstack-tox-lower-constraints/939b40b/ : SUCCESS in 4m 40s\n- openstackclient-check-plugins https://logs.opendev.org/07/674107/2/check/openstackclient-check-plugins/cc3a5e1/ : SUCCESS in 3m 55s (non-voting)\n- openstack-tox-pep8 https://logs.opendev.org/07/674107/2/check/openstack-tox-pep8/ef1bb9c/ : SUCCESS in 4m 12s\n- openstack-tox-py27 https://logs.opendev.org/07/674107/2/check/openstack-tox-py27/f36e235/ : SUCCESS in 4m 37s\n- openstack-tox-py35 https://logs.opendev.org/07/674107/2/check/openstack-tox-py35/fbf6bc0/ : SUCCESS in 6m 58s\n- openstack-tox-py36 https://logs.opendev.org/07/674107/2/check/openstack-tox-py36/03c9707/ : SUCCESS in 4m 31s\n- openstack-tox-py37 https://logs.opendev.org/07/674107/2/check/openstack-tox-py37/dde4021/ : SUCCESS in 3m 42s\n- openstack-tox-docs https://logs.opendev.org/07/674107/2/check/openstack-tox-docs/300e441/html/ : SUCCESS in 4m 41s\n- tripleo-buildimage-overcloud-full-centos-7 https://logs.opendev.org/07/674107/2/check/tripleo-buildimage-overcloud-full-centos-7/5561ea8/ : SUCCESS in 24m 12s\n- tripleo-ci-centos-7-containers-multinode https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-containers-multinode/2796bec/ : SUCCESS in 2h 33m 12s\n- tripleo-ci-centos-7-undercloud-containers https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-undercloud-containers/a4bbb5b/ : SUCCESS in 1h 49m 57s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/941d81a/ : SUCCESS in 2h 20m 47s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/6f9d96a/ : SUCCESS in 2h 23m 32s (non-voting)\n- tripleo-ci-centos-7-standalone https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-standalone/647033e/ : SUCCESS in 1h 49m 13s\n- tripleo-ci-fedora-28-standalone https://logs.opendev.org/07/674107/2/check/tripleo-ci-fedora-28-standalone/4b4c4d5/ : FAILURE in 58m 08s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-standalone-upgrade/3f09296/ : FAILURE in 1h 43m 03s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/d77bfe1/ : TIMED_OUT in 3h 10m 29s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/cd5abc3/ : SUCCESS in 2h 19m 09s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://logs.opendev.org/07/674107/2/check/tripleo-ci-centos-7-scenario009-multinode-oooq-container/0b4d16a/ : FAILURE in 1h 53m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2f4fdc29ef2690c3ddf673e0a90577f5992c632e","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2019-08-02 07:15:10.000000000","message":"Patch Set 2: Code-Review+2\n\none more there https://opendev.org/openstack/python-tripleoclient/src/commit/c10329fc0e6846b9b387a977a366bf28ab8bfe5a/tripleoclient/v1/overcloud_config.py#L100 ?","accounts_in_message":[],"_revision_number":2},{"id":"0ffb382bc3af50507402618d8a2c0a2e1680b352","author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"date":"2019-08-02 12:16:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8a6f4a90a7d3c0a4a9f5cc605e7253eda46073f3","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2019-08-02 12:16:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9791dbb0b7ab8af0d19cd939d8d7eadda12cb973","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 12:17:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5f50b09eef9807b167e7b1eaa6c2b260dcba986a","author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"date":"2019-08-02 12:18:08.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit a06c818e4d926a2d08615f882cd824e2dcf8854e","accounts_in_message":[],"_revision_number":2},{"id":"91dc9f8a3a6fdb9a9580ea2a32e5ca3edafb8e30","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 15:14:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://logs.opendev.org/07/674107/2/gate/openstack-tox-lower-constraints/2067fad/ : SUCCESS in 6m 30s\n- openstack-tox-pep8 https://logs.opendev.org/07/674107/2/gate/openstack-tox-pep8/47280df/ : SUCCESS in 3m 06s\n- openstack-tox-py27 https://logs.opendev.org/07/674107/2/gate/openstack-tox-py27/b44b2bc/ : SUCCESS in 4m 00s\n- openstack-tox-py35 https://logs.opendev.org/07/674107/2/gate/openstack-tox-py35/cd4d9cf/ : SUCCESS in 3m 05s\n- openstack-tox-py36 https://logs.opendev.org/07/674107/2/gate/openstack-tox-py36/d9a3330/ : SUCCESS in 4m 26s\n- openstack-tox-py37 https://logs.opendev.org/07/674107/2/gate/openstack-tox-py37/56aac0d/ : SUCCESS in 4m 19s\n- openstack-tox-docs https://logs.opendev.org/07/674107/2/gate/openstack-tox-docs/1ea1529/html/ : SUCCESS in 3m 51s\n- tripleo-buildimage-overcloud-full-centos-7 https://logs.opendev.org/07/674107/2/gate/tripleo-buildimage-overcloud-full-centos-7/d9a274a/ : SUCCESS in 24m 10s\n- tripleo-ci-centos-7-containers-multinode https://logs.opendev.org/07/674107/2/gate/tripleo-ci-centos-7-containers-multinode/e692a69/ : SUCCESS in 2h 31m 16s\n- tripleo-ci-centos-7-standalone https://logs.opendev.org/07/674107/2/gate/tripleo-ci-centos-7-standalone/cf989aa/ : SUCCESS in 1h 58m 19s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://logs.opendev.org/07/674107/2/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/ae0e44c/ : SUCCESS in 2h 39m 00s\n- tripleo-ci-centos-7-undercloud-containers https://logs.opendev.org/07/674107/2/gate/tripleo-ci-centos-7-undercloud-containers/bd874b4/ : SUCCESS in 1h 45m 13s","accounts_in_message":[],"_revision_number":2},{"id":"16d24c6ee40287fa9bd74af1bdf130303cbbbaab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 15:14:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6521585912896c2c290c0ca15e6d5132aea77196","revisions":{"052da053d7604d84473cd8eeb717a1ad52712dc6":{"kind":"REWORK","_number":1,"created":"2019-08-01 18:49:04.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/07/674107/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/07/674107/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/1"}}},"commit":{"parents":[{"commit":"7b365a586ea301ab83c9441889ab1cc4c882e48a","subject":"Merge \"Write minion preflight checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7b365a586ea301ab83c9441889ab1cc4c882e48a"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 18:48:06.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 18:48:06.000000000","tz":-360},"subject":"Close resources correctly","message":"Close resources correctly\n\nUnder python3 not closing file handles or network resources correctly\nresults in warnings being shown to the end user. This change switches\nthe resource usage to properly close when we\u0027re done.\n\nChange-Id: Iaf08f7d7b919b154797cf8f10663f349424cd6a2\nRelated-Bug: #1837393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/052da053d7604d84473cd8eeb717a1ad52712dc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/052da053d7604d84473cd8eeb717a1ad52712dc6"}]},"branch":"refs/heads/master"},"6521585912896c2c290c0ca15e6d5132aea77196":{"kind":"REWORK","_number":2,"created":"2019-08-01 22:57:29.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/07/674107/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/07/674107/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/07/674107/2"}}},"commit":{"parents":[{"commit":"7b365a586ea301ab83c9441889ab1cc4c882e48a","subject":"Merge \"Write minion preflight checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7b365a586ea301ab83c9441889ab1cc4c882e48a"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 18:48:06.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-01 22:57:24.000000000","tz":-360},"subject":"Close resources correctly","message":"Close resources correctly\n\nUnder python3 not closing file handles or network resources correctly\nresults in warnings being shown to the end user. This change switches\nthe resource usage to properly close when we\u0027re done.\n\nChange-Id: Iaf08f7d7b919b154797cf8f10663f349424cd6a2\nRelated-Bug: #1837393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/6521585912896c2c290c0ca15e6d5132aea77196"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/6521585912896c2c290c0ca15e6d5132aea77196"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}