)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c6a5a0f0eca9df7da58cfadcf894bccd37e8fafe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When listing validations through the CLI, the return code was always 0."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch adds a proper return code management to validations listing"},{"line_number":12,"context_line":"CLI."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3171adabc639789b0ea805a140e4b1220ed4c93a"},{"line_number":15,"context_line":"Signed-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_af39a7f2","line":12,"updated":"2019-08-14 06:07:48.000000000","message":"by raising an exception (you aren\u0027t doing return codes explicitly any more in v2)","commit_id":"cd91e99df18c1a1500bc30508e33cd3f94079689"}],"tripleoclient/tests/v1/tripleo/test_tripleo_validator.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08537f3bdc40cb7d371ad82c091e8b77ac302536","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        plan_mock.assert_called_once_with("},{"line_number":44,"context_line":"            mock.ANY, {\u0027group_names\u0027: []})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        assert mock_sysexit.called"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestValidatorRun(utils.TestCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_36a799aa","line":46,"updated":"2019-08-09 07:59:28.000000000","message":"i mean you\u0027ve gone to the trouble of adding tests but how about then testing the thing you\u0027re adding here :D can we add something for return 1 and return 0?","commit_id":"1ed5cb117bba404944dace1edf9a2a0327e291f4"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ea657aa35d2b986a51af6ffc8d8a9bd79f4fab9b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            mock.ANY, {\u0027group_names\u0027: []})"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        assert mock_sysexit.called"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestValidatorRun(utils.TestCommand):"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b63dc9de","line":47,"updated":"2019-08-09 08:24:27.000000000","message":"Hi Marios! You are definitively right and I will do something better in a follow-up patch (I have another case in the TestValidatorRun class)","commit_id":"1ed5cb117bba404944dace1edf9a2a0327e291f4"}],"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1bdef754db94f461518df82888ee0f5a206f84bc","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                    out \u003d oooutils.get_validations_table("},{"line_number":180,"context_line":"                        {\u0027validations\u0027: output})"},{"line_number":181,"context_line":"                print(out)"},{"line_number":182,"context_line":"            sys.exit(0)"},{"line_number":183,"context_line":"        except Exception as e:"},{"line_number":184,"context_line":"            print(_(\"Validations listing finished with errors\"))"},{"line_number":185,"context_line":"            print(\u0027Output: {}\u0027.format(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_654bf25e","line":182,"updated":"2019-08-12 15:03:20.000000000","message":"Not needed","commit_id":"1ed5cb117bba404944dace1edf9a2a0327e291f4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1bdef754db94f461518df82888ee0f5a206f84bc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except Exception as e:"},{"line_number":184,"context_line":"            print(_(\"Validations listing finished with errors\"))"},{"line_number":185,"context_line":"            print(\u0027Output: {}\u0027.format(e))"},{"line_number":186,"context_line":"            sys.exit(1)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def take_action(self, parsed_args):"},{"line_number":189,"context_line":"        self._run_validator_list(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c52e668b","line":186,"updated":"2019-08-12 15:03:20.000000000","message":"Raise an exception rather than using sys.exit.","commit_id":"1ed5cb117bba404944dace1edf9a2a0327e291f4"}]}