)]}'
{"tripleoclient/utils.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3712dc46c1cca5c6ab86f071bb0fa70b19b916c5","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027, \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1080,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1081,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1082,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d6bd9468","line":1079,"updated":"2019-08-14 15:32:28.000000000","message":"I don\u0027t think this is right to be hard coded like this. I didn\u0027t think tripleoclient was installed in the mistral container so it likely shouldn\u0027t know about this.   Also I think the tripleo-admin items can be overridden","commit_id":"b714a36e1430e03680966d7006407576bd7bc057"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c7bde3b5480f45aff402ec12232d09bf23d76a29","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027, \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1080,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1081,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1082,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_cec4f762","line":1079,"in_reply_to":"7faddb67_6e286332","updated":"2019-08-16 11:16:05.000000000","message":"I\u0027m pretty sure this is due to some security concern. Having one unique private key used by multiple services is bad security design. You might want to ping Security for more info about that.","commit_id":"b714a36e1430e03680966d7006407576bd7bc057"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ced737793da898a3d64116bb614dcf45a28c8759","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027, \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1080,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1081,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1082,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6e286332","line":1079,"in_reply_to":"7faddb67_d6bd9468","updated":"2019-08-16 11:13:23.000000000","message":"I agree with you, however, there is something I do not understand very well. Why don\u0027t we use the very same private key to access the overcloud nodes and undercloud node from the mistral_executor container? If we could use the very same ansible_ssh_private_key configured in the config-download\u0027s ansible.cfg (which usually points to a ssh_private_key file included in that directory) to access the Undercloud too, then we wouldn\u0027t need to pass this here. I did some initial work on these two patches: https://review.opendev.org/676899/ and https://review.opendev.org/#/c/676899/ to see if it would be feasible at least.\n\nIf you see some reason why we shouldn\u0027t use the Undercloud\u0027s tripleo-admin key to build the mistral\u0027s ssh_keys environment file (that we then use in ansible-playbook), feel free to comment on the patches.\n\nIf that works, I will drop this patch.","commit_id":"b714a36e1430e03680966d7006407576bd7bc057"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"65e1d4689b3f3efc22da9100d411a56357724d48","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_869a0a6d","line":1079,"updated":"2019-08-22 09:29:33.000000000","message":"I would like to have it more specific as --undercloud-private-key-file --undercloud-public-key-file","commit_id":"2e9affbdbb7db175609d75f4a2790c01c1726129"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4da3bd43174a1a4d439eda5fb5ca84a60f2e196e","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_7169b1f6","line":1079,"updated":"2019-08-23 11:59:56.000000000","message":"Well, this is in line with the base class in https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventory.py#L96 and everywhere where that parameter is used.  I wouldn\u0027t change it without changing the naming everywhere.","commit_id":"2e9affbdbb7db175609d75f4a2790c01c1726129"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"080dbe3d98223aa22bd3ac4801156c86019c3811","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"                \u0027--stack\u0027, stack,"},{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_511ef574","line":1079,"in_reply_to":"7faddb67_7169b1f6","updated":"2019-08-23 12:05:03.000000000","message":"ok","commit_id":"2e9affbdbb7db175609d75f4a2790c01c1726129"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4da3bd43174a1a4d439eda5fb5ca84a60f2e196e","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1083,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_916eadfe","line":1080,"updated":"2019-08-23 11:59:56.000000000","message":"Hardcoding /var/lib/mistral is fine as it\u0027s hardcoded there https://github.com/openstack/tripleo-common/blob/master/workbooks/deployment.yaml#L386 as well.","commit_id":"2e9affbdbb7db175609d75f4a2790c01c1726129"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"4da3bd43174a1a4d439eda5fb5ca84a60f2e196e","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1083,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"},{"line_number":1084,"context_line":"            raise exceptions.InvalidConfiguration(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_317339eb","line":1081,"updated":"2019-08-23 11:59:56.000000000","message":"Relative to the deployment tasks we are still missing the ssh_network parameter which is ctlplane by default, but I believe user can modify that.  I would be relevent to add it.","commit_id":"2e9affbdbb7db175609d75f4a2790c01c1726129"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"d48401037039b7c233f8816a76ea622f779c784e","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                \u0027--ansible_ssh_user\u0027, ssh_user,"},{"line_number":1078,"context_line":"                \u0027--undercloud-connection\u0027, \u0027ssh\u0027,"},{"line_number":1079,"context_line":"                \u0027--undercloud-key-file\u0027,"},{"line_number":1080,"context_line":"                \u0027/var/lib/mistral/.ssh/tripleo-admin-rsa\u0027,"},{"line_number":1081,"context_line":"                \u0027--static-yaml-inventory\u0027, inventory_file)"},{"line_number":1082,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":1083,"context_line":"            message \u003d _(\"Failed to generate inventory: %s\") % str(e)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_d82081fb","line":1080,"updated":"2019-08-28 12:32:56.000000000","message":"We\u0027re still missing passing the host_network option as in deployment\nhttps://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/ansible.py#L693","commit_id":"28a3d020618f633608de2657a8589c32fe44a964"}]}