)]}'
{"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4c8877f737e8783828c0ff05cec86f30d3403ecb","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            env_data[\u0027ExtraHostFileEntries\u0027] \u003d extra_host"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        admin_host \u003d utils.get_single_ip(CONF.get(\u0027undercloud_admin_host\u0027))"},{"line_number":613,"context_line":"        netaddr.IPAddress(admin_host)"},{"line_number":614,"context_line":"        deploy_args +\u003d [\u0027--control-virtual-ip\u0027, admin_host]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4d004601","line":613,"range":{"start_line":613,"start_character":8,"end_line":613,"end_character":37},"updated":"2019-08-28 20:59:46.000000000","message":"we already call netaddr.IPAddress(admin_host) here, can we avoid it calling it a second time?","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4174f4fd2322e193265585586eefd44187a4c64b","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            env_data[\u0027ExtraHostFileEntries\u0027] \u003d extra_host"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        admin_host \u003d utils.get_single_ip(CONF.get(\u0027undercloud_admin_host\u0027))"},{"line_number":613,"context_line":"        netaddr.IPAddress(admin_host)"},{"line_number":614,"context_line":"        deploy_args +\u003d [\u0027--control-virtual-ip\u0027, admin_host]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0df48ef0","line":613,"range":{"start_line":613,"start_character":8,"end_line":613,"end_character":37},"in_reply_to":"7faddb67_0d71eea8","updated":"2019-08-28 21:08:03.000000000","message":"maybe some sort of validation, I don\u0027t know. We can probably clean this up?","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"63216b688c2489c997c441893d295dcc3b0f8670","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            env_data[\u0027ExtraHostFileEntries\u0027] \u003d extra_host"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        admin_host \u003d utils.get_single_ip(CONF.get(\u0027undercloud_admin_host\u0027))"},{"line_number":613,"context_line":"        netaddr.IPAddress(admin_host)"},{"line_number":614,"context_line":"        deploy_args +\u003d [\u0027--control-virtual-ip\u0027, admin_host]"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0d71eea8","line":613,"range":{"start_line":613,"start_character":8,"end_line":613,"end_character":37},"in_reply_to":"7faddb67_4d004601","updated":"2019-08-28 21:05:01.000000000","message":"I have no idea why we call this here if we\u0027re setting it, but i\u0027ll use this one instead after saving it to a var","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4c8877f737e8783828c0ff05cec86f30d3403ecb","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"},{"line_number":617,"context_line":"        if CONF.get(\u0027net_config_override\u0027, None):"},{"line_number":618,"context_line":"            if (netaddr.IPAddress(admin_host) not in local_net.cidr):"},{"line_number":619,"context_line":"                LOG.error(\u0027You may need to specify a custom \u0027"},{"line_number":620,"context_line":"                          \u0027ControlVirtualInterface in a custom env file to \u0027"},{"line_number":621,"context_line":"                          \u0027correctly assign the ip address to an interface for\u0027"},{"line_number":622,"context_line":"                          \u0027 undercloud_admin_host. By default it will be set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ad39bad8","line":619,"range":{"start_line":619,"start_character":31,"end_line":619,"end_character":34},"updated":"2019-08-28 20:59:46.000000000","message":"we may or should? since we log an error on a clear condition","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9906e727152f60fd2d12c58dd83c53f4cdeb9d9","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"},{"line_number":617,"context_line":"        if CONF.get(\u0027net_config_override\u0027, None):"},{"line_number":618,"context_line":"            if (netaddr.IPAddress(admin_host) not in local_net.cidr):"},{"line_number":619,"context_line":"                LOG.error(\u0027You may need to specify a custom \u0027"},{"line_number":620,"context_line":"                          \u0027ControlVirtualInterface in a custom env file to \u0027"},{"line_number":621,"context_line":"                          \u0027correctly assign the ip address to an interface for\u0027"},{"line_number":622,"context_line":"                          \u0027 undercloud_admin_host. By default it will be set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ad3e9ab6","line":619,"range":{"start_line":619,"start_character":31,"end_line":619,"end_character":34},"in_reply_to":"7faddb67_ad39bad8","updated":"2019-08-28 21:03:44.000000000","message":"may. if they still use br-ctlplane, they may not need to.","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4174f4fd2322e193265585586eefd44187a4c64b","unresolved":false,"context_lines":[{"line_number":616,"context_line":"        local_net \u003d netaddr.IPNetwork(CONF.get(\u0027local_ip\u0027))"},{"line_number":617,"context_line":"        if CONF.get(\u0027net_config_override\u0027, None):"},{"line_number":618,"context_line":"            if (netaddr.IPAddress(admin_host) not in local_net.cidr):"},{"line_number":619,"context_line":"                LOG.error(\u0027You may need to specify a custom \u0027"},{"line_number":620,"context_line":"                          \u0027ControlVirtualInterface in a custom env file to \u0027"},{"line_number":621,"context_line":"                          \u0027correctly assign the ip address to an interface for\u0027"},{"line_number":622,"context_line":"                          \u0027 undercloud_admin_host. By default it will be set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_cdd51649","line":619,"range":{"start_line":619,"start_character":31,"end_line":619,"end_character":34},"in_reply_to":"7faddb67_ad3e9ab6","updated":"2019-08-28 21:08:03.000000000","message":"lgtm","commit_id":"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a227e4b667bc03acb83ce9cdd4c88d429c7c1625","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            \u0027-e\u0027, os.path.join(tht_templates, \u0027environments/services/\u0027"},{"line_number":591,"context_line":"                               \u0027undercloud-haproxy.yaml\u0027),"},{"line_number":592,"context_line":"            \u0027-e\u0027, os.path.join(tht_templates, \u0027environments/services/\u0027"},{"line_number":593,"context_line":"                               \u0027undercloud-keepalived.yaml\u0027)]"},{"line_number":594,"context_line":"    elif CONF.get(\u0027generate_service_certificate\u0027):"},{"line_number":595,"context_line":"        deploy_args +\u003d [\u0027-e\u0027, os.path.join("},{"line_number":596,"context_line":"            tht_templates,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_edb33209","side":"PARENT","line":593,"updated":"2019-08-28 21:26:44.000000000","message":"clearly we weren\u0027t testing this anywhere because it dupes the includes starting on L644 (in the new version)","commit_id":"c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8"}]}