)]}'
{"id":"openstack%2Fpython-tripleoclient~679141","triplet_id":"openstack%2Fpython-tripleoclient~master~I32b44184a840ec7932a812ce0fabaa0256061993","project":"openstack/python-tripleoclient","branch":"master","topic":"bug/1841850","hashtags":[],"change_id":"I32b44184a840ec7932a812ce0fabaa0256061993","subject":"Always specify interface for vips","status":"MERGED","created":"2019-08-28 20:47:24.000000000","updated":"2019-09-05 14:40:23.000000000","submitted":"2019-08-30 22:26:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"679141-1567203999629-6ccbb2a0","meta_rev_id":"0f2d64bc52fe4413452635ab6115d832506759fb","_number":679141,"virtual_id_number":679141,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"date":"2019-08-28 21:26:44.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-08-30 22:26:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-29 00:12:39.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-08-29 12:47:57.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-08-30 19:25:16.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2019-08-30 19:25:16.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-29 00:12:39.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-29 12:47:57.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-08-30 19:25:16.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2019-08-30 22:26:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe5a4d52fcc74c918620d17984872fb93a0ab996","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 20:47:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c8877f737e8783828c0ff05cec86f30d3403ecb","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-28 20:59:46.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d9906e727152f60fd2d12c58dd83c53f4cdeb9d9","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 21:03:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"63216b688c2489c997c441893d295dcc3b0f8670","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 21:05:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4174f4fd2322e193265585586eefd44187a4c64b","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-28 21:08:03.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1e2be3bd11b26dd99bfc48fb0db8c6aa0c22cd80","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 21:08:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9b72bfa4b019345433b11aa3a8a54bbb30822b49","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 21:09:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a227e4b667bc03acb83ce9cdd4c88d429c7c1625","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-28 21:26:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3dc8030dbf1ae32f75fc5b86d7a84098ec750b2c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-29 00:12:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/41/679141/3/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/cd250c2/ : SUCCESS in 3h 02m 09s\n- tripleo-rhel-8-buildimage-overcloud-full http://logs.rdoproject.org/41/679141/3/openstack-check/tripleo-rhel-8-buildimage-overcloud-full/c5e2510/ : SUCCESS in 22m 04s (non-voting)\n- tripleo-rhel-8-buildimage-ironic-python-agent http://logs.rdoproject.org/41/679141/3/openstack-check/tripleo-rhel-8-buildimage-ironic-python-agent/909c802/ : SUCCESS in 17m 05s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"aae2b9e34b9a1af02b889ce463baa136edc4d87b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 00:40:40.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e65ccd70d161438498facd363f1e3079 : SUCCESS in 5m 37s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/dd052d3d510c4a7696fadce0b541f111 : SUCCESS in 5m 00s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eb3bb46d6dc443dab0427df83370538d : SUCCESS in 3m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/795b616524794fe694d8d09576f18fc9 : SUCCESS in 3m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dc14a9b336c6453a9d6b5ba7b2ed2404 : SUCCESS in 4m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/276e42eb09f74930a3a2dc7bfa09f0d8 : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dac9225ed0754290a13a3e5d5f3d4f0f : SUCCESS in 4m 08s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/25f7a4e573554ab1acc05ecd3ce8bacc : SUCCESS in 25m 55s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/1d9cc565428446758e28cb27c3358905 : SUCCESS in 2h 36m 35s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/9af763113765432c935f8a313e9f4653 : SUCCESS in 2h 03m 29s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/18e8d0d6eb5146779e927c105081c6dc : SUCCESS in 2h 30m 46s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/8eac5b55cc6b41cbbd06e5f0de79d8b0 : SUCCESS in 2h 47m 04s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/4a5e325270be43989c97b190466c02d6 : SUCCESS in 2h 19m 55s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/3f08fc5b4d1a4307a153449bf88460df : SUCCESS in 2h 24m 34s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/39c6a409590b441684224b08c344a4fb : TIMED_OUT in 3h 20m 20s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/3103082dd2a244aaa3a0f383ed950665 : SUCCESS in 2h 46m 06s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/b1ff778e46ef48cb8bfbab3aafb9af72 : FAILURE in 1h 33m 27s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f6a3dfac645a166e6317a9243dc9a4641e23b3a3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-08-29 12:47:57.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7bc660bd9a99d6b896715a0e6253f278e6ade3dd","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2019-08-30 19:25:16.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"af5800109ee2d63baed958107d7ad2a273083c82","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 19:25:30.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"87d4b7baa900ca81b472d54d61306fefb6394c02","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 22:26:39.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6c33da70cd504f08971afba2dc713dd1 : SUCCESS in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/56b3b11bb0284353b28772a2d3cae57c : SUCCESS in 4m 05s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2ce248f76f044938a99b8821eaa8f227 : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c4965aec5355484288be37246187bfbd : SUCCESS in 5m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b2593f6b824c43d49860a7088e1b3193 : SUCCESS in 6m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2fcfc98bd6444182840310a49eef7e4a : SUCCESS in 6m 36s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/7e0213aee58b43cb806dd2d934343dcc : SUCCESS in 22m 58s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/05435f641c18496ababc2ce9aae5a926 : SUCCESS in 2h 44m 38s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/c69cd247528b4af094a17e3b946143a8 : SUCCESS in 2h 16m 29s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/b4a15288777147219bde9824cd219bf1 : SUCCESS in 2h 55m 25s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/eb5fd7ba8f58420f8d68884be511a5f7 : SUCCESS in 2h 06m 59s","accounts_in_message":[],"_revision_number":3},{"id":"bd0a38bfc195ffcdeeb9aad5ec1a64b3f1909443","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 22:26:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"44d55d6d7042a826c974bc9e22aec8a849e3746c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 22:28:56.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e4d1d5ea2b8a4ebaa77eed2ceccc5305 : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":3},{"id":"7f87e6b768af4d0a98d6aab4dc0dd0318916e5a1","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-09-05 14:40:08.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit fdd998d6b5451399993a80cdd23704880a557557","accounts_in_message":[],"_revision_number":3},{"id":"77104bcaa9bd80675f9b8b25c736eb9347235f71","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-09-05 14:40:23.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 91d37108d37002d4d33dc90b72cea69afb1ddad9","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7e5b133122d2fdda19fcfa845e1218970627727c","revisions":{"8cae9b4e82105003a4c83055bf66f2b89a3a1a0a":{"kind":"REWORK","_number":1,"created":"2019-08-28 20:47:24.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/41/679141/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/41/679141/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/1"}}},"commit":{"parents":[{"commit":"c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8","subject":"Merge \"Remove converge_nodes functions, unused package_update code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 20:43:13.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 20:43:13.000000000","tz":-360},"subject":"Always specify interface for vips","message":"Always specify interface for vips\n\nCurrently the interfaces end up being detected during the deploy however\nthis only works when the undercloud_*_host configurations use the same\nip cidr as the local_ip. We should define this to be the br-ctlplane by\ndefault, however this may need to be configured differently when the\nuser is using their on network configuration override.  We will also\nthrow warnings about these configurations when this type of\nconfiguration occurs. The end user can override these via their own\ncustom env file if they want the vips to end up on a different\ninterface.\n\nChange-Id: I32b44184a840ec7932a812ce0fabaa0256061993\nCloses-Bug: #1841850\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/8cae9b4e82105003a4c83055bf66f2b89a3a1a0a"}]},"branch":"refs/heads/master"},"606c4a893f248b5b5b729adc362a040f9af275f7":{"kind":"REWORK","_number":2,"created":"2019-08-28 21:08:11.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/41/679141/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/41/679141/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/2"}}},"commit":{"parents":[{"commit":"c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8","subject":"Merge \"Remove converge_nodes functions, unused package_update code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 20:43:13.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 21:08:07.000000000","tz":-360},"subject":"Always specify interface for vips","message":"Always specify interface for vips\n\nCurrently the interfaces end up being detected during the deploy however\nthis only works when the undercloud_*_host configurations use the same\nip cidr as the local_ip. We should define this to be the br-ctlplane by\ndefault, however this may need to be configured differently when the\nuser is using their on network configuration override.  We will also\nthrow warnings about these configurations when this type of\nconfiguration occurs. The end user can override these via their own\ncustom env file if they want the vips to end up on a different\ninterface.\n\nChange-Id: I32b44184a840ec7932a812ce0fabaa0256061993\nCloses-Bug: #1841850\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/606c4a893f248b5b5b729adc362a040f9af275f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/606c4a893f248b5b5b729adc362a040f9af275f7"}]},"branch":"refs/heads/master"},"7e5b133122d2fdda19fcfa845e1218970627727c":{"kind":"REWORK","_number":3,"created":"2019-08-28 21:09:29.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/41/679141/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/41/679141/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/41/679141/3"}}},"commit":{"parents":[{"commit":"c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8","subject":"Merge \"Remove converge_nodes functions, unused package_update code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/c513e4975fc4e4164c9a6c0f39ee59f2adbb72d8"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 20:43:13.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 21:09:26.000000000","tz":-360},"subject":"Always specify interface for vips","message":"Always specify interface for vips\n\nCurrently the interfaces end up being detected during the deploy however\nthis only works when the undercloud_*_host configurations use the same\nip cidr as the local_ip. We should define this to be the br-ctlplane by\ndefault, however this may need to be configured differently when the\nuser is using their on network configuration override.  We will also\nthrow warnings about these configurations when this type of\nconfiguration occurs. The end user can override these via their own\ncustom env file if they want the vips to end up on a different\ninterface.\n\nChange-Id: I32b44184a840ec7932a812ce0fabaa0256061993\nCloses-Bug: #1841850\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7e5b133122d2fdda19fcfa845e1218970627727c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7e5b133122d2fdda19fcfa845e1218970627727c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}