)]}'
{"id":"openstack%2Fpython-tripleoclient~680433","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Fstein~I32b44184a840ec7932a812ce0fabaa0256061993","project":"openstack/python-tripleoclient","branch":"stable/stein","topic":"bug/1841850-stable/stein","hashtags":[],"change_id":"I32b44184a840ec7932a812ce0fabaa0256061993","subject":"Always specify interface for vips","status":"MERGED","created":"2019-09-05 14:40:08.000000000","updated":"2019-09-10 00:38:08.000000000","submitted":"2019-09-10 00:37:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"680433-1568075824820-3ba29265","meta_rev_id":"017758b1cc6dc424a641f99d4c070a358781d69b","_number":680433,"virtual_id_number":680433,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-10 00:37:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-05 17:38:45.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-06 13:27:03.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-09-06 16:02:08.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-09-09 19:21:45.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-05 17:38:45.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-09 19:21:45.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-09-10 00:37:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2a71b2882e6737a4f4d92bfd56ac0a8f6695224b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-09-05 14:40:08.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"d11c94ebaf966a1236bba8c369f57a94f3464511","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-09-05 17:38:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/33/680433/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/1545373/ : SUCCESS in 2h 57m 42s","accounts_in_message":[],"_revision_number":1},{"id":"4e157fd6cb78b41d0cbf5a6caa145e82638c5dbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-06 00:16:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b0b23c1aa812491a9e960a025723b560 : SUCCESS in 5m 32s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/4059146db1fb4e4bb975971c6c645acd : SUCCESS in 6m 25s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/beb92c65cc914208b6e08a2fc7e0b5e4 : SUCCESS in 3m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8564d49010324e29be45c92c7917dcf8 : SUCCESS in 4m 42s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d75169758112450f932467045a6177ff : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7e6b38831edb4bfd87510afb0cd25e27 : SUCCESS in 4m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9eecc5be233445f6aa1cc43f261cb834 : SUCCESS in 4m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66edd4e745ec46db9c1771f879c7cfd3 : SUCCESS in 4m 07s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/da4a178a77bb45db921d232d528d9244 : SUCCESS in 25m 12s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/38cc5b777382449d8b88ce6e97f12e09 : SUCCESS in 2h 31m 55s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/8c700acf1dc742f791aa83073674243a : SUCCESS in 1h 48m 49s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/a59e31f1aa0d4032a05c51b96dd642a8 : FAILURE in 54m 06s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/d4b7acbd03314e649b38605bac918c60 : FAILURE in 1h 23m 52s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/647bef7630a24ecbb0678c995ff793c7 : SUCCESS in 2h 29m 15s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/478b20dde1f4436490f69f5f1787077e : FAILURE in 1h 39m 28s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/97c9380b98ca436793fbe07ee3d500d5 : SUCCESS in 2h 51m 01s (non-voting)\n- tripleo-ci-centos-7-scenario008-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/7997496278e54e21abdda56bbf42110d : FAILURE in 1h 38m 56s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/b6e2a2d14fd1460e99ba481c69e7951f : FAILURE in 2h 30m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1bbddfd59b79ccf9834f300640371ec67e485198","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-09-06 13:27:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d99c7c20f86dd1af2eb9575aa8af759517ebd52e","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-09-06 16:02:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b3d6863be8e147935e40d86ad3c7d2e77c523fe9","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-09-06 16:26:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/33/680433/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/c37cbbf/ : SUCCESS in 2h 58m 21s","accounts_in_message":[],"_revision_number":1},{"id":"2c712a2547d1c538b5b8ff0572c949625eadbcd5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-06 18:01:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f03cd0a33a5643b4b991cca0e87e7ecc : SUCCESS in 5m 11s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/27ca7d6231e24417870465145dd8ab5e : SUCCESS in 5m 16s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b6da0d40d6e84576b75dc04786dc455b : SUCCESS in 3m 24s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/486dba035090488fbb37866acce1ebb0 : SUCCESS in 4m 23s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/189980f63a734029bcb23662553e5f61 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/73d6d10fdabb4fb79645509e65e7f254 : SUCCESS in 2m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7f914f75a0e14e6dadd7e82f631d8c6d : SUCCESS in 6m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/974d69cadb164b7894f24e3e9b39fe8c : SUCCESS in 3m 55s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/b874c4fcf49044ab87fa1943ec939357 : SUCCESS in 22m 09s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/bcce0e3ec4664d87870e6e10db446d11 : SUCCESS in 2h 50m 12s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/3f5a27946ef74700b38c1e4eed0aa992 : SUCCESS in 1h 54m 18s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/20932f7381b74badae3b07cf377d14aa : SUCCESS in 2h 41m 16s (non-voting)\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/b7d8e442ce8f44acb45c22e71fe871aa : SUCCESS in 2h 49m 38s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/c8c29f6ee345407290e7d5e19dd70a5e : SUCCESS in 2h 09m 51s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/e3dd9a19d0d6498abb99d47a75842b45 : FAILURE in 1h 39m 09s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/d7750683bb074916aa035e99dd8390d5 : SUCCESS in 2h 53m 10s (non-voting)\n- tripleo-ci-centos-7-scenario008-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/3c7354add1224e16963e3eb99b49cb68 : FAILURE in 1h 40m 23s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/a203bcf3947f4f1e90c47e9fbfbe90d2 : FAILURE in 2h 10m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e98f4fbb5183752d251c4492d6a18ef9d6861d81","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-09-09 19:21:45.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ee3ad4ba39412027ac69062af29bd9e86921d38d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-09 19:22:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"543fad9ae95fa69c26896548117843dde1d4dc23","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 00:37:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5c70efb9f45444ffba602a878f30315f : SUCCESS in 5m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1bce8b1e82964b70b123458d75c7fab0 : SUCCESS in 4m 05s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f5579ec555414aa5b5519a9f9a39c7b8 : SUCCESS in 4m 09s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/56a2338e125a452dada45c4da8dbda54 : SUCCESS in 6m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a5308c84e4cd4e44a4909a3193683d09 : SUCCESS in 4m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8d8474a8f1164b73b32099849b6b849f : SUCCESS in 3m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/37d8076d69b54655bbcf79dd8808b11c : SUCCESS in 4m 17s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/e570d5ea5446486697e4b92db990ad9b : SUCCESS in 23m 16s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/7219b1a76d0741569ca4b6607544bc66 : SUCCESS in 2h 53m 05s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/7316785d9e864580a29566e03fb00cd2 : SUCCESS in 2h 19m 08s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/d525f2bfb74e48f29b3fbac6d03ee939 : SUCCESS in 2h 33m 51s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/cc131d91c4c8497fbb0db97de5c79a59 : SUCCESS in 2h 13m 09s","accounts_in_message":[],"_revision_number":1},{"id":"8000b335ae33c142cd1c1589ec02d325649aadc9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 00:37:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3c6b6894794842abc7d171e4bbc95dfc9541fb18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-10 00:38:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91707bb0963f4bb9b11d7dc5b16cd2f2 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fdd998d6b5451399993a80cdd23704880a557557","revisions":{"fdd998d6b5451399993a80cdd23704880a557557":{"kind":"REWORK","_number":1,"created":"2019-09-05 14:40:08.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/33/680433/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/33/680433/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/33/680433/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/33/680433/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/33/680433/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/33/680433/1"}}},"commit":{"parents":[{"commit":"85188ebf67e25ea078bfe3ef31e8a18788d2fdba","subject":"Merge \"Don\u0027t force verbosity of 1 for config-download\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/85188ebf67e25ea078bfe3ef31e8a18788d2fdba"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-08-28 20:43:13.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-09-05 14:40:08.000000000","tz":0},"subject":"Always specify interface for vips","message":"Always specify interface for vips\n\nCurrently the interfaces end up being detected during the deploy however\nthis only works when the undercloud_*_host configurations use the same\nip cidr as the local_ip. We should define this to be the br-ctlplane by\ndefault, however this may need to be configured differently when the\nuser is using their on network configuration override.  We will also\nthrow warnings about these configurations when this type of\nconfiguration occurs. The end user can override these via their own\ncustom env file if they want the vips to end up on a different\ninterface.\n\nChange-Id: I32b44184a840ec7932a812ce0fabaa0256061993\nCloses-Bug: #1841850\n(cherry picked from commit 7e5b133122d2fdda19fcfa845e1218970627727c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fdd998d6b5451399993a80cdd23704880a557557"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fdd998d6b5451399993a80cdd23704880a557557"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}