)]}'
{"id":"openstack%2Fpython-tripleoclient~685667","triplet_id":"openstack%2Fpython-tripleoclient~master~Ic8122ad1982deed0434d797a3fb0fba8512b27ab","project":"openstack/python-tripleoclient","branch":"master","topic":"fix_close_warnings","hashtags":[],"change_id":"Ic8122ad1982deed0434d797a3fb0fba8512b27ab","subject":"Close some file descriptors that were left open","status":"MERGED","created":"2019-09-30 09:28:40.000000000","updated":"2019-10-01 17:29:29.000000000","submitted":"2019-10-01 17:08:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"685667-1569949707831-fe29816b","meta_rev_id":"1802507a7ae9c9d4c1b879367a1da3212d12ab3c","_number":685667,"virtual_id_number":685667,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"value":0,"date":"2019-10-01 07:20:19.000000000","_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-01 17:08:27.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-01 09:53:51.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"recommended":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"all":[{"value":1,"date":"2019-10-01 12:29:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":2,"date":"2019-10-01 06:49:02.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-10-01 06:49:02.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-01 06:49:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"value":0,"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"value":1,"date":"2019-10-01 12:51:45.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-30 09:32:42.000000000","updated_by":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"reviewer":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"state":"REVIEWER"},{"updated":"2019-09-30 11:53:04.000000000","updated_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"reviewer":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"state":"REVIEWER"},{"updated":"2019-09-30 14:58:46.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-01 07:20:19.000000000","updated_by":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"reviewer":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"state":"REVIEWER"},{"updated":"2019-10-01 09:53:51.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-01 12:29:46.000000000","updated_by":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"reviewer":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"state":"REVIEWER"},{"updated":"2019-10-01 17:08:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27ffe2bd1a778b6499ad8eb60233b2f0988a3ef0","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-09-30 09:28:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"daf32c130caab33afb47c07208517f52465cadd5","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2019-09-30 09:32:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"921daea62fbb5c036a9e7cdadbb6fb771f83da2f","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-09-30 10:52:36.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/67/685667/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/c039c43/ : FAILURE in 1h 22m 57s\n- tripleo-rhel-8-buildimage-overcloud-full http://logs.rdoproject.org/67/685667/1/openstack-check/tripleo-rhel-8-buildimage-overcloud-full/7ca6859/ : SUCCESS in 21m 38s (non-voting)\n- tripleo-rhel-8-buildimage-ironic-python-agent http://logs.rdoproject.org/67/685667/1/openstack-check/tripleo-rhel-8-buildimage-ironic-python-agent/2b76459/ : SUCCESS in 18m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"71d93e80816b5aceed44be04e5779cc9f8604b2c","author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"date":"2019-09-30 11:53:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8efa0510d3cca3bbf8efc02e03402a7c5142920d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-30 11:59:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9f089f1beb5a4e759adaa745a863ba61 : SUCCESS in 4m 23s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/16be0820c7c24b209e39b84222054fef : SUCCESS in 4m 55s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2f1d5a0d21e54997a7cf804ac8aee02a : SUCCESS in 3m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4cba1cb245b0407181e4f79acfaf7f37 : FAILURE in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/604167a943f54b47980c298e77a88480 : SUCCESS in 3m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6c39ac49f2384763b5f49fd40b948104 : SUCCESS in 3m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c8abd3fe44ab4522b9f32fff08d7ef1b : SUCCESS in 4m 15s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/fd0c0d76c30341cfb5e698cea3732891 : SUCCESS in 28m 18s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/d6a4269ec1e54ceeaac8200eba73c3ff : SUCCESS in 2h 20m 43s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/dcc11d120af140869cc6a6e0f8cd920d : SUCCESS in 2h 25m 59s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"65c3be1bc9bf6ddab8b795d18d8b875fe90f2325","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-09-30 14:58:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d55938a7b0380d709be90992fa43cef210173d9d","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-10-01 06:49:02.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"0a3e808da29b2b1886f3396cc993bfbb1e9d839e","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-01 09:53:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/67/685667/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/165b174/ : SUCCESS in 3h 04m 01s\n- tripleo-rhel-8-buildimage-overcloud-full http://logs.rdoproject.org/67/685667/2/openstack-check/tripleo-rhel-8-buildimage-overcloud-full/b2b269a/ : SUCCESS in 20m 43s (non-voting)\n- tripleo-rhel-8-buildimage-ironic-python-agent http://logs.rdoproject.org/67/685667/2/openstack-check/tripleo-rhel-8-buildimage-ironic-python-agent/c67aa38/ : SUCCESS in 18m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"37c7a38629f1441a183c0a30a1cf36f1bae6fc5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 12:29:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1f7b8737e517472bb3568a592b4bed95 : SUCCESS in 5m 35s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/5799ec763d6e4372a4ae54edce279153 : SUCCESS in 5m 10s (non-voting)\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7823a2df63c6426d920310ffa878b5e8 : SUCCESS in 3m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7e493792520e4f3d916d0391eadf68d0 : SUCCESS in 5m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bcc39610794648ac89868b5e65ddf344 : SUCCESS in 5m 57s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/8525e5d2190a44008128480a94353ad4 : SUCCESS in 29m 39s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/f8a8f08e0e4d4990b73a314cac0f95f8 : SUCCESS in 3h 35m 00s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/6104d027587e4473adb7ae441e33d4a0 : SUCCESS in 2h 27m 38s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/24f07612c91f43b685ec8a09e9061aba : SUCCESS in 2h 33m 23s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/54fa9984aa504a8c9b9260afa60fe17b : SUCCESS in 2h 54m 36s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/01ae04db25814b7aa8b65a6a28cd426a : SUCCESS in 2h 30m 13s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/03af433aafa141be8640ddc3ac4d1de6 : FAILURE in 2h 12m 28s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/6d1939119d4e4fb1ae9d884a134934e9 : FAILURE in 2h 00m 58s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d91f038664dd4e8d98ac5935eeb29877 : SUCCESS in 3m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7f93234535c44390a53b86bc87d2b483 : FAILURE in 3m 45s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/5c9880c08d1d467d9f2f9700de99a867 : SUCCESS in 3h 11m 47s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"aa76b3d8f83a14433b39f1591d6516c1fc52def7","author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"date":"2019-10-01 12:29:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d1a45f22a60c2c22c4be2814c655a8ab36b412f3","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-10-01 12:51:45.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"cd9283d7d56297c33d3db5e9a11e3cdcea8a4f9e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 12:52:03.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"87f90f7024e172b1e0a0a0b2c72076336b54a15e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 17:08:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"04dc223bd555c49b8c406f82b543061f8dc4958f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 17:08:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/839dbabd5e8f47f4a9c55cd9daef245e : SUCCESS in 6m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3b274edc8eba4cf097de868fd89ae57f : SUCCESS in 7m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b7eafe64676845d7954f106bceab9ac3 : SUCCESS in 4m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f2515809c054994b15dafa159ac8e76 : SUCCESS in 4m 57s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/0ef2dbe998fc47d08ff1e05efd23f6fc : SUCCESS in 27m 21s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/7421b59dde514a66857bd1e1936f44b5 : SUCCESS in 3h 07m 02s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/cc3cd99be1094aa68e7fa002781831cb : SUCCESS in 2h 17m 03s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/92eb9c52f2de46b6834a36165b6f6c77 : SUCCESS in 2h 27m 25s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/1f6da3c9d83345ff883409205e60e1f2 : SUCCESS in 1h 53m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/342baa26fae644f997988bf02328f180 : SUCCESS in 3m 53s","accounts_in_message":[],"_revision_number":2},{"id":"908052a716bda286a53cb44367ba2bc893cff713","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 17:09:57.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e64adbcf9d7a44e3812ae4325e8603a5 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":2},{"id":"d97e3ced160777c6f268b00e75b783c60e336d76","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-10-01 17:29:29.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 6df724aa5ced44a821bf6a2cfd85f3272f32b3aa","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"99a96ef416e04aaa133dfc5bd2f689e14e36354e","revisions":{"1472fd4da85e11aa5a7ba96f3e2736dbb80b932b":{"kind":"REWORK","_number":1,"created":"2019-09-30 09:28:40.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/67/685667/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/67/685667/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/1"}}},"commit":{"parents":[{"commit":"782cd28ca98adf0733fde190930532a146a879db","subject":"Merge \"Add ovn_dbs_vip to export_data\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/782cd28ca98adf0733fde190930532a146a879db"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-09-30 09:20:07.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-09-30 09:28:27.000000000","tz":120},"subject":"Close some file descriptors that were left open","message":"Close some file descriptors that were left open\n\nBefore:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027fencetest.yaml\u0027 mode\u003d\u0027w\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027instackenv.json\u0027 mode\u003d\u0027r\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 56494), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d9, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 54102), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nAfter:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 47694), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d8, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 45306), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nNote that we also explicitly close an opened FileType in tripleoclient/v1/overcloud_execute.py\nas it was spotted while writing this review.\n\nNB: The SSL warnings will be investigated separately\n\nChange-Id: Ic8122ad1982deed0434d797a3fb0fba8512b27ab\nCloses-Bug: #1845927\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/1472fd4da85e11aa5a7ba96f3e2736dbb80b932b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/1472fd4da85e11aa5a7ba96f3e2736dbb80b932b"}]},"branch":"refs/heads/master"},"99a96ef416e04aaa133dfc5bd2f689e14e36354e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-10-01 06:49:02.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/67/685667/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/67/685667/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/67/685667/2"}}},"commit":{"parents":[{"commit":"d31fbf2e4cac5f30443723667b22974cf098d0c5","subject":"Disable voting on openstack-tox-py27","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/d31fbf2e4cac5f30443723667b22974cf098d0c5"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-09-30 09:20:07.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-10-01 06:49:02.000000000","tz":0},"subject":"Close some file descriptors that were left open","message":"Close some file descriptors that were left open\n\nBefore:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027fencetest.yaml\u0027 mode\u003d\u0027w\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027instackenv.json\u0027 mode\u003d\u0027r\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 56494), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d9, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 54102), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nAfter:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 47694), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d8, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 45306), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nNote that we also explicitly close an opened FileType in tripleoclient/v1/overcloud_execute.py\nas it was spotted while writing this review.\n\nNB: The SSL warnings will be investigated separately\n\nChange-Id: Ic8122ad1982deed0434d797a3fb0fba8512b27ab\nCloses-Bug: #1845927\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/99a96ef416e04aaa133dfc5bd2f689e14e36354e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/99a96ef416e04aaa133dfc5bd2f689e14e36354e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}