)]}'
{"id":"openstack%2Fpython-tripleoclient~686015","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Fstein~Ic8122ad1982deed0434d797a3fb0fba8512b27ab","project":"openstack/python-tripleoclient","branch":"stable/stein","topic":"fix_close_warnings-stable/stein","hashtags":[],"change_id":"Ic8122ad1982deed0434d797a3fb0fba8512b27ab","subject":"Close some file descriptors that were left open","status":"MERGED","created":"2019-10-01 17:29:29.000000000","updated":"2019-10-02 10:29:45.000000000","submitted":"2019-10-02 10:28:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"686015-1570012119353-b42f53c0","meta_rev_id":"b0fee24a3be0dc22ce38e6bef045cc3c4f378ccc","_number":686015,"virtual_id_number":686015,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-02 10:28:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-10-01 20:31:01.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-02 06:55:44.000000000","_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-02 06:55:44.000000000","_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-01 20:31:01.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-02 06:55:44.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2019-10-02 10:28:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9107d0bd0ffc20f5e6337e7fc6f254be30c49e1e","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-10-01 17:29:29.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"0efd33a46fcb2caf87d5943e2039911e00f141ef","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-01 20:31:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/15/686015/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/a07052b/ : FAILURE in 3h 00m 20s","accounts_in_message":[],"_revision_number":1},{"id":"fae4559eea8a3231ffd8b651f406d1c5d109d0f6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 00:49:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/230466a38bfc4ef18e0cdf30ddaed1b9 : SUCCESS in 6m 38s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/381a37acafe544ff80be62ca888fd54c : FAILURE in 6m 25s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05fa55c0dc4c4f439b3b8a4f50983398 : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/993a4cbdee6146089feab71ba80d5e26 : SUCCESS in 4m 33s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d3d221990a854fc5abb93046dbd48552 : SUCCESS in 4m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1206930b2d7b4155866c0351567fe611 : SUCCESS in 5m 52s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3070928a11404d8cb4564b0af407d059 : SUCCESS in 5m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a291ec03b7ba4b02ab507d4d66efec46 : SUCCESS in 6m 00s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/ec1154b4477c465fb9760dca6a55883b : SUCCESS in 31m 13s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/60f569b087fd42afb8322e790bc91f57 : SUCCESS in 3h 21m 19s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/f12e0cd20c6d4536a27194fc8ab18303 : SUCCESS in 2h 08m 18s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/fd14788b7d8048c3812164815888b05f : SUCCESS in 3h 01m 45s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/775f7dd8dbb14467873f1112ed11553a : SUCCESS in 3h 00m 33s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/822eef750ce048409adfeba15bb2a220 : SUCCESS in 2h 22m 59s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/2511a04ac4294643b0a06cd3b82cb188 : FAILURE in 1h 52m 32s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/a64ee5208f2a4278a7f04bd65ad2c4c7 : SUCCESS in 3h 38m 30s (non-voting)\n- tripleo-ci-centos-7-scenario008-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/201b1445b2c34a5b9502fa879d3ec233 : FAILURE in 1h 48m 56s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/24306839c7fa4799bc135671f7c53db1 : SUCCESS in 3h 30m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8f1e3f93a4a666cb1e4750a4284873759d628365","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2019-10-02 06:55:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nlooks like clean cherrypick \u0026 https://review.opendev.org/#/c/685667/2 merged","accounts_in_message":[],"_revision_number":1},{"id":"d7f28752ec59ca6e0d4743df90eee0dc0c0f90e9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 06:55:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e2073205ecea2d0088a72ed79b9738f74f7c2538","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 10:28:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8f83ebec6a204b1baad73e9bcc886fa2 : SUCCESS in 8m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bad0272784484a56994e35b2b6d95f3a : SUCCESS in 3m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/646de8bf67544f89b4e37c85e13b3742 : SUCCESS in 5m 58s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/cf4d1eb35c4147bc98784a6f52ac5ed8 : SUCCESS in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3b69db74f5fe4569bdca0fc3d972c438 : SUCCESS in 5m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6a821f9141154283a1f7711f40737548 : SUCCESS in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1af1b981b51c47428f1d3690f3660e89 : SUCCESS in 5m 53s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/b1865925647e4c3dad7a50d5e487a1ce : SUCCESS in 27m 06s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/bc45f64467304750a533e0016d49fa2a : SUCCESS in 3h 27m 25s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/e52adba2ba6f429cb633b71583b1ab65 : SUCCESS in 2h 21m 29s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/daa13f658e304a62bbefd7104c470c17 : SUCCESS in 3h 13m 07s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/50cb10943556452a9d3dde436e266c1c : SUCCESS in 2h 07m 08s","accounts_in_message":[],"_revision_number":1},{"id":"72e8fcb987e259f050493672cd380f40f6668c09","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 10:28:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"e6b7e77952f2b7bc5b1b62e93920a36f7cf1e782","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-02 10:29:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15e58bd1d6cf4f75b67eb747da94ba17 : SUCCESS in 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6df724aa5ced44a821bf6a2cfd85f3272f32b3aa","revisions":{"6df724aa5ced44a821bf6a2cfd85f3272f32b3aa":{"kind":"REWORK","_number":1,"created":"2019-10-01 17:29:29.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/15/686015/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/15/686015/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/15/686015/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/15/686015/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/15/686015/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/15/686015/1"}}},"commit":{"parents":[{"commit":"5fa86b7aa5598242c6151e745994230c1283fc1e","subject":"[stein-only] Fix incomplete backport","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/5fa86b7aa5598242c6151e745994230c1283fc1e"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-09-30 09:20:07.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-10-01 17:29:29.000000000","tz":0},"subject":"Close some file descriptors that were left open","message":"Close some file descriptors that were left open\n\nBefore:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027fencetest.yaml\u0027 mode\u003d\u0027w\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file \u003c_io.TextIOWrapper name\u003d\u0027instackenv.json\u0027 mode\u003d\u0027r\u0027 encoding\u003d\u0027UTF-8\u0027\u003e\n  ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 56494), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d9, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 54102), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nAfter:\n(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d4, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 47694), raddr\u003d(\u0027192.168.24.2\u0027, 13000)\u003e\nsys:1: ResourceWarning: unclosed \u003cssl.SSLSocket fd\u003d8, family\u003dAddressFamily.AF_INET, type\u003dSocketKind.SOCK_STREAM, proto\u003d6, laddr\u003d(\u0027192.168.24.2\u0027, 45306), raddr\u003d(\u0027192.168.24.2\u0027, 13989)\u003e\n\nNote that we also explicitly close an opened FileType in tripleoclient/v1/overcloud_execute.py\nas it was spotted while writing this review.\n\nNB: The SSL warnings will be investigated separately\n\nChange-Id: Ic8122ad1982deed0434d797a3fb0fba8512b27ab\nCloses-Bug: #1845927\n(cherry picked from commit 99a96ef416e04aaa133dfc5bd2f689e14e36354e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/6df724aa5ced44a821bf6a2cfd85f3272f32b3aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/6df724aa5ced44a821bf6a2cfd85f3272f32b3aa"}]},"parents_data":[{"branch_name":"refs/heads/stable/stein","commit_id":"5fa86b7aa5598242c6151e745994230c1283fc1e","is_merged_in_target_branch":false,"change_id":"I8b63e1664320c51412e7f70d0379f11874d39eb7","change_number":684748,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}