)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9271825f27c31b566f07d42ee469f39aa223e42","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the existing plan."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie7f1a4269936f98ad86db4993992e0b9a27edf73"},{"line_number":15,"context_line":"Resolves: rhbz#1753251"},{"line_number":16,"context_line":"Signed-off-by: ekultails \u003cekultails@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_5092284d","line":15,"updated":"2019-10-07 21:17:41.000000000","message":"should use upstream launchpad bugs","commit_id":"c0e6f69044d4cb31d0e16ac6de4a1709265036c9"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"89125828fbcad7a4d78a9ba9124b26171e4e4768","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the existing plan."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie7f1a4269936f98ad86db4993992e0b9a27edf73"},{"line_number":15,"context_line":"Resolves: rhbz#1753251"},{"line_number":16,"context_line":"Signed-off-by: ekultails \u003cekultails@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_abf3dfe6","line":15,"in_reply_to":"3fa7e38b_5092284d","updated":"2019-10-08 17:41:47.000000000","message":"Done","commit_id":"c0e6f69044d4cb31d0e16ac6de4a1709265036c9"}],"tripleoclient/workflows/plan_management.py":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"add90ad54ba34e95931fb194dcb6f58adeee4917","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        passwords \u003d _load_passwords(swift_client, name)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # If no passwords were found in the plan, reset the variable."},{"line_number":209,"context_line":"        if passwords is False:"},{"line_number":210,"context_line":"            passwords \u003d None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # TODO(dmatthews): Removing the existing plan files should probably be"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fc2fada4","line":209,"updated":"2019-10-03 07:31:27.000000000","message":"You can return None instead False and remove this lines","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"aec66909019cb407176fc57a9407f83dcbf5dbbc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        passwords \u003d _load_passwords(swift_client, name)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        # If no passwords were found in the plan, reset the variable."},{"line_number":209,"context_line":"        if passwords is False:"},{"line_number":210,"context_line":"            passwords \u003d None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # TODO(dmatthews): Removing the existing plan files should probably be"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a0e01c98","line":209,"in_reply_to":"3fa7e38b_fc2fada4","updated":"2019-10-03 21:35:52.000000000","message":"Done","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"de09b89fef8566036e71bde2ea9c721f874b464a","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return plan_env[\u0027passwords\u0027]"},{"line_number":300,"context_line":"    else:"},{"line_number":301,"context_line":"        LOG.error(\"No passwords in plan. The deployment plan \" +"},{"line_number":302,"context_line":"                  \"%s is incomplete.\", name)"},{"line_number":303,"context_line":"        return False"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ae825fff","line":302,"updated":"2019-10-03 01:07:32.000000000","message":"i wouldn\u0027t use LOG.error here b/c we actually continue running and fix it.\n\nInstead I\u0027d use LOG.warning, and say how it will be fixed such as:\n\n\"No passwords found in existing plan. Updating plan with passwords.\"","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"add90ad54ba34e95931fb194dcb6f58adeee4917","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return plan_env[\u0027passwords\u0027]"},{"line_number":300,"context_line":"    else:"},{"line_number":301,"context_line":"        LOG.error(\"No passwords in plan. The deployment plan \" +"},{"line_number":302,"context_line":"                  \"%s is incomplete.\", name)"},{"line_number":303,"context_line":"        return False"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_dc175151","line":302,"in_reply_to":"3fa7e38b_ae825fff","updated":"2019-10-03 07:31:27.000000000","message":"+1 for Warning, also instead of concatenation of strings you can do:\nLOG.warning(\"No passwords in plan. The deployment plan \"\n            \"{} is incomplete.\".format(name))","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"aec66909019cb407176fc57a9407f83dcbf5dbbc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return plan_env[\u0027passwords\u0027]"},{"line_number":300,"context_line":"    else:"},{"line_number":301,"context_line":"        LOG.error(\"No passwords in plan. The deployment plan \" +"},{"line_number":302,"context_line":"                  \"%s is incomplete.\", name)"},{"line_number":303,"context_line":"        return False"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_00e9f07e","line":302,"in_reply_to":"3fa7e38b_ae825fff","updated":"2019-10-03 21:35:52.000000000","message":"Done","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"aec66909019cb407176fc57a9407f83dcbf5dbbc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        return plan_env[\u0027passwords\u0027]"},{"line_number":300,"context_line":"    else:"},{"line_number":301,"context_line":"        LOG.error(\"No passwords in plan. The deployment plan \" +"},{"line_number":302,"context_line":"                  \"%s is incomplete.\", name)"},{"line_number":303,"context_line":"        return False"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_20ee6c88","line":302,"in_reply_to":"3fa7e38b_dc175151","updated":"2019-10-03 21:35:52.000000000","message":"Done","commit_id":"30bb9f1555da4e79fdad77291b18d527a8e3d85e"}]}