)]}'
{"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4102425367ab50f054552bda97d04c1986b723b4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if \u0027snmp\u0027 in enabled_hardware_types:"},{"line_number":185,"context_line":"        power_interfaces.add(\u0027snmp\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    deploy_interfaces \u003d {\u0027iscsi\u0027, \u0027direct\u0027}"},{"line_number":188,"context_line":"    if \u0027fake-hardware\u0027 in enabled_hardware_types:"},{"line_number":189,"context_line":"        deploy_interfaces.add(\u0027fake\u0027)"},{"line_number":190,"context_line":"        boot_interfaces.add(\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d7cb67a2","line":187,"updated":"2019-10-08 08:59:55.000000000","message":"Don\u0027t we enable ansible deploy in the undercloud as well?","commit_id":"cf0240067b08be065d2631a3a8ae6fdd9e101196"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"655d0b73eccad47d75bc95f9016d4551722f48e9","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if \u0027snmp\u0027 in enabled_hardware_types:"},{"line_number":185,"context_line":"        power_interfaces.add(\u0027snmp\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    deploy_interfaces \u003d {\u0027iscsi\u0027, \u0027direct\u0027}"},{"line_number":188,"context_line":"    if \u0027fake-hardware\u0027 in enabled_hardware_types:"},{"line_number":189,"context_line":"        deploy_interfaces.add(\u0027fake\u0027)"},{"line_number":190,"context_line":"        boot_interfaces.add(\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_822faff4","line":187,"in_reply_to":"3fa7e38b_bc6c8308","updated":"2019-10-29 14:18:52.000000000","message":"Maybe we should rather do all interface management here and remove it from the environment?","commit_id":"cf0240067b08be065d2631a3a8ae6fdd9e101196"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"93a4601775e0d107762f1a34629e120912fdf15f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    if \u0027snmp\u0027 in enabled_hardware_types:"},{"line_number":185,"context_line":"        power_interfaces.add(\u0027snmp\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    deploy_interfaces \u003d {\u0027iscsi\u0027, \u0027direct\u0027}"},{"line_number":188,"context_line":"    if \u0027fake-hardware\u0027 in enabled_hardware_types:"},{"line_number":189,"context_line":"        deploy_interfaces.add(\u0027fake\u0027)"},{"line_number":190,"context_line":"        boot_interfaces.add(\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_bc6c8308","line":187,"in_reply_to":"3fa7e38b_d7cb67a2","updated":"2019-10-08 20:38:42.000000000","message":"Ah yes, I didn\u0027t notice the undercloud environment overrides the defaults in tht.\n\nMaybe it would be cleaner to just add the required fakes to the undercloud env[1] so they\u0027re always available as an option\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/environments/undercloud.yaml#L112-L115","commit_id":"cf0240067b08be065d2631a3a8ae6fdd9e101196"}]}