)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"dc999f4c9d3bbf936b209d53e70bbd138db3daff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Undercloud hosts entries in overcloud parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running overcloud deploy set the UndercloudHostsEntries"},{"line_number":10,"context_line":"parameter to include the \u003cshortname\u003e.ctlplane.localdomain entry"},{"line_number":11,"context_line":"from /etc/hosts on the undercloud."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"With IPv6 the overcloud nodes cannot pull images from the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_f8697224","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":57},"updated":"2019-10-11 12:19:13.000000000","message":"Nit - could you change to remove \"localdomain\" to match code?","commit_id":"8f125d49d04e78a6699a408d3de547f6334e156f"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3811abe00d167bc5b95a81bfd9d087497b9cf04b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            start \u003d [idx for idx, item in enumerate(hosts)"},{"line_number":132,"context_line":"                     if item.startswith(\u0027# HEAT_HOSTS_START\u0027)][0]"},{"line_number":133,"context_line":"            end \u003d [idx for idx, item in enumerate(hosts)"},{"line_number":134,"context_line":"                   if item.startswith(\u0027# HEAT_HOSTS_END\u0027)][0]"},{"line_number":135,"context_line":"            hosts \u003d hosts[start + 1:end]"},{"line_number":136,"context_line":"        except IndexError:"},{"line_number":137,"context_line":"            hosts \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ca7f1cdd","line":134,"updated":"2019-10-09 22:19:13.000000000","message":"Is it that the only entries which need to be propagated are *.ctlplane.*? If so then you could do the same `getent hosts` approach I suggested in https://review.opendev.org/#/c/687305","commit_id":"cee6b78c80245c2b451d64e2212330ca9dd11f3d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"abe8bb84432eed0bbf12c6e2634a87c1c45f0252","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            start \u003d [idx for idx, item in enumerate(hosts)"},{"line_number":132,"context_line":"                     if item.startswith(\u0027# HEAT_HOSTS_START\u0027)][0]"},{"line_number":133,"context_line":"            end \u003d [idx for idx, item in enumerate(hosts)"},{"line_number":134,"context_line":"                   if item.startswith(\u0027# HEAT_HOSTS_END\u0027)][0]"},{"line_number":135,"context_line":"            hosts \u003d hosts[start + 1:end]"},{"line_number":136,"context_line":"        except IndexError:"},{"line_number":137,"context_line":"            hosts \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e60b30d2","line":134,"in_reply_to":"3fa7e38b_ca7f1cdd","updated":"2019-10-10 03:38:34.000000000","message":"yes, it\u0027s only the ctlplane entry.\n\nDone.","commit_id":"cee6b78c80245c2b451d64e2212330ca9dd11f3d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"b2ced030e96ea7f5c5668fbb6c9992d014286f8a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        The host entry will be added on overcloud nodes"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        ctlplane_hostname \u003d \u0027.\u0027.join("},{"line_number":131,"context_line":"            [utils.get_short_hostname(), \u0027ctlplane\u0027, \u0027localdomain\u0027])"},{"line_number":132,"context_line":"        cmd \u003d [\u0027getent\u0027, \u0027hosts\u0027, ctlplane_hostname]"},{"line_number":133,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE)"},{"line_number":134,"context_line":"        out, err \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a398bf74","line":131,"updated":"2019-10-10 14:50:47.000000000","message":"hard coding localdomain doesn\u0027t seem right. this is actually configurable on the undercloud side with the \"overcloud_domain_name\" option from undercloud.conf. Note that overcloud in this case refers to the standalone cloud (bad naming I know).\n\npoint is, i think you need to look up the value somehow and not assume localdomain is used.","commit_id":"b002b7e3c064e6425941208d1a01ad461fc2f819"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c9fb8dbb69e81f462ed7f642f5a7dbd6bdf74cbc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        The host entry will be added on overcloud nodes"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        ctlplane_hostname \u003d \u0027.\u0027.join("},{"line_number":131,"context_line":"            [utils.get_short_hostname(), \u0027ctlplane\u0027, \u0027localdomain\u0027])"},{"line_number":132,"context_line":"        cmd \u003d [\u0027getent\u0027, \u0027hosts\u0027, ctlplane_hostname]"},{"line_number":133,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE)"},{"line_number":134,"context_line":"        out, err \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fc0bb4d1","line":131,"in_reply_to":"3fa7e38b_a398bf74","updated":"2019-10-10 16:37:51.000000000","message":"I thought \u0027overcloud_domain_name\u0027 only sets the domain in some nova conf file. It does not set the CloudDomain parameter anywhere in undercloud_config.py.\n\nLooking at the code again, it\u0027s set by the \u0027--local-domain\u0027 here https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_config.py#L444-L446 ?\n\nI will update this. Thanks James!","commit_id":"b002b7e3c064e6425941208d1a01ad461fc2f819"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0d998967447015ea9445159be632c651119407d5","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        The host entry will be added on overcloud nodes"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        ctlplane_hostname \u003d \u0027.\u0027.join([utils.get_short_hostname(), \u0027ctlplane\u0027])"},{"line_number":131,"context_line":"        cmd \u003d [\u0027getent\u0027, \u0027hosts\u0027, ctlplane_hostname]"},{"line_number":132,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE)"},{"line_number":133,"context_line":"        out, err \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_35f4f3f0","line":130,"range":{"start_line":130,"start_character":37,"end_line":130,"end_character":78},"updated":"2019-10-11 09:48:32.000000000","message":"The hosts entry will look like:\n  fd12:3456:789a:1::1 undercloud.ctlplane.localdomain undercloud.ctlplane\n\nWe do the getent on undercloud.ctlplane without the domain since domain is variable.","commit_id":"8f125d49d04e78a6699a408d3de547f6334e156f"}]}