)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3aff830e7d201290d8c0b626b2ba0f47b04ed067","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Use the undercloud hostname on the ctlplane network."},{"line_number":14,"context_line":"\u003cshortname\u003e.ctlplane.\u003cdomain\u003e for local container registry."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-Bug: #1836578"},{"line_number":17,"context_line":"Depends-On: I23b8ca6a3f481781d9d91e1a5d83ab1311a272e2"},{"line_number":18,"context_line":"Change-Id: Iec0f4f8279e5628dcb867312504acdc4fafc8152"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3fa7e38b_7db694fb","line":16,"updated":"2019-10-16 09:41:22.000000000","message":"k then per irc just now also add that please https://bugs.launchpad.net/tripleo/+bug/1848275","commit_id":"35152fe4b69cb4fa0c5f268d0f97a8d1494088b4"}],"tripleoclient/utils.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4876e06f5d56bc3922bcfdcd25cf41b586326bda","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"    return run_command(args, name\u003d\u0027hostnamectl\u0027)"},{"line_number":1660,"context_line":""},{"line_number":1661,"context_line":""},{"line_number":1662,"context_line":"def get_shortname():"},{"line_number":1663,"context_line":"    \"\"\"Get the systems shortname\"\"\""},{"line_number":1664,"context_line":"    return socket.gethostname().split(\u0027.\u0027)[0]"},{"line_number":1665,"context_line":""},{"line_number":1666,"context_line":""},{"line_number":1667,"context_line":"def check_hostname(fix_etc_hosts\u003dTrue, logger\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_06ce8cb3","line":1664,"range":{"start_line":1662,"start_character":0,"end_line":1664,"end_character":45},"updated":"2019-10-10 03:20:04.000000000","message":"we already have utils.get_short_hostname() here.","commit_id":"e52607752ef030db0402fdcd50fbb4d6eec0e6d4"}],"tripleoclient/v1/undercloud_config.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6cdf163ca1d946aa246753815b24c68139d3d5ec","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        env_data[\u0027NeutronDnsDomain\u0027] \u003d CONF[\u0027overcloud_domain_name\u0027]"},{"line_number":448,"context_line":"        deploy_args.append(\u0027--local-domain\u003d%s\u0027 % CONF[\u0027overcloud_domain_name\u0027])"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_shortname(),"},{"line_number":451,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":452,"context_line":"                                    \u0027localdomain\u0027])"},{"line_number":453,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":454,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c56cedd1","line":452,"range":{"start_line":450,"start_character":4,"end_line":452,"end_character":51},"updated":"2019-10-09 22:56:42.000000000","message":"Can we just replace all of get_undercloud_registry() with this?","commit_id":"e52607752ef030db0402fdcd50fbb4d6eec0e6d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fa4b086d1b599d3b626c4a67d52a57c3875e806b","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        env_data[\u0027NeutronDnsDomain\u0027] \u003d CONF[\u0027overcloud_domain_name\u0027]"},{"line_number":448,"context_line":"        deploy_args.append(\u0027--local-domain\u003d%s\u0027 % CONF[\u0027overcloud_domain_name\u0027])"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_shortname(),"},{"line_number":451,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":452,"context_line":"                                    \u0027localdomain\u0027])"},{"line_number":453,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":454,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_40ed4bee","line":452,"range":{"start_line":450,"start_character":4,"end_line":452,"end_character":51},"in_reply_to":"3fa7e38b_c56cedd1","updated":"2019-10-10 01:28:22.000000000","message":"I guess we can, this + the process call to check that the host entry is there as done in the update on https://review.opendev.org/687305. \n\nIf it\u0027s not in /etc/hosts we should raise an error.","commit_id":"e52607752ef030db0402fdcd50fbb4d6eec0e6d4"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6cdf163ca1d946aa246753815b24c68139d3d5ec","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    if CONF.get(\u0027container_registry_mirror\u0027, None):"},{"line_number":476,"context_line":"        env_data[\u0027DockerRegistryMirror\u0027] \u003d CONF[\u0027container_registry_mirror\u0027]"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    # This parameter the IP address used to bind the local container registry"},{"line_number":479,"context_line":"    env_data[\u0027LocalContainerRegistry\u0027] \u003d local_registry_name"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    if CONF[\u0027additional_architectures\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e52329a6","line":478,"updated":"2019-10-09 22:56:42.000000000","message":"LocalContainerRegistry propagates through to here[1], which I\u0027m pretty sure means that it needs to remain an IP address\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tripleo-image-serve/templates/image-serve.conf.j2#L4","commit_id":"e52607752ef030db0402fdcd50fbb4d6eec0e6d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fa4b086d1b599d3b626c4a67d52a57c3875e806b","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    if CONF.get(\u0027container_registry_mirror\u0027, None):"},{"line_number":476,"context_line":"        env_data[\u0027DockerRegistryMirror\u0027] \u003d CONF[\u0027container_registry_mirror\u0027]"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    # This parameter the IP address used to bind the local container registry"},{"line_number":479,"context_line":"    env_data[\u0027LocalContainerRegistry\u0027] \u003d local_registry_name"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    if CONF[\u0027additional_architectures\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_00a2f3ae","line":478,"in_reply_to":"3fa7e38b_e52329a6","updated":"2019-10-10 01:28:22.000000000","message":"Using a name is fine for apache, I believe it will bind to all interfaces but/and apache only respond if the name is used in the request.\n\nThis also propagates to: https://opendev.org/openstack/tripleo-common/src/branch/master/tripleo_common/image/kolla_builder.py#L185\n\nWhich means it must be a name.\n\nIf want to keep apache binding to the specific IP I guess we can add a new parameter with the IP and update THT to use the new parameter.\n\nIf we worry about accessing the registry outside we can add the interface to the firewall rules: https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/image-serve/image-serve-baremetal-ansible.yaml#L47","commit_id":"e52607752ef030db0402fdcd50fbb4d6eec0e6d4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"becf4fae65210526bf0533a0661a41b3006afb13","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_short_hostname(),"},{"line_number":452,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":453,"context_line":"                                    \u0027localdomain\u0027])"},{"line_number":454,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":456,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_9c15e0e7","line":453,"range":{"start_line":453,"start_character":37,"end_line":453,"end_character":48},"updated":"2019-10-10 16:39:41.000000000","message":"see: https://review.opendev.org/#/c/687347/3/tripleoclient/v1/overcloud_deploy.py@131","commit_id":"995ae202d504f442eb8cf8fe135d7b818aa2b351"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"357bf8079aadd7b92fed040b813461803c07b8da","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_short_hostname(),"},{"line_number":452,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":453,"context_line":"                                    CONF[\u0027overcloud_domain_name\u0027]])"},{"line_number":454,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":456,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_787ee2e4","line":453,"range":{"start_line":453,"start_character":35,"end_line":453,"end_character":66},"updated":"2019-10-11 12:15:55.000000000","message":"Can the domain be removed similar to https://review.opendev.org/#/c/687305/8/tripleo_common/image/image_uploader.py?","commit_id":"abc2f02ee6c5027792b633ea4306449f46fac382"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"1360648be685868ddac0f9505186facc7e7ebd2c","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_short_hostname(),"},{"line_number":452,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":453,"context_line":"                                    CONF[\u0027overcloud_domain_name\u0027]])"},{"line_number":454,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":456,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_ea67554c","line":453,"range":{"start_line":453,"start_character":35,"end_line":453,"end_character":66},"in_reply_to":"3fa7e38b_49eb1a77","updated":"2019-10-11 16:44:32.000000000","message":"OK.","commit_id":"abc2f02ee6c5027792b633ea4306449f46fac382"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"35b086dbe87e77f15cd8cf838892e2f3ea6d0867","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    local_registry_name \u003d \u0027.\u0027.join([utils.get_short_hostname(),"},{"line_number":452,"context_line":"                                    \u0027ctlplane\u0027,"},{"line_number":453,"context_line":"                                    CONF[\u0027overcloud_domain_name\u0027]])"},{"line_number":454,"context_line":"    if CONF.get(\u0027container_cli\u0027, \u0027podman\u0027) \u003d\u003d \u0027podman\u0027:"},{"line_number":455,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027] \u003d [local_registry_name]"},{"line_number":456,"context_line":"        env_data[\u0027DockerInsecureRegistryAddress\u0027].append("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_49eb1a77","line":453,"range":{"start_line":453,"start_character":35,"end_line":453,"end_character":66},"in_reply_to":"3fa7e38b_787ee2e4","updated":"2019-10-11 15:08:56.000000000","message":"https://review.opendev.org/#/c/687305/8/tripleo_common/image/image_uploader.py L111 picks the fqdn in the host entry. If we drop this here we\u0027d need to pick the shortname there.\n\nI think we should use the fqdn for the virtual host in image-server.","commit_id":"abc2f02ee6c5027792b633ea4306449f46fac382"}]}