)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d572c22b3f1524ed0c57a0c9814b9420afe05ac3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"can find it. /etc/hosts is only updated if `# HEAT_HOSTS_START`"},{"line_number":12,"context_line":"is not already in in /etc/hosts, i.e only the first time deploy/"},{"line_number":13,"context_line":"install iommand is run. The `HEAT_HOSTS_START - HEAT_HOSTS_END`"},{"line_number":14,"context_line":"tags are used so that the THT deployment of hosts entries will"},{"line_number":15,"context_line":"overwrite this temporary entry that we only need during the first"},{"line_number":16,"context_line":"deploy/install. This ensures docker_config.yaml is written with an"},{"line_number":17,"context_line":"image reference that works on the first attempt to deploy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_a231e75a","line":14,"updated":"2020-02-04 22:12:35.000000000","message":"this is no longer the case","commit_id":"21d459dce3f9bd3fe1175b376ca107c2df569cfd"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"8b43b932c21306fb162a25b948a4094f547fd807","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        return environments + user_environments"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def _add_fqdn_to_insecure_registries(self, env, parsed_args):"},{"line_number":772,"context_line":"        ip_nw \u003d netaddr.IPNetwork(parsed_args.local_ip)"},{"line_number":773,"context_line":"        ip \u003d str(ip_nw.ip)"},{"line_number":774,"context_line":"        if \u0027%s:%s\u0027 % (ip, \u00278787\u0027) in env[\u0027parameter_defaults\u0027].get("},{"line_number":775,"context_line":"                \u0027DockerInsecureRegistryAddress\u0027, []):"},{"line_number":776,"context_line":"            hostname \u003d utils.get_short_hostname()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_145fa40f","line":773,"range":{"start_line":772,"start_character":7,"end_line":773,"end_character":26},"updated":"2019-10-25 14:56:07.000000000","message":"Can you do this in 1 line as in line 153?","commit_id":"1a85085980294482a67272cd1d82075d0b650488"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"57759303d291e48f83e46dc8796e13f5e6d7c083","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        return environments + user_environments"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"    def _add_fqdn_to_insecure_registries(self, env, parsed_args):"},{"line_number":772,"context_line":"        ip_nw \u003d netaddr.IPNetwork(parsed_args.local_ip)"},{"line_number":773,"context_line":"        ip \u003d str(ip_nw.ip)"},{"line_number":774,"context_line":"        if \u0027%s:%s\u0027 % (ip, \u00278787\u0027) in env[\u0027parameter_defaults\u0027].get("},{"line_number":775,"context_line":"                \u0027DockerInsecureRegistryAddress\u0027, []):"},{"line_number":776,"context_line":"            hostname \u003d utils.get_short_hostname()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_03944836","line":773,"range":{"start_line":772,"start_character":7,"end_line":773,"end_character":26},"in_reply_to":"3fa7e38b_145fa40f","updated":"2019-10-25 17:38:28.000000000","message":"Done","commit_id":"1a85085980294482a67272cd1d82075d0b650488"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"34f7658eceb947b0700e8e669645716b24f8bd9f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        with open(\u0027/etc/hosts\u0027, \u0027r\u0027) as hosts_file:"},{"line_number":147,"context_line":"            hosts \u003d hosts_file.read()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if \u0027# HEAT_HOSTS_START\u0027 in hosts:"},{"line_number":150,"context_line":"            # Heat host entries are already there, don\u0027t change the file."},{"line_number":151,"context_line":"            return"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_1eab21d6","line":149,"updated":"2019-10-29 00:44:42.000000000","message":"can\u0027t you check if the needed entry is in /etc/hosts instead of looking for this special string?\n\nI\u0027ve got a patch up to actually move away from the hosts_config.sh script that adds those strings:\n\nhttps://review.opendev.org/#/c/690154/\n\nas you\u0027re already computing the needed line below, why don\u0027t you just check if that line is in /etc/hosts already?","commit_id":"659598eca1d93766c5154bc8ca210c80bb09f426"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8705fb578b8bf3e719316ae94c04a6c749bdd2bd","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        with open(\u0027/etc/hosts\u0027, \u0027r\u0027) as hosts_file:"},{"line_number":147,"context_line":"            hosts \u003d hosts_file.read()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if \u0027# HEAT_HOSTS_START\u0027 in hosts:"},{"line_number":150,"context_line":"            # Heat host entries are already there, don\u0027t change the file."},{"line_number":151,"context_line":"            return"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_277370e9","line":149,"in_reply_to":"3fa7e38b_1eab21d6","updated":"2019-10-29 09:48:09.000000000","message":"Thanks for the heads up James! We have incompatible changes here, so we should get them in sync to avoid issues.\n\nI wanted this to not touch /etc/hosts when the stack is already managing it. But using the # HEAT_HOSTS_START marker won\u0027t work once your change lands. I will update this to look for the specific entry being added here. I still think we need to wrap it in the start/end marker we end up using to avoid duplicate entries.","commit_id":"659598eca1d93766c5154bc8ca210c80bb09f426"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2d6f21269c938e3dff211a0859dbf7475615d927","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        with open(\u0027/etc/hosts\u0027, \u0027r\u0027) as hosts_file:"},{"line_number":147,"context_line":"            hosts \u003d hosts_file.read()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if \u0027# HEAT_HOSTS_START\u0027 in hosts:"},{"line_number":150,"context_line":"            # Heat host entries are already there, don\u0027t change the file."},{"line_number":151,"context_line":"            return"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_45f52fca","line":149,"in_reply_to":"3fa7e38b_277370e9","updated":"2019-10-30 13:38:31.000000000","message":"Looking at this again, do we care about duplicate entries and ordering?\n\nIf we do, we need to check for the mark string used by the ansible role, and we need to write inside that block. If we don\u0027t care about duplicates this code can simply append the entry if it is\u0027nt there.","commit_id":"659598eca1d93766c5154bc8ca210c80bb09f426"}]}