)]}'
{"tripleoclient/v1/tripleo_launch_heat.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"033c8bc5928f44278b9441c3500a14eedd826383","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    msg \u003d _(\u0027Heat launch failed.\u0027)"},{"line_number":145,"context_line":"                    self.log.error(msg)"},{"line_number":146,"context_line":"                    raise exceptions.DeploymentError(msg)"},{"line_number":147,"context_line":"        finally:"},{"line_number":148,"context_line":"            # send erase sequence to reset the cmdline if paunch/ansible"},{"line_number":149,"context_line":"            # mangled some escape sequences"},{"line_number":150,"context_line":"            utils.reset_cmdline()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b1b1f793","line":150,"range":{"start_line":147,"start_character":0,"end_line":150,"end_character":33},"updated":"2019-12-05 19:45:22.000000000","message":"I think this is only for the tripleo deploy. This is a side effect of ansible/paunch/podman which I don\u0027t think is used here","commit_id":"97fcebc69849b8f845d4a4708419b7792c2186e1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"4b4a24e1afa823eb0b465fe82905ff95ecec83a0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    msg \u003d _(\u0027Heat launch failed.\u0027)"},{"line_number":145,"context_line":"                    self.log.error(msg)"},{"line_number":146,"context_line":"                    raise exceptions.DeploymentError(msg)"},{"line_number":147,"context_line":"        finally:"},{"line_number":148,"context_line":"            # send erase sequence to reset the cmdline if paunch/ansible"},{"line_number":149,"context_line":"            # mangled some escape sequences"},{"line_number":150,"context_line":"            utils.reset_cmdline()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e39c495c","line":150,"range":{"start_line":147,"start_character":0,"end_line":150,"end_character":33},"in_reply_to":"3fa7e38b_b1b1f793","updated":"2019-12-10 20:22:31.000000000","message":"Done","commit_id":"97fcebc69849b8f845d4a4708419b7792c2186e1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5151fe5a54fccfff0cfd8bb720d3d8b0626fd2bc","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _launch_heat(self, parsed_args):"},{"line_number":53,"context_line":"        # we do this as root to chown config files properly for docker, etc."},{"line_number":54,"context_line":"        if parsed_args.heat_native is not None and \\"},{"line_number":55,"context_line":"                parsed_args.heat_native.lower() \u003d\u003d \"false\":"},{"line_number":56,"context_line":"            self.heat_launch \u003d heat_launcher.HeatContainerLauncher("},{"line_number":57,"context_line":"                parsed_args.heat_api_port,"},{"line_number":58,"context_line":"                parsed_args.heat_container_image,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_34759cc9","line":55,"range":{"start_line":54,"start_character":7,"end_line":55,"end_character":59},"updated":"2020-01-09 13:27:24.000000000","message":"It will avoid this kind of test to setup `heat_native` is a bool params by using `action\u003dstore_false` by example.","commit_id":"5dfccb6ccf83be9e88b967ae6b291df86bf815df"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d3ce16ac2759985638fa9d4acb6377137c9e2e94","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _launch_heat(self, parsed_args):"},{"line_number":53,"context_line":"        # we do this as root to chown config files properly for docker, etc."},{"line_number":54,"context_line":"        if parsed_args.heat_native is not None and \\"},{"line_number":55,"context_line":"                parsed_args.heat_native.lower() \u003d\u003d \"false\":"},{"line_number":56,"context_line":"            self.heat_launch \u003d heat_launcher.HeatContainerLauncher("},{"line_number":57,"context_line":"                parsed_args.heat_api_port,"},{"line_number":58,"context_line":"                parsed_args.heat_container_image,"},{"line_number":59,"context_line":"                parsed_args.heat_user,"},{"line_number":60,"context_line":"                parsed_args.heat_dir)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            self.heat_launch \u003d heat_launcher.HeatNativeLauncher("},{"line_number":63,"context_line":"                parsed_args.heat_api_port,"},{"line_number":64,"context_line":"                parsed_args.heat_container_image,"},{"line_number":65,"context_line":"                parsed_args.heat_user,"},{"line_number":66,"context_line":"                parsed_args.heat_dir)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.heat_launch.heat_db_sync()"},{"line_number":69,"context_line":"        self.heat_launch.launch_heat()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_34235cbd","line":66,"range":{"start_line":54,"start_character":8,"end_line":66,"end_character":37},"updated":"2020-01-09 13:29:41.000000000","message":"Then this section could be writed with something like:\n\n```\nlauncher \u003d heat_launcher.HeatNativeLauncher if parsed_args.heat_native else heat_launcher.HeatContainerLauncher\nself.heat_launch \u003d launcher(\n                parsed_args.heat_api_port,\n                parsed_args.heat_container_image,\n                parsed_args.heat_user,\n                parsed_args.heat_dir)\n```","commit_id":"5dfccb6ccf83be9e88b967ae6b291df86bf815df"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"abb7b8b48a968102c0b7383242fbf9ec4904776b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            \u0027--heat-native\u0027,"},{"line_number":106,"context_line":"            dest\u003d\u0027heat_native\u0027,"},{"line_number":107,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":108,"context_line":"            default\u003dNone,"},{"line_number":109,"context_line":"            const\u003d\"true\","},{"line_number":110,"context_line":"            help\u003d_(\u0027Execute the heat-all process natively on this host. \u0027"},{"line_number":111,"context_line":"                   \u0027This option requires that the heat-all binaries \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_f4be2462","line":108,"range":{"start_line":108,"start_character":20,"end_line":108,"end_character":24},"updated":"2020-01-09 13:25:30.000000000","message":"Why not setup this one to a bool by default (False by default) to avoid to check if is not None etc...","commit_id":"5dfccb6ccf83be9e88b967ae6b291df86bf815df"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c9b000b6e83fa55fbdba6a8d03b03a5a9bb36086","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            \u0027--heat-native\u0027,"},{"line_number":106,"context_line":"            dest\u003d\u0027heat_native\u0027,"},{"line_number":107,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":108,"context_line":"            default\u003dNone,"},{"line_number":109,"context_line":"            const\u003d\"true\","},{"line_number":110,"context_line":"            help\u003d_(\u0027Execute the heat-all process natively on this host. \u0027"},{"line_number":111,"context_line":"                   \u0027This option requires that the heat-all binaries \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4cb1a190","line":108,"range":{"start_line":108,"start_character":20,"end_line":108,"end_character":24},"in_reply_to":"3fa7e38b_f4be2462","updated":"2020-01-10 14:07:10.000000000","message":"mostly just because of consistency with tripleo_deploy.py and that\u0027s how it was done originally. it can always be refactored both places later.","commit_id":"5dfccb6ccf83be9e88b967ae6b291df86bf815df"}]}