)]}'
{"id":"openstack%2Fpython-tripleoclient~693255","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Fstein~I1a6b4df073b39924e6855ea865cfc856a1bdfe6b","project":"openstack/python-tripleoclient","branch":"stable/stein","topic":"steinbug/1851572","hashtags":[],"change_id":"I1a6b4df073b39924e6855ea865cfc856a1bdfe6b","subject":"Support undercloud fake-hardware ironic driver","status":"MERGED","created":"2019-11-06 21:18:59.000000000","updated":"2019-11-13 16:50:46.000000000","submitted":"2019-11-13 16:48:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"693255-1573663722140-752aeac9","meta_rev_id":"5ebb5f43e8ecfcdcca4bae01e155717f5e55dbb6","_number":693255,"virtual_id_number":693255,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-13 16:48:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-11-07 00:27:04.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-11-13 12:04:42.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-11-08 20:23:03.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2019-11-13 12:04:42.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-07 11:54:03.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-07 00:27:04.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-07 11:54:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-11-08 20:23:03.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2019-11-13 12:04:42.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-11-13 16:48:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f5e9bd5e3ae611da418da2bf0e911a5426d18d77","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-11-06 21:18:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"55e8bbeac26082ebd34d1c0a24eb3da9ec8db268","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-11-06 21:33:23.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"88ed1a4aa080eee818a1479385eab6c081984c96","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-11-07 00:27:04.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/55/693255/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/d26c9cf/ : FAILURE in 2h 53m 02s","accounts_in_message":[],"_revision_number":2},{"id":"58342abbdbf138beb3f73c9ca3acdf102535bf45","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-07 00:56:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/298f3167505f48b3adca90302d025500 : SUCCESS in 4m 25s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/dec6c85a0db0484ab297be8ebbbda026 : FAILURE in 5m 21s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f49a4d9ca8e04b2da92d01c817bb769e : SUCCESS in 4m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/61aec8664c9542cfac4301381a162292 : SUCCESS in 4m 42s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7904bc63afef405c8e7192bb66e33956 : SUCCESS in 3m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f9e1cebd2ca8449d91ee1d2ca82be2a5 : SUCCESS in 4m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1577da31b6174c08b6761569c8c41257 : SUCCESS in 4m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/284a64dbe5df40fd9f9cca208be30d95 : SUCCESS in 4m 59s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/fb342a2a3f5847629cb3964fc9a1d86d : SUCCESS in 24m 27s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/b85008a2775a435a90c15f6aee7b9424 : SUCCESS in 3h 01m 31s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/bac12993742d474a877b1950a63df73e : SUCCESS in 2h 05m 52s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/7039bebdc76748d7962d291bbf31ea00 : SUCCESS in 2h 32m 38s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/0f9ebbd164054dec990aedffb992236e : SUCCESS in 2h 42m 31s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/cc0e7624df254af18c84f5109ed35269 : SUCCESS in 2h 39m 50s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/137c1cb3f77943adaca3b5b08785f9b9 : FAILURE in 1h 44m 21s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/143919465862424fae0ffbecddb6a1ba : SUCCESS in 3h 10m 55s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/042c8fda58d74a8bb9697279fa9648f8 : SUCCESS in 2h 39m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1f90b2080b48e352d657a3a83f30c73cee5cfeea","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2019-11-08 20:23:03.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"44e9b3f8df7319474c338e6bf88721b59e1e5628","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-11-13 12:04:42.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"261a953f2a443aa3036b1d9b320e6df268a32880","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 12:05:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9b6aa79dd775e9fc96f5d09e4de7a7559de6fc78","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 16:48:41.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8f2bdc7e01074f4697a5a47c9ecf4254 : SUCCESS in 6m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5bb33b6bca144e26ad8697da7f3d8fa4 : SUCCESS in 5m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a41b54d3325c4738b1b10d2bd6ad53ee : SUCCESS in 6m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/89436dbcf76b4ed8837ffb682aff4d27 : SUCCESS in 5m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c860358adc1a49adb7918a8e7361d25c : SUCCESS in 5m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8192b2d750df41edaa20034370d779dd : SUCCESS in 6m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c42aa6151d14f34a51d4b3793a4d1d5 : SUCCESS in 5m 18s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/8236b585dcfa4f8b88e97ac085e9f556 : SUCCESS in 31m 35s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/ddc8f1fa31d84ca2b41e5f8d6bef1d35 : SUCCESS in 2h 27m 57s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/9fa235e2fc8c4d8fa21ebe11c92f9429 : SUCCESS in 2h 24m 01s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/d34575d113264a68ab6f852d77c55a3a : SUCCESS in 2h 24m 17s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/f6acd868c8eb4162808cc0d03ac93701 : SUCCESS in 2h 02m 02s","accounts_in_message":[],"_revision_number":2},{"id":"603fb8bfd8baa615ec79c967e39ac9f32232eebd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 16:48:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"09c17d3d4353a2719dffda5c1fb73ede1979834e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 16:50:46.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b472a824a0a64f08bb530129a14e1079 : SUCCESS in 1m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb2a8818d8c327e22d060a33ca8f7350c7985b50","revisions":{"20ee80c850ff8370cf26f458acc40b7e3bd667f4":{"kind":"REWORK","_number":1,"created":"2019-11-06 21:18:59.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/55/693255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/55/693255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/1"}}},"commit":{"parents":[{"commit":"7cdbcf6e640ed47b8fefcaa66b3420f6d70893c3","subject":"Improve handling of empty resource_registry","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7cdbcf6e640ed47b8fefcaa66b3420f6d70893c3"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-10-08 01:41:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-06 21:14:39.000000000","tz":780},"subject":"Support undercloud fake-hardware ironic driver","message":"Support undercloud fake-hardware ironic driver\n\nWhen including fake-hardware in the undercloud.conf\nenabled_hardware_types, some of the fake-hardware default interfaces\nare not enabled so it can\u0027t be used.\n\nThis change allows nodes to be created with driver fake-hardware. If\nthis proves useful for development or some scale testing then it might\nbe desirable to add fake-hardware by default to the\nenabled_hardware_types list.\n\nChange-Id: I1a6b4df073b39924e6855ea865cfc856a1bdfe6b\n(cherry picked from commit 3657d1dc8deb77a097d591cc30bfed89292265fa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/20ee80c850ff8370cf26f458acc40b7e3bd667f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/20ee80c850ff8370cf26f458acc40b7e3bd667f4"}]},"branch":"refs/heads/stable/stein"},"fb2a8818d8c327e22d060a33ca8f7350c7985b50":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-11-06 21:33:23.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/55/693255/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/55/693255/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/55/693255/2"}}},"commit":{"parents":[{"commit":"7cdbcf6e640ed47b8fefcaa66b3420f6d70893c3","subject":"Improve handling of empty resource_registry","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7cdbcf6e640ed47b8fefcaa66b3420f6d70893c3"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-10-08 01:41:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-06 21:33:00.000000000","tz":780},"subject":"Support undercloud fake-hardware ironic driver","message":"Support undercloud fake-hardware ironic driver\n\nWhen including fake-hardware in the undercloud.conf\nenabled_hardware_types, some of the fake-hardware default interfaces\nare not enabled so it can\u0027t be used.\n\nThis change allows nodes to be created with driver fake-hardware. If\nthis proves useful for development or some scale testing then it might\nbe desirable to add fake-hardware by default to the\nenabled_hardware_types list.\n\nChange-Id: I1a6b4df073b39924e6855ea865cfc856a1bdfe6b\nCloses-Bug: 1851572\n(cherry picked from commit 3657d1dc8deb77a097d591cc30bfed89292265fa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fb2a8818d8c327e22d060a33ca8f7350c7985b50"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fb2a8818d8c327e22d060a33ca8f7350c7985b50"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}