)]}'
{"id":"openstack%2Fpython-tripleoclient~693257","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Frocky~I1a6b4df073b39924e6855ea865cfc856a1bdfe6b","project":"openstack/python-tripleoclient","branch":"stable/rocky","topic":"rockybug/1851572","hashtags":[],"change_id":"I1a6b4df073b39924e6855ea865cfc856a1bdfe6b","subject":"Support undercloud fake-hardware ironic driver","status":"MERGED","created":"2019-11-06 21:29:06.000000000","updated":"2019-11-13 17:29:18.000000000","submitted":"2019-11-13 17:29:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"693257-1573666158876-99007b45","meta_rev_id":"125c1ec9a74ce05de40f6ca393b25eb46b32c824","_number":693257,"virtual_id_number":693257,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-11-13 17:29:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-07 00:02:44.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-11-13 12:06:39.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2019-11-08 20:23:10.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2019-11-13 12:06:39.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-07 11:54:22.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-07 00:02:44.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-07 11:54:22.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-11-08 20:23:10.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2019-11-13 12:06:39.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-11-13 17:29:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ef6bd66a34d758600cf7f0d48ec1c78a763030a9","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-11-06 21:29:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eabf7b5be2c93d546c981858c55169d7734d7416","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-11-06 21:34:11.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d2cfb534761f17821ce263442cc3e9a905f01f26","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-11-07 00:02:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/57/693257/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/f5510d1/ : SUCCESS in 2h 27m 07s","accounts_in_message":[],"_revision_number":2},{"id":"3d6047219f0285c829d018b5c4b0880a014433e2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-07 00:46:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/cbf4714c0bec4bd4b8ac3271c898dbde : SUCCESS in 1h 10m 26s\n- tripleo-ci-centos-7-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/84fb16f397784c12938d289d8fbf371d : SUCCESS in 2h 53m 01s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/821e0cf11fa74a8eb99c02ca235cc71d : SUCCESS in 1h 35m 53s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/ac99d58a198e4c74b5b4c95814e426e8 : SUCCESS in 2h 22m 34s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/5264a9d5ad16491eb236a6d8dcdc62d1 : SUCCESS in 3h 07m 33s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/97b99f2487ca4e999b4186bab9b97fed : SUCCESS in 2h 35m 42s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/48ba60a6bc6d4b0a9aa1053fb0dba006 : SUCCESS in 3h 02m 21s (non-voting)\n- tripleo-ci-centos-7-standalone-rocky https://zuul.opendev.org/t/openstack/build/5f6c9d34aca048d1861cb5b445648a7c : SUCCESS in 1h 56m 44s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/fc4616cb63694bdc9dac66e5aa016b41 : SUCCESS in 24m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6792bc778a7d46d9b6ce0b10def7a7c6 : SUCCESS in 3m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d579bcb48b6d4a72ba71175c0751af04 : SUCCESS in 4m 39s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/50420f010de7430092e7d684d30b0db6 : SUCCESS in 3m 48s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/4404cf47814442ad981b4497ab947ff1 : FAILURE in 4m 27s (non-voting)\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/2908b661957d4798bd3611268d387b17 : SUCCESS in 3m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e938da0248394123bf27e40a6a237fa8 : SUCCESS in 5m 50s\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/c73127a41ace4664a3bbf99596d131ef : SUCCESS in 2h 40m 41s","accounts_in_message":[],"_revision_number":2},{"id":"45d656c8153a65e344b3a217c5bd4949533441f0","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2019-11-08 20:23:10.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"208c9ba02403a525295d16d78f824293baea906a","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-11-13 12:06:39.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a8c730a03977e8273df059ed8e63b99c4034c436","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 12:06:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"56d46781d392a1137220d8f7fc422eea6d45cdd4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 17:29:18.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/df49d8fbca6a4a03a067fc6acb2a3b83 : SUCCESS in 1h 28m 57s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/a293f67e5422410eb44b79e0cb370030 : SUCCESS in 2h 21m 35s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/1911ec14c6d245bf965bcce0e2662160 : SUCCESS in 3h 05m 34s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/ecbc890c54404d87a747de97540e5a07 : SUCCESS in 2h 53m 51s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/75ebbc84d0274579be315762ea07fb5c : SUCCESS in 26m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/73431a3e3a534a4fa5dfa8684735bb27 : SUCCESS in 5m 46s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/39f027ebb5ab41a1a7f09e9f975660e3 : SUCCESS in 5m 41s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/b591658a3dbc4df6a6955623835c8ad0 : SUCCESS in 5m 10s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5ff37b0f98874c2d8d9ca4ab210cfbc2 : SUCCESS in 6m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4bd38d51d35e41ffb2b2a9ac811a2f7f : SUCCESS in 8m 15s\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/ad01dee7f3f147938cf00d948c5408d6 : SUCCESS in 2h 24m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4cbe35d132d8f24a14a8a25d8eb85b3d599a91e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-13 17:29:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"155bf6d9384b5badd87434744b96e6a917b281ff","revisions":{"84fa79cfc1c7c9382a0aa5aea16d7fbb5d9438b6":{"kind":"REWORK","_number":1,"created":"2019-11-06 21:29:06.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/57/693257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/57/693257/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/1"}}},"commit":{"parents":[{"commit":"7ff0aeb40b7a167c0998e6b376bccb1bf14bf391","subject":"Improve handling of empty resource_registry","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7ff0aeb40b7a167c0998e6b376bccb1bf14bf391"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-10-08 01:41:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-06 21:28:48.000000000","tz":780},"subject":"Support undercloud fake-hardware ironic driver","message":"Support undercloud fake-hardware ironic driver\n\nWhen including fake-hardware in the undercloud.conf\nenabled_hardware_types, some of the fake-hardware default interfaces\nare not enabled so it can\u0027t be used.\n\nThis change allows nodes to be created with driver fake-hardware. If\nthis proves useful for development or some scale testing then it might\nbe desirable to add fake-hardware by default to the\nenabled_hardware_types list.\n\nChange-Id: I1a6b4df073b39924e6855ea865cfc856a1bdfe6b\n(cherry picked from commit 3657d1dc8deb77a097d591cc30bfed89292265fa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/84fa79cfc1c7c9382a0aa5aea16d7fbb5d9438b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/84fa79cfc1c7c9382a0aa5aea16d7fbb5d9438b6"}]},"branch":"refs/heads/stable/rocky"},"155bf6d9384b5badd87434744b96e6a917b281ff":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-11-06 21:34:11.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/57/693257/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/57/693257/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/57/693257/2"}}},"commit":{"parents":[{"commit":"7ff0aeb40b7a167c0998e6b376bccb1bf14bf391","subject":"Improve handling of empty resource_registry","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/7ff0aeb40b7a167c0998e6b376bccb1bf14bf391"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-10-08 01:41:55.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-06 21:33:37.000000000","tz":780},"subject":"Support undercloud fake-hardware ironic driver","message":"Support undercloud fake-hardware ironic driver\n\nWhen including fake-hardware in the undercloud.conf\nenabled_hardware_types, some of the fake-hardware default interfaces\nare not enabled so it can\u0027t be used.\n\nThis change allows nodes to be created with driver fake-hardware. If\nthis proves useful for development or some scale testing then it might\nbe desirable to add fake-hardware by default to the\nenabled_hardware_types list.\n\nChange-Id: I1a6b4df073b39924e6855ea865cfc856a1bdfe6b\nCloses-Bug: 1851572\n(cherry picked from commit 3657d1dc8deb77a097d591cc30bfed89292265fa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/155bf6d9384b5badd87434744b96e6a917b281ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/155bf6d9384b5badd87434744b96e6a917b281ff"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}