)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"094a8604802afd0ae826a0b7b6dd5b1add50193e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"For cell export add filter parameters to GlobalConfigExtraMapData"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of an additional cell we don\u0027t have redis, ovn_dbs parameters"},{"line_number":10,"context_line":"enabled_services because we don\u0027t run those services on the cell"},{"line_number":11,"context_line":"controllers. As a result redis/ovn_dbs_vips won\u0027t get added to"},{"line_number":12,"context_line":"hiera [1]."},{"line_number":13,"context_line":"Before the refactor in https://review.opendev.org/#/c/694115/ the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d1330c60","line":10,"updated":"2019-11-21 20:11:25.000000000","message":"but they will be in all_enabled_services, which would include redis and ovn, if those were deployed in the central stack. In which case the data does show up in the rendered hiera.\n\nEven in the link at [1], it shows it using all_enabled_services.","commit_id":"c205644029ba23e18f930fa28d6fe24cc7f8a62d"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"3b8a3ce997b72ccad1f87b95e2b4eb1bea6586b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"For cell export add filter parameters to GlobalConfigExtraMapData"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of an additional cell we don\u0027t have redis, ovn_dbs parameters"},{"line_number":10,"context_line":"enabled_services because we don\u0027t run those services on the cell"},{"line_number":11,"context_line":"controllers. As a result redis/ovn_dbs_vips won\u0027t get added to"},{"line_number":12,"context_line":"hiera [1]."},{"line_number":13,"context_line":"Before the refactor in https://review.opendev.org/#/c/694115/ the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_606b4bb8","line":10,"in_reply_to":"3fa7e38b_ca3020a1","updated":"2019-11-24 22:08:29.000000000","message":"\u003e ok, so we\u0027d need to export enabled_services from the central stack\n \u003e when we filter as well. because if we create a dedicated role file\n \u003e for the cell containing e.g. CellController + Compute we don\u0027t have\n \u003e the information of enabled_services from the central stack.\n\nwe can not export the enabled_services and add them to the input data or\njust add the Controller role to the cell stack. This would set services\nto be enabled, which are not located on the CellControllers, e.g. \"cinder_api_enabled\" set to true and this result in DB setup steps to run which we don\u0027t want to\nrun:\n\n  \"puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, Class[Cinder::Db::Mysql]: expects a value for parameter \u0027password\u0027 (file: /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql.pp, line: 215, column: 7) on node cell1-cellcontrol-0.ooo.test\", \n\nProbably best it to make sure that everything we pass in\nAllNodesExtraMapData gets added to the hiera even if the\nservice is not listed in enabled_services.\n\n \u003e \n \u003e also we\u0027d need a modification to [1] to include _nova_names\n \u003e information from all_nodes_extra_map_data.\n \u003e \n \u003e [1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-hieradata/templates/all_nodes.j2#L9-L11","commit_id":"c205644029ba23e18f930fa28d6fe24cc7f8a62d"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c845886b1eab015d7c8c676d1e963c2df51af60c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"For cell export add filter parameters to GlobalConfigExtraMapData"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of an additional cell we don\u0027t have redis, ovn_dbs parameters"},{"line_number":10,"context_line":"enabled_services because we don\u0027t run those services on the cell"},{"line_number":11,"context_line":"controllers. As a result redis/ovn_dbs_vips won\u0027t get added to"},{"line_number":12,"context_line":"hiera [1]."},{"line_number":13,"context_line":"Before the refactor in https://review.opendev.org/#/c/694115/ the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ca3020a1","line":10,"in_reply_to":"3fa7e38b_d1330c60","updated":"2019-11-23 18:31:47.000000000","message":"ok, so we\u0027d need to export enabled_services from the central stack when we filter as well. because if we create a dedicated role file for the cell containing e.g. CellController + Compute we don\u0027t have the information of enabled_services from the central stack.\n\nalso we\u0027d need a modification to [1] to include _nova_names information from all_nodes_extra_map_data.\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-hieradata/templates/all_nodes.j2#L9-L11","commit_id":"c205644029ba23e18f930fa28d6fe24cc7f8a62d"}],"tripleoclient/export.py":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"094a8604802afd0ae826a0b7b6dd5b1add50193e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        \"AllNodesConfig\": {"},{"line_number":75,"context_line":"            \"file\": \"group_vars/overcloud.json\","},{"line_number":76,"context_line":"            \"parameter\": \"GlobalConfigExtraMapData\","},{"line_number":77,"context_line":"            \"filter\": [\"oslo_messaging_notify_short_bootstrap_node_name\","},{"line_number":78,"context_line":"                       \"oslo_messaging_notify_node_names\","},{"line_number":79,"context_line":"                       \"oslo_messaging_rpc_node_names\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d181ccc3","line":76,"updated":"2019-11-21 20:11:25.000000000","message":"i noticed it was doing this in the original code, but it\u0027s wrong though. AllNodesConfig was never meant to get passed in through the GlobalConfigExtraMapData parameter.","commit_id":"c205644029ba23e18f930fa28d6fe24cc7f8a62d"}]}