)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"3b129f9d3ccf1d294aef140ebc7444d229449be5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # *Identifier will be update to timestamp value during the deploy"},{"line_number":74,"context_line":"        # workflow, but till then for all heat stack validations, we need"},{"line_number":75,"context_line":"        # and entry for starting the deploy action."},{"line_number":76,"context_line":"        if stack_is_new or args.skip_deploy_identifier:"},{"line_number":77,"context_line":"            parameters[\u0027DeployIdentifier\u0027] \u003d \u0027\u0027"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            parameters["},{"line_number":80,"context_line":"                \u0027DeployIdentifier\u0027] \u003d stack.parameters[\u0027DeployIdentifier\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        parameters[\u0027UpdateIdentifier\u0027] \u003d \u0027\u0027"},{"line_number":83,"context_line":"        parameters[\u0027StackAction\u0027] \u003d \u0027CREATE\u0027 if stack_is_new else \u0027UPDATE\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b4746537","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":74},"updated":"2020-03-05 03:31:40.000000000","message":"Possibly we don\u0027t need all this code here, now that we only depend on DeployIndentifier being some value or empty to decide whether to run deployments or not.\n\nJust for validations, I guess only below line would be enough as we override with a unique value in tripleo-common based on the skip-deploy-identifier flag.\n\nparameters[\u0027DeployIdentifier\u0027] \u003d \u0027\u0027","commit_id":"5685cd24afa6ae9940c2f30b549be881725efe9f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2556383205ef252ca66fae630c150a2c7f7913da","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # *Identifier will be update to timestamp value during the deploy"},{"line_number":74,"context_line":"        # workflow, but till then for all heat stack validations, we need"},{"line_number":75,"context_line":"        # and entry for starting the deploy action."},{"line_number":76,"context_line":"        if stack_is_new or args.skip_deploy_identifier:"},{"line_number":77,"context_line":"            parameters[\u0027DeployIdentifier\u0027] \u003d \u0027\u0027"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            parameters["},{"line_number":80,"context_line":"                \u0027DeployIdentifier\u0027] \u003d stack.parameters[\u0027DeployIdentifier\u0027]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        parameters[\u0027UpdateIdentifier\u0027] \u003d \u0027\u0027"},{"line_number":83,"context_line":"        parameters[\u0027StackAction\u0027] \u003d \u0027CREATE\u0027 if stack_is_new else \u0027UPDATE\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f2a188f9","line":80,"range":{"start_line":76,"start_character":0,"end_line":80,"end_character":74},"in_reply_to":"1fa4df85_b4746537","updated":"2020-03-05 13:31:44.000000000","message":"ok I\u0027ll first verify that https://review.opendev.org/#/c/711454 works fine in our QE then i\u0027ll clean that up.","commit_id":"5685cd24afa6ae9940c2f30b549be881725efe9f"}]}