)]}'
{"tripleoclient/constants.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0fa3b03671d88df6c5a39d857aa76e3c6b364053","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    if os.path.exists(UNDERCLOUD_CONF_PATH):"},{"line_number":162,"context_line":"        config \u003d cfgp.ConfigParser()"},{"line_number":163,"context_line":"        config.read(UNDERCLOUD_CONF_PATH)"},{"line_number":164,"context_line":"        UNDERCLOUD_OUTPUT_DIR \u003d config.get(\u0027DEFAULT\u0027, \u0027output_dir\u0027)"},{"line_number":165,"context_line":"    else:"},{"line_number":166,"context_line":"        raise FileNotFoundError"},{"line_number":167,"context_line":"except (cfgp.NoOptionError, FileNotFoundError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9a4ad852","line":164,"updated":"2020-03-24 13:37:49.000000000","message":"I\u0027m not sure parsing config is a proper place for constants? Instead, that\u0027s config parsing code elsewhere should fall back to constants if values are not set","commit_id":"d38c7c329f16e1b9fcc415843639a6b8f4a19f06"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0d155043db023b2d6135021fcde6cb453051c5ec","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    if os.path.exists(UNDERCLOUD_CONF_PATH):"},{"line_number":162,"context_line":"        config \u003d cfgp.ConfigParser()"},{"line_number":163,"context_line":"        config.read(UNDERCLOUD_CONF_PATH)"},{"line_number":164,"context_line":"        UNDERCLOUD_OUTPUT_DIR \u003d config.get(\u0027DEFAULT\u0027, \u0027output_dir\u0027)"},{"line_number":165,"context_line":"    else:"},{"line_number":166,"context_line":"        raise FileNotFoundError"},{"line_number":167,"context_line":"except (cfgp.NoOptionError, FileNotFoundError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b0cb7d1c","line":164,"in_reply_to":"df33271e_9a4ad852","updated":"2020-03-24 15:38:14.000000000","message":"Doing this in reverse would likely mean building a method and calling it in all places that UNDERCLOUD_OUTPUT_DIR is used (which is 4 different places at this time). I guess we could do this in utils if we think it best, however, that would be a larger change.","commit_id":"d38c7c329f16e1b9fcc415843639a6b8f4a19f06"}]}