)]}'
{"id":"openstack%2Fpython-tripleoclient~717429","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Ftrain~I8c26aa68ec2668fb9c94d0191914bd676e082ebe","project":"openstack/python-tripleoclient","branch":"stable/train","topic":"container_images_files-stable/train","hashtags":[],"change_id":"I8c26aa68ec2668fb9c94d0191914bd676e082ebe","subject":"Improve container_images_file comments","status":"MERGED","created":"2020-04-04 03:46:02.000000000","updated":"2020-04-04 21:04:59.000000000","submitted":"2020-04-04 21:03:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"717429-1586034225263-3be6ea2c","meta_rev_id":"e0e7478acada6709cfcb6cbf95111896fc7a4d0b","_number":717429,"virtual_id_number":717429,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-04 21:03:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-04-04 05:12:48.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-04 17:20:55.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-04 17:20:55.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-04 05:12:48.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-04 17:20:55.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-04-04 21:03:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8048d17695376cee39c49e1b003ee30c8bd311c2","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-04 03:46:02.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"520fca02dfce7c612b4c997a543d938002fd5c5e","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-04 03:46:20.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit b8381ced8438dd10010240a21ce086f719e322eb","accounts_in_message":[],"_revision_number":1},{"id":"086346243c207166637db0f8e13fdb889a59e667","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-04-04 05:12:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-rhel-8-buildimage-overcloud-full-train https://review.rdoproject.org/zuul/build/806851b5ae3145a9b4a9e55448d9da60 : SUCCESS in 18m 44s\n- tripleo-rhel-8-buildimage-ironic-python-agent-train https://review.rdoproject.org/zuul/build/f8e3661c0ca344968429168b0f4c08f7 : SUCCESS in 15m 37s (non-voting)\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/e88c5876025642aeb48d46bbd91db09e : FAILURE in 1h 26m 02s","accounts_in_message":[],"_revision_number":1},{"id":"da7ad808db09833d0e02b7c1678f6f9498d80f74","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 06:59:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f938b4771d2047bdb75c367d40b25612 : SUCCESS in 4m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b20dc2c44c994620a0d63f9ffd86e574 : SUCCESS in 3m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/58c6f37ae5dc441a96ec924e4512f459 : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/508e262eff4d4a60a248571296c953d6 : SUCCESS in 5m 04s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/0479eb7f98404f9e8b7d39c4d508a8c6 : SUCCESS in 26m 10s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/77a695aa0b6a472f852d25d47fc34fdb : SUCCESS in 1h 52m 47s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/5dabcbace23d44f29b0c786abad02a68 : SUCCESS in 2h 57m 33s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/b1845fbd5bdb4ab6954b75b1e23f5f5a : SUCCESS in 2h 16m 54s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/e8dc45f0661840fa83aa03fde76c1b6b : SUCCESS in 2h 25m 39s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/4e6cbf1ad5644fdaa28e00b0d4415d46 : SUCCESS in 1h 37m 53s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/31f0ef4dd8274035815b54003364e60c : SUCCESS in 2h 07m 41s (non-voting)\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/d751f320a7e04effb47bf4621e2acc0c : SUCCESS in 3h 04m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f90822ef6f1a411484c6046120ee9665 : SUCCESS in 3m 41s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0a0114da4b354f03b481df7f2b2190d9 : SUCCESS in 3m 52s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/8ebbbc7f4d554eb681a3d0f03b248310 : SUCCESS in 2h 32m 08s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/cd3cc2a2f10c42af9695babf4f62ac67 : FAILURE in 1h 21m 15s (non-voting)\n\nWarning:\n  Job openstack-tox-py36: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py36/lib/python3.6/site-packages/mock/mock.py in the commit\u0027\n  Job openstack-tox-py36: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py36/lib/python3.6/site-packages/stestr/subunit_runner/program.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/stestr/subunit_runner/program.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/testtools/run.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/mock/mock.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py in the commit\u0027\n  Comments left for invalid file tripleoclient/tests/test_utils.py\n  Comments left for invalid file tripleoclient/workflows/plan_management.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py\n  Comments left for invalid file tripleoclient/export.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/stestr/subunit_runner/program.py\n  Comments left for invalid file tripleoclient/tests/v1/test_overcloud_parameters.py\n  Comments left for invalid file .tox/py36/lib/python3.6/site-packages/stestr/subunit_runner/program.py\n  Comments left for invalid file .tox/py36/lib/python3.6/site-packages/mock/mock.py\n  Comments left for invalid file tripleoclient/utils.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/testtools/run.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/mock/mock.py","accounts_in_message":[],"_revision_number":1},{"id":"c6e0ffc22debae490e8653361b99c3d47dee2e2b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-04-04 17:20:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"01f5c329eb105b10b24b6f4f55eb06e912fce354","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 17:21:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"630999a30aa99cfb6ff949804d3f7ea047253cbd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 21:03:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cb375e31b91440e593aac5b102e2cc47 : SUCCESS in 10m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c48f119e32d5457884be9aade26f21e9 : SUCCESS in 4m 11s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/49a8f83a9db14260a5f5bc303bdc8c11 : SUCCESS in 10m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ea17a27fda0248c3bf2f4526baa5d39b : SUCCESS in 10m 03s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/7e33c07f908a457b84a23d60581f6d51 : SUCCESS in 28m 06s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/58f5735264f240b3bed35b1ce4091de0 : SUCCESS in 2h 49m 37s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/8532ef4df8e54e75b8b5de6b82e1e7fe : SUCCESS in 1h 46m 56s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/4941b88ac14e4973b28b06f2c908c81d : SUCCESS in 2h 11m 41s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/52d1f607948644a19c7e72a00ff32cc4 : SUCCESS in 2h 13m 08s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/28882655034c410ea8077383927f415e : SUCCESS in 2h 08m 58s\n- tripleo-ci-centos-7-containers-undercloud-minion https://zuul.opendev.org/t/openstack/build/ece481767d744aaa8c739f032db90f6c : SUCCESS in 1h 48m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af4198956a1d4389baf185254d8d7e6d : SUCCESS in 3m 38s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/b8f6ba6f2e274d549d2789c1310b65bc : SUCCESS in 3h 00m 16s\n\nWarning:\n  Comments left for invalid file tripleoclient/tests/test_utils.py\n  Comments left for invalid file tripleoclient/workflows/plan_management.py\n  Comments left for invalid file tripleoclient/export.py\n  Comments left for invalid file tripleoclient/utils.py\n  Comments left for invalid file tripleoclient/tests/v1/test_overcloud_parameters.py","accounts_in_message":[],"_revision_number":1},{"id":"06d13f63d2715fd4a68026a47952420a3577c0fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 21:03:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"e0cf496f2ad1bb94420a6a96e5f2dc7915978183","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 21:04:59.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dddf8f45f6f54f96ac77de163314af2b : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fdce01fce2164ee3219fd6df0ee7089f9b8207a3","revisions":{"fdce01fce2164ee3219fd6df0ee7089f9b8207a3":{"kind":"REWORK","_number":1,"created":"2020-04-04 03:46:02.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/29/717429/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/29/717429/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/29/717429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/29/717429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/29/717429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/29/717429/1"}}},"commit":{"parents":[{"commit":"9a5892eb3e335fcd65300166e4a300a9ed16380a","subject":"Merge \"Normalize the \u0027undercloud-passwords.conf\u0027 return data\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/9a5892eb3e335fcd65300166e4a300a9ed16380a"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2020-03-31 21:36:56.000000000","tz":-360},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2020-04-04 03:46:02.000000000","tz":0},"subject":"Improve container_images_file comments","message":"Improve container_images_file comments\n\nDownstream we see that folks repeatedly forget to set this variable even\nthough they may generate a containers yaml file. This ultimately leads\nto an undercloud installation failure due to lack of credentials. This\nchange updates the configuration item to be required\u003dFalse for upstream\n(because it\u0027s not) but includes additional comments around what this\nfile does. We can flip the configuration to required in environments\nwhere we know we need authentication.\n\nChange-Id: I8c26aa68ec2668fb9c94d0191914bd676e082ebe\n(cherry picked from commit 24b87f1997fff08f610e685b4f5856de4e74dbec)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fdce01fce2164ee3219fd6df0ee7089f9b8207a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/fdce01fce2164ee3219fd6df0ee7089f9b8207a3"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}