)]}'
{"id":"openstack%2Fpython-tripleoclient~717430","triplet_id":"openstack%2Fpython-tripleoclient~stable%2Fstein~I8c26aa68ec2668fb9c94d0191914bd676e082ebe","project":"openstack/python-tripleoclient","branch":"stable/stein","topic":"container_images_files-stable/train-stable/stein","hashtags":[],"change_id":"I8c26aa68ec2668fb9c94d0191914bd676e082ebe","subject":"Improve container_images_file comments","status":"MERGED","created":"2020-04-04 03:46:20.000000000","updated":"2020-04-06 21:14:00.000000000","submitted":"2020-04-06 21:12:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"717430-1586207536291-28344ecc","meta_rev_id":"41f56579a4e4ab488452b86610fdaaa47fc4304a","_number":717430,"virtual_id_number":717430,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-06 21:12:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-04-04 05:16:22.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-06 13:32:01.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-06 13:32:01.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-04 05:16:22.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-06 13:32:01.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-04-06 21:12:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2a0f96307ac15a770e7bc6d29f9727418de03b04","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-04 03:46:20.000000000","message":"Patch Set 1: Cherry Picked from branch stable/train.","accounts_in_message":[],"_revision_number":1},{"id":"1be032d3d98de8c9a0a6aaab8678e3f1853a8c8b","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-04-04 05:16:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/97b7ebda28b84440865f3da564ab0af4 : FAILURE in 1h 28m 23s","accounts_in_message":[],"_revision_number":1},{"id":"fad8fe7faf5a255bb70e9b57110f3cd3b6f37e1d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-04 09:07:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f55f2250d38640d684fa3b535783d07a : SUCCESS in 5m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3b8952ee62d14a21b2ed05b3c08cdf11 : SUCCESS in 3m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/98620a0e59f84f909ec82a7667d5288e : SUCCESS in 4m 25s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a8a2081f417a4d3e8b1efc259bff280d : SUCCESS in 4m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1454468c70fd4740b703b480bc7bb032 : SUCCESS in 3m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2e88c19d406541aa82c29a000a568d72 : SUCCESS in 4m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39625100c5a243edb23543078b802c80 : SUCCESS in 4m 18s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/661141aa7565447e84d37176a527347e : SUCCESS in 22m 45s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/074a8d0740834e05a944ee1e58d255be : SUCCESS in 1h 47m 46s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/2a9d2d889b8244379f75367772467563 : SUCCESS in 2h 32m 59s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/1a4c5a850336419b8770f77fc17a9283 : SUCCESS in 1h 54m 43s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/5ee429f8d4bc48bc8c9e0811c1fe1e7f : SUCCESS in 2h 29m 38s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/9eff6452f6b647568a7a1b4313c8d255 : SUCCESS in 1h 52m 56s\n- tripleo-ci-centos-7-standalone-upgrade-stein https://zuul.opendev.org/t/openstack/build/2d3e1675145a4ef1b92d3013247eca2c : SUCCESS in 2h 26m 21s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/052210bd99c74c51b916feada356ca89 : FAILURE in 1h 24m 42s (non-voting)\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/b7ed7f98fed241f3a17d558873f80736 : SUCCESS in 2h 33m 01s (non-voting)\n- tripleo-ci-centos-7-scenario009-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/371a2cbbc66a4dd3983c9d1d327dc199 : FAILURE in 1h 46m 04s (non-voting)\n\nWarning:\n  Job openstack-tox-py36: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py36/lib/python3.6/site-packages/openstack/_meta/connection.py in the commit\u0027\n  Job openstack-tox-py36: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py36/lib/python3.6/site-packages/mock/mock.py in the commit\u0027\n  Job openstack-tox-py36: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py36/lib/python3.6/site-packages/testtools/run.py in the commit\u0027\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/docs/lib/python3.6/site-packages/docutils/io.py in the commit\u0027\n  Job openstack-tox-py35: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py35/lib/python3.5/site-packages/testtools/run.py in the commit\u0027\n  Job openstack-tox-py35: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py35/lib/python3.5/site-packages/openstack/_meta/connection.py in the commit\u0027\n  Job openstack-tox-py27: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py27/lib/python2.7/site-packages/openstack/_meta/connection.py in the commit\u0027\n  Job openstack-tox-py27: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py27/lib/python2.7/site-packages/openstackclient/shell.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/yaml/constructor.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/testtools/run.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/mock/mock.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/jsonschema/compat.py in the commit\u0027\n  Job openstack-tox-py37: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/py37/lib/python3.7/site-packages/openstack/_meta/connection.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/os_service_types/data/__init__.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/openstack/_meta.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/testtools/run.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/subunit/test_results.py in the commit\u0027\n  Job openstack-tox-lower-constraints: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py in the commit\u0027\n  Comments left for invalid file .tox/py35/lib/python3.5/site-packages/openstack/_meta/connection.py\n  Comments left for invalid file .tox/py27/lib/python2.7/site-packages/openstackclient/shell.py\n  Comments left for invalid file .tox/py36/lib/python3.6/site-packages/mock/mock.py\n  Comments left for invalid file tripleoclient/tests/v1/test_overcloud_parameters.py\n  Comments left for invalid file .tox/py27/lib/python2.7/site-packages/openstack/_meta/connection.py\n  Comments left for invalid file tripleoclient/workflows/plan_management.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/jsonschema/compat.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/mock/mock.py\n  Comments left for invalid file .tox/py36/lib/python3.6/site-packages/testtools/run.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/setuptools/dist.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/testtools/run.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/yaml/constructor.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/os_service_types/data/__init__.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/testtools/run.py\n  Comments left for invalid file tripleoclient/tests/test_utils.py\n  Comments left for invalid file .tox/py37/lib/python3.7/site-packages/openstack/_meta/connection.py\n  Comments left for invalid file .tox/py36/lib/python3.6/site-packages/openstack/_meta/connection.py\n  Comments left for invalid file .tox/py35/lib/python3.5/site-packages/testtools/run.py\n  Comments left for invalid file tripleoclient/v1/overcloud_execute.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/openstack/_meta.py\n  Comments left for invalid file .tox/lower-constraints/lib/python3.6/site-packages/subunit/test_results.py\n  Comments left for invalid file .tox/docs/lib/python3.6/site-packages/docutils/io.py","accounts_in_message":[],"_revision_number":1},{"id":"de57a923ead6cfae9ec545ff54dc4a9af97aece8","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-04-06 13:32:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c170296cb3c666a921aa9f005a1522d8fdb2416f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-06 13:32:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0b5120ea6f344b775dac17c2d078896d3f14a007","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-06 21:12:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e68ac307c6694ba9a5181b141b880033 : SUCCESS in 6m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/105d6fd348614e0a8a6dc23037208e6c : SUCCESS in 4m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c203f2fc80964b80819f883403a3ab89 : SUCCESS in 5m 43s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/88f697aec4e94cf483d00229c04625e4 : SUCCESS in 6m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f65c5d7b61854186a2f5cd3b2f140029 : SUCCESS in 5m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3b5d38729cb942d4b9e7cd086c97f60f : SUCCESS in 6m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a6dd728bd724c15ac42399427ce0a1a : SUCCESS in 6m 10s\n- tripleo-buildimage-overcloud-full-centos-7 https://zuul.opendev.org/t/openstack/build/a2fa24073cea42599a13377d845d5501 : SUCCESS in 32m 12s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/e84cb08bd8df4ae1bf8d925f274e5b4e : SUCCESS in 3h 38m 26s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/580eec84a634462c9150c494d1e521a6 : SUCCESS in 1h 50m 37s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/822430d749cb492a915099ff68bfea90 : SUCCESS in 1h 58m 35s\n- tripleo-ci-centos-7-standalone-upgrade-stein https://zuul.opendev.org/t/openstack/build/414274f4c3104618a2cb57d6918b0532 : SUCCESS in 2h 10m 51s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/520d4a45f0624e6d8d1931a5fc3b722a : SUCCESS in 1h 31m 37s\n\nWarning:\n  Comments left for invalid file tripleoclient/tests/test_utils.py\n  Comments left for invalid file tripleoclient/workflows/plan_management.py\n  Comments left for invalid file tripleoclient/v1/overcloud_execute.py\n  Comments left for invalid file tripleoclient/tests/v1/test_overcloud_parameters.py","accounts_in_message":[],"_revision_number":1},{"id":"98db4e4ca3cdcf43eace5a879be5b3f5cf9811b4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-06 21:12:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"716bb5c8b4715fc5fe81edfaa8dd5f3845cd0d70","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-06 21:14:00.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/872d1fd1fb174ad5b434f58d18f2ea4f : SUCCESS in 1m 23s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b8381ced8438dd10010240a21ce086f719e322eb","revisions":{"b8381ced8438dd10010240a21ce086f719e322eb":{"kind":"REWORK","_number":1,"created":"2020-04-04 03:46:20.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/30/717430/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-tripleoclient","ref":"refs/changes/30/717430/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/30/717430/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/30/717430/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-tripleoclient refs/changes/30/717430/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-tripleoclient refs/changes/30/717430/1"}}},"commit":{"parents":[{"commit":"203ba29b6af1e8d2d6d47e48d98cb8338c48c45f","subject":"overcloud: set DeployIdentifier to \u0027\u0027 if --skip-deploy-identifier is used","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/203ba29b6af1e8d2d6d47e48d98cb8338c48c45f"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2020-03-31 21:36:56.000000000","tz":-360},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2020-04-04 03:46:20.000000000","tz":0},"subject":"Improve container_images_file comments","message":"Improve container_images_file comments\n\nDownstream we see that folks repeatedly forget to set this variable even\nthough they may generate a containers yaml file. This ultimately leads\nto an undercloud installation failure due to lack of credentials. This\nchange updates the configuration item to be required\u003dFalse for upstream\n(because it\u0027s not) but includes additional comments around what this\nfile does. We can flip the configuration to required in environments\nwhere we know we need authentication.\n\nChange-Id: I8c26aa68ec2668fb9c94d0191914bd676e082ebe\n(cherry picked from commit 24b87f1997fff08f610e685b4f5856de4e74dbec)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/b8381ced8438dd10010240a21ce086f719e322eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-tripleoclient/commit/b8381ced8438dd10010240a21ce086f719e322eb"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}