)]}'
{"tripleoclient/utils.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6d45f8df8b57082858ae8a1e30030a948769037b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e243ad3d","line":237,"updated":"2020-05-01 14:31:03.000000000","message":"So i think this is wrong and we need to fix the spot where heat is used. Heat has a different verbosity level than ansible. This turns on ansible verbosity by default (which is a bit much)","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ac83e97818e1586c6008d21b4e593f07e05732be","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_05efc3e8","line":237,"in_reply_to":"1f493fa4_056223d8","updated":"2020-05-01 15:18:01.000000000","message":"Then we should not link osc verbose_level with ansible verbosity at all if we need translation. I mentioned about that (in a comment) when I proposed the patch","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6950eb2e7f8a2f487f62827e75041f19f1110afc","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_65acc79e","line":237,"in_reply_to":"1f493fa4_05efc3e8","updated":"2020-05-01 15:20:12.000000000","message":"We need a way to enable verbosity. verbose_level comes from --debug --verbose etc on the cli params. If someone runs --debug we get a higher verbose_level and would turn on ansible debug with cli debug. This is the correct place to do it. it\u0027s just osclient has always had 1 by default for some reason rather than being 0 if no --verbose or --debug is provided (no idea the history on this). This is about the 3rd or 4th time i\u0027ve had to address this exact thing.","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9bbbdcb3ea8369d4befc2b5ed03d7568db740ec","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_056223d8","line":237,"in_reply_to":"1f493fa4_2267554f","updated":"2020-05-01 15:11:35.000000000","message":"apt_args.verbose_level is 1 by default. so we end up turning it on. The issue is the translation from osclient verbose level to something usable by everyone else. Ansible itself needs to not be verbose by default. We always want to print the heat stack events.","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"476ec7632b13689644176f895f12eb7cc5aac086","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_2267554f","line":237,"in_reply_to":"1f493fa4_e243ad3d","updated":"2020-05-01 14:57:21.000000000","message":"I don\u0027t see anything wrong with heatclient verbosity as we use the client verbosity \u003e 0 to log the events.\n\nAre we saying we\u0027ll use client verbosity(verbose_level) when it\u0027s \u003e 1 (L240) as ansible verbosity, but override it to 0 when it\u0027s 1(default). This seems unintuitive to me.","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0c718f6b397bd045bcaf6cebb930658720913237","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    if self.app.options.debug:"},{"line_number":235,"context_line":"        return 3"},{"line_number":236,"context_line":"    else:"},{"line_number":237,"context_line":"        if self.app_args.verbose_level \u003c 1:"},{"line_number":238,"context_line":"            return 0"},{"line_number":239,"context_line":"        else:"},{"line_number":240,"context_line":"            return self.app_args.verbose_level"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_826e29c6","line":237,"in_reply_to":"1f493fa4_e243ad3d","updated":"2020-05-01 14:31:56.000000000","message":"specifically the heat client verbosity","commit_id":"c8cd7145884419a8da922d679f5d3e371c84bffa"}]}
