)]}'
{"tripleoclient/v1/undercloud.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c9bad3ab4709a34e1d4d31d925fcce16de4c0432","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            return"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        pkg_manager \u003d \u0027yum\u0027"},{"line_number":187,"context_line":"        if sys.version_info.major \u003e\u003d 3:"},{"line_number":188,"context_line":"            pkg_manager \u003d \u0027dnf\u0027"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        cmd \u003d [\u0027sudo\u0027, pkg_manager, \u0027upgrade\u0027, \u0027-y\u0027] + packages"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a6711d47","line":187,"updated":"2020-07-10 08:16:05.000000000","message":"Though it solves with the assumption that all centos8 will have python3, it would be better if the check is associated with the required command. If \"dnf\" command exists, then use it, else, fall back to yum, which can remove the assumption.","commit_id":"d6a368903eb793a1a0324281c112108c68ed96f9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7dcacd07b3bec9d5fde53ca89818869f8841c74f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            return"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        pkg_manager \u003d \u0027yum\u0027"},{"line_number":187,"context_line":"        if sys.version_info.major \u003e\u003d 3:"},{"line_number":188,"context_line":"            pkg_manager \u003d \u0027dnf\u0027"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        cmd \u003d [\u0027sudo\u0027, pkg_manager, \u0027upgrade\u0027, \u0027-y\u0027] + packages"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_f0c8d255","line":187,"in_reply_to":"bf51134e_a6711d47","updated":"2020-07-13 11:33:20.000000000","message":"o/ thanks for your review.\n\nit\u0027s a fair comment about using dnf but the assumption you noted is wrong... the check is \u003e\u003d 3 not \u003d\u003d 3... \n\nso the assumption is then that all centos8 with python \u003e\u003d3 (covers e.g. python 4 when it comes :D) will have *dnf*.\n\nPerhaps that is not a safe assumption cos dnf might indeed be replaced. But by what? So we can\u0027t assume anything about the replacement which doesn\u0027t exist.\n\nI\u0027ve played with it a bit now and added some logic about yum/dnf being installed - let\u0027s see what folks think about it. I\u0027m not convinced it\u0027s better but let me know if it addresses your concern.\n\nthanks","commit_id":"d6a368903eb793a1a0324281c112108c68ed96f9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b832b9630849c14c4b0894b15f0f22a1286554f0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        if not packages:"},{"line_number":184,"context_line":"            return"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        pkg_manager \u003d \u0027yum\u0027 if os.system(\u0027yum --version\u0027) \u003d\u003d 0 else \u0027nope\u0027"},{"line_number":187,"context_line":"        if sys.version_info.major \u003e\u003d 3 and os.system(\u0027dnf --version\u0027) \u003d\u003d 0:"},{"line_number":188,"context_line":"            pkg_manager \u003d \u0027dnf\u0027"},{"line_number":189,"context_line":"        if pkg_manager \u003d\u003d \u0027nope\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_9a3d22c6","line":186,"range":{"start_line":186,"start_character":27,"end_line":186,"end_character":74},"updated":"2020-07-14 07:24:22.000000000","message":"@Alex are you objecting to this bit? I can remove it but does it hurt to confirm we have yum available?\n\nWe can just assume we *do* have yum and keep the dnf check below.","commit_id":"a034e6cf56c02fe9d8737af2ae7fff4afaa87a9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7711940cd409a278eb09af194d8cc523f0ae14cd","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            return"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        pkg_manager \u003d \u0027yum\u0027"},{"line_number":187,"context_line":"        if sys.version_info.major \u003e\u003d 3 and os.system(\u0027which dnf\u0027) \u003d\u003d 0:"},{"line_number":188,"context_line":"            pkg_manager \u003d \u0027dnf\u0027"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        cmd \u003d [\u0027sudo\u0027, pkg_manager, \u0027upgrade\u0027, \u0027-y\u0027] + packages"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_1333a963","line":187,"range":{"start_line":187,"start_character":45,"end_line":187,"end_character":58},"updated":"2020-07-15 10:47:58.000000000","message":"ok the tests are passing locally but failing here\n\ni will also try mocking os.system let\u0027s see if it likes it better.","commit_id":"367cc497bc238afcf8c8f4efc05bba8e63af5e7e"}]}