)]}'
{"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5c6bc3025384564c812256077ad64c9b5660da03","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class _CommaListGroupAction(argparse.Action):"},{"line_number":45,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":46,"context_line":"        opts \u003d v_utils.get_validation_group_name_list(GROUP_FILE)"},{"line_number":47,"context_line":"        for value in values.split(\u0027,\u0027):"},{"line_number":48,"context_line":"            if value not in opts:"},{"line_number":49,"context_line":"                message \u003d (\"Invalid choice: {value} (choose from {choice})\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b7545fff","line":46,"updated":"2020-08-26 17:55:47.000000000","message":"pep8: F821 undefined name \u0027GROUP_FILE\u0027","commit_id":"dafc0b2e2c386e51ccd2cabade184f21c1dd5a32"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5c6bc3025384564c812256077ad64c9b5660da03","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        setattr(namespace, self.dest, values.split(\u0027,\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class TripleOValidatorGroupInfo(command.Lister):"},{"line_number":62,"context_line":"    \"\"\"Display Information about Validation Groups\"\"\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_97579b01","line":61,"updated":"2020-08-26 17:55:47.000000000","message":"pep8: F821 undefined name \u0027GROUP_FILE\u0027","commit_id":"dafc0b2e2c386e51ccd2cabade184f21c1dd5a32"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5c6bc3025384564c812256077ad64c9b5660da03","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":330,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        python_interpreter \u003d \\"},{"line_number":333,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f741b73a","line":332,"updated":"2020-08-26 17:55:47.000000000","message":"pep8: F841 local variable \u0027python_interpreter\u0027 is assigned to but never used","commit_id":"dafc0b2e2c386e51ccd2cabade184f21c1dd5a32"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5c6bc3025384564c812256077ad64c9b5660da03","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        python_interpreter \u003d \\"},{"line_number":333,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":336,"context_line":"            ssh_user\u003d\u0027heat-admin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d73c73c0","line":333,"updated":"2020-08-26 17:55:47.000000000","message":"pep8: F821 undefined name \u0027sys\u0027","commit_id":"dafc0b2e2c386e51ccd2cabade184f21c1dd5a32"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"747a38cdfb91d8879c6a40ad1d3b0a9b78a3a36c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class _CommaListGroupAction(argparse.Action):"},{"line_number":45,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":46,"context_line":"        opts \u003d v_utils.get_validation_group_name_list(GROUP_FILE)"},{"line_number":47,"context_line":"        for value in values.split(\u0027,\u0027):"},{"line_number":48,"context_line":"            if value not in opts:"},{"line_number":49,"context_line":"                message \u003d (\"Invalid choice: {value} (choose from {choice})\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fe134c5a","line":46,"updated":"2020-08-26 23:16:12.000000000","message":"pep8: F821 undefined name \u0027GROUP_FILE\u0027","commit_id":"976097e500add673143ff38e36dc10ef2d95517f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"747a38cdfb91d8879c6a40ad1d3b0a9b78a3a36c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        setattr(namespace, self.dest, values.split(\u0027,\u0027))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class TripleOValidatorGroupInfo(command.Lister):"},{"line_number":62,"context_line":"    \"\"\"Display Information about Validation Groups\"\"\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_de0e4830","line":61,"updated":"2020-08-26 23:16:12.000000000","message":"pep8: F821 undefined name \u0027GROUP_FILE\u0027","commit_id":"976097e500add673143ff38e36dc10ef2d95517f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"747a38cdfb91d8879c6a40ad1d3b0a9b78a3a36c","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":330,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        python_interpreter \u003d \\"},{"line_number":333,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3e1ae46d","line":332,"updated":"2020-08-26 23:16:12.000000000","message":"pep8: F841 local variable \u0027python_interpreter\u0027 is assigned to but never used","commit_id":"976097e500add673143ff38e36dc10ef2d95517f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"747a38cdfb91d8879c6a40ad1d3b0a9b78a3a36c","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        python_interpreter \u003d \\"},{"line_number":333,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":336,"context_line":"            ssh_user\u003d\u0027heat-admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1e15603d","line":333,"updated":"2020-08-26 23:16:12.000000000","message":"pep8: F821 undefined name \u0027sys\u0027","commit_id":"976097e500add673143ff38e36dc10ef2d95517f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0e0beef943ea805e51f1afb801eb221fd55c873a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":332,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        python_interpreter \u003d \\"},{"line_number":335,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6c7031a5","line":334,"updated":"2020-08-27 10:27:56.000000000","message":"pep8: F841 local variable \u0027python_interpreter\u0027 is assigned to but never used","commit_id":"dc43fe481329477f0e451d342c2447a3e9029ba2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0e0beef943ea805e51f1afb801eb221fd55c873a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        python_interpreter \u003d \\"},{"line_number":335,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("},{"line_number":338,"context_line":"            ssh_user\u003d\u0027heat-admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cc6a1db1","line":335,"updated":"2020-08-27 10:27:56.000000000","message":"pep8: F821 undefined name \u0027sys\u0027","commit_id":"dc43fe481329477f0e451d342c2447a3e9029ba2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b54f8d5e78f4c1645fb35fc2b53d2ac14042a484","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":333,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        python_interpreter \u003d \\"},{"line_number":336,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ab4e4fbf","line":335,"updated":"2020-09-02 20:47:01.000000000","message":"pep8: F841 local variable \u0027python_interpreter\u0027 is assigned to but never used","commit_id":"0f6df65ad01f550f957d64ebe6a5936f04a74183"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a764eaee22ab4163d442fbc1f091e68a67761193","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":333,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        python_interpreter \u003d \\"},{"line_number":336,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f58ebd76","line":335,"updated":"2020-08-27 17:31:04.000000000","message":"pep8: F841 local variable \u0027python_interpreter\u0027 is assigned to but never used","commit_id":"0f6df65ad01f550f957d64ebe6a5936f04a74183"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"392bfcb6747aa00035bd233ebefa1e603a2ef14d","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        limit \u003d parsed_args.limit"},{"line_number":333,"context_line":"        playbook \u003d parsed_args.playbook"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        python_interpreter \u003d \\"},{"line_number":336,"context_line":"            \"/usr/bin/python{}\".format(sys.version_info[0])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        static_inventory \u003d oooutils.get_tripleo_ansible_inventory("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_93157d4c","line":335,"in_reply_to":"9f560f44_ab4e4fbf","updated":"2020-09-03 06:09:04.000000000","message":"We probably can avoid passing it, especially in the following case:\nundercloud on rhel-8\novercloud on rhel-7\nThis case can happen when doing FFU - there\u0027s a Red Hat doc advising to run validations before upgrading the overcloud..","commit_id":"0f6df65ad01f550f957d64ebe6a5936f04a74183"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"5a1fb22a17574761e64a97c2909c27076f2371cd","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def take_action(self, parsed_args):"},{"line_number":194,"context_line":"        LOG.debug(_(\u0027Launch listing the validations\u0027))"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            v_consts.DEFAULT_VALIDATIONS_BASEDIR \u003d constants.\\"},{"line_number":197,"context_line":"                DEFAULT_VALIDATIONS_BASEDIR"},{"line_number":198,"context_line":"            actions \u003d ValidationActions(constants.ANSIBLE_VALIDATION_DIR,"},{"line_number":199,"context_line":"                                        parsed_args.group)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_d60347bd","line":196,"updated":"2020-09-04 12:50:38.000000000","message":"I\u0027m not blocking here, as it is already a cherry-pick...what what is the purpose of a constant that can be reassigned? then it isn\u0027t a constant, but a variable (maybe it would make more sense as a class attribute)","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"5a1fb22a17574761e64a97c2909c27076f2371cd","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        )"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        parser.add_argument("},{"line_number":234,"context_line":"            \u0027--limit\u0027, action\u003d\u0027store\u0027, required\u003dFalse, help\u003d_("},{"line_number":235,"context_line":"                \"A string that identifies a single node or comma-separated\""},{"line_number":236,"context_line":"                \"list of nodes to be upgraded in parallel in this upgrade\""},{"line_number":237,"context_line":"                \" run invocation. For example: --limit \\\"compute-0,\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f6292b37","line":234,"updated":"2020-09-04 12:50:38.000000000","message":"oh! this will be useful for the upgrades validations.","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"17fd2809f82fc69c99843629969c00dc369c0d09","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        )"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        extra_vars_group.add_argument("},{"line_number":274,"context_line":"            \u0027--extra-env-vars\u0027,"},{"line_number":275,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":276,"context_line":"            default\u003d{},"},{"line_number":277,"context_line":"            type\u003djson.loads,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9a5f1c0e","line":274,"updated":"2020-09-07 11:55:40.000000000","message":"This argument and --extra-vars (see above l251) have the same goal","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"614c5e5e57d118dea7baaeb91eb8bce0af555803","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        )"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        extra_vars_group.add_argument("},{"line_number":274,"context_line":"            \u0027--extra-env-vars\u0027,"},{"line_number":275,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":276,"context_line":"            default\u003d{},"},{"line_number":277,"context_line":"            type\u003djson.loads,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_b5f4b35c","line":274,"in_reply_to":"9f560f44_9a5f1c0e","updated":"2020-09-07 13:41:51.000000000","message":"Yep this is addressed here:\nhttps://review.opendev.org/#/c/749897/","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"5a1fb22a17574761e64a97c2909c27076f2371cd","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            extra_vars\u003dparsed_args.extra_vars,"},{"line_number":333,"context_line":"            validations_dir\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":334,"context_line":"            validation_name\u003dparsed_args.validation_name,"},{"line_number":335,"context_line":"            extra_env_vars\u003dparsed_args.extra_env_vars,"},{"line_number":336,"context_line":"            quiet\u003dparsed_args.quiet)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        # Build output"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_96ef0fe8","line":335,"updated":"2020-09-04 12:50:38.000000000","message":"the run_validations does not accept the python_interpreter as parameter? that will be an issue with this patch then: https://review.opendev.org/749735","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"614c5e5e57d118dea7baaeb91eb8bce0af555803","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            extra_vars\u003dparsed_args.extra_vars,"},{"line_number":333,"context_line":"            validations_dir\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":334,"context_line":"            validation_name\u003dparsed_args.validation_name,"},{"line_number":335,"context_line":"            extra_env_vars\u003dparsed_args.extra_env_vars,"},{"line_number":336,"context_line":"            quiet\u003dparsed_args.quiet)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        # Build output"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_596808b9","line":335,"in_reply_to":"9f560f44_96ef0fe8","updated":"2020-09-07 13:41:51.000000000","message":"It\u0027s a cherry pick I will probably rebase the interpreter patch on top of this, or in another way but I don\u0027t want to update a cherry pick","commit_id":"f3853c941bc53081217c54c1ebd3d7b50f58e0f6"}]}