)]}'
{"tripleoclient/v2/overcloud_network.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b827b392ce372cfb4c2e277e917131580e347181","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                extra_vars\u003dextra_vars,"},{"line_number":65,"context_line":"            )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0fd7cbc2","line":67,"updated":"2020-09-14 21:04:35.000000000","message":"pep8: W391 blank line at end of file","commit_id":"c14f66bf7df5c493171b7709c5798686eff30fc6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2a172302b2f623dac50dec143560680a90b4b9ee","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                extra_vars\u003dextra_vars,"},{"line_number":65,"context_line":"            )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1d86b814","line":67,"updated":"2020-09-16 20:18:53.000000000","message":"pep8: W391 blank line at end of file","commit_id":"46e34ae7f86d6c5e55719fa53b6f0a2ce5a0ce8a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a73cb73bbc6e8e92c679373fb69be9a71c39929d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                   \u0027network deployment\u0027))"},{"line_number":43,"context_line":"        parser.add_argument(\u0027--overwrite\u0027, default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":44,"context_line":"                            help\u003d_(\u0027Overwrite the output file in case it\u0027"},{"line_number":45,"context_line":"                                   \u0027already exists\u0027))"},{"line_number":46,"context_line":"        return parser"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_856f20f9","line":45,"updated":"2020-10-01 00:42:48.000000000","message":"To be consistent with other commands, how about replacing --overwrite with a --yes flag, which won\u0027t show a yes/no prompt  when the output file exists, like:\n \nhttps://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/overcloud_node.py#L491","commit_id":"19f1386946303f2ed49a807b4cd287f4bffb2757"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5242232d81a954df251116a27fe4e46fc9f38c06","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                   \u0027network deployment\u0027))"},{"line_number":43,"context_line":"        parser.add_argument(\u0027--overwrite\u0027, default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":44,"context_line":"                            help\u003d_(\u0027Overwrite the output file in case it\u0027"},{"line_number":45,"context_line":"                                   \u0027already exists\u0027))"},{"line_number":46,"context_line":"        return parser"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_27e701e6","line":45,"in_reply_to":"9f560f44_856f20f9","updated":"2020-10-07 11:16:25.000000000","message":"Done","commit_id":"19f1386946303f2ed49a807b4cd287f4bffb2757"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fdbcc49d00e2199bb18a6708771dd08dbc523693","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        output_path \u003d os.path.abspath(parsed_args.output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        overwrite \u003d False"},{"line_number":57,"context_line":"        if (os.path.exists(output_path)"},{"line_number":58,"context_line":"                and not parsed_args.yes and sys.stdin.isatty()):"},{"line_number":59,"context_line":"            prompt_response \u003d six.moves.input("}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_bdf03e93","line":56,"updated":"2020-10-06 01:41:10.000000000","message":"you could just have overwrite \u003d parsed_args.yes here and simplify the below to not reference parsed_args.yes again","commit_id":"987b0e180b4ed4f55f52ff8bde7723110cab369f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5242232d81a954df251116a27fe4e46fc9f38c06","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        output_path \u003d os.path.abspath(parsed_args.output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        overwrite \u003d False"},{"line_number":57,"context_line":"        if (os.path.exists(output_path)"},{"line_number":58,"context_line":"                and not parsed_args.yes and sys.stdin.isatty()):"},{"line_number":59,"context_line":"            prompt_response \u003d six.moves.input("}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_fb7d871e","line":56,"in_reply_to":"9f560f44_bdf03e93","updated":"2020-10-07 11:16:25.000000000","message":"indeed, thanks Steve! Done!","commit_id":"987b0e180b4ed4f55f52ff8bde7723110cab369f"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f45fc8e715f25821dc0d87a81204eb351f042a87","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OvercloudNetworkExtract(command.Command):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    log \u003d logging.getLogger(__name__ + \".ExtractProvisionedNetworks\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(OvercloudNetworkExtract, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f621f24_ea73187f","line":30,"range":{"start_line":30,"start_character":41,"end_line":30,"end_character":67},"updated":"2020-11-04 03:13:32.000000000","message":"Need to be aligned with the class name \"OvercloudNetworkExtract\".","commit_id":"00a30893c73c8a7915085a4bae2bb4b31f4bf8fd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0958737d33598d8cd8b2403e96204fe654e2cf63","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OvercloudNetworkExtract(command.Command):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    log \u003d logging.getLogger(__name__ + \".ExtractProvisionedNetworks\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_parser(self, prog_name):"},{"line_number":33,"context_line":"        parser \u003d super(OvercloudNetworkExtract, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f621f24_08665752","line":30,"range":{"start_line":30,"start_character":41,"end_line":30,"end_character":67},"in_reply_to":"1f621f24_ea73187f","updated":"2020-11-04 13:27:42.000000000","message":"Good catch! Thanks!","commit_id":"00a30893c73c8a7915085a4bae2bb4b31f4bf8fd"}]}