)]}'
{"tripleoclient/tests/v1/undercloud/test_config.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"21f979b236ee47ad7d5ad1e891370883a197796f","unresolved":false,"context_lines":[{"line_number":959,"context_line":"        }"},{"line_number":960,"context_line":"        self.assertEqual(expected, env)"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"class TestTLSSettings(base.TestCase):"},{"line_number":963,"context_line":"    def test_public_host_with_ip_should_give_ip_endpoint_environment(self):"},{"line_number":964,"context_line":"        expected_env_file \u003d os.path.join("},{"line_number":965,"context_line":"            undercloud_config.THT_HOME,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1b9d8956","line":962,"updated":"2020-09-24 23:55:15.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"6a66ad26aa14d66d704d6369d09513adfea4c254"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"85d101cbc7875fe3e94807978264a7972c777f05","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        except openstack.exceptions.ConfigException:"},{"line_number":112,"context_line":"            return dict()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        network \u003d conn.network.find_network(\u0027ctlplane\u0027)"},{"line_number":115,"context_line":"        if network is None:"},{"line_number":116,"context_line":"            return dict()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ae138a58","line":114,"updated":"2020-09-24 12:24:03.000000000","message":"Is it possible to use \"local_subnet\" of the undercloud config to get the name instead of hardcoding it?","commit_id":"f015409092f274a91418dcc99d6c6b94279741d2"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"81d7136592ad3c03e7a42445c88e50d39038aabd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        except openstack.exceptions.ConfigException:"},{"line_number":112,"context_line":"            return dict()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        network \u003d conn.network.find_network(\u0027ctlplane\u0027)"},{"line_number":115,"context_line":"        if network is None:"},{"line_number":116,"context_line":"            return dict()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_2e981a67","line":114,"in_reply_to":"9f560f44_4eb2ae07","updated":"2020-09-24 12:43:12.000000000","message":"\u003e This is the network name, not the subnet name. \n\nMy bad..","commit_id":"f015409092f274a91418dcc99d6c6b94279741d2"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"83cfc83092c345924a635f6a51d7fb0ec31036d2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        except openstack.exceptions.ConfigException:"},{"line_number":112,"context_line":"            return dict()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        network \u003d conn.network.find_network(\u0027ctlplane\u0027)"},{"line_number":115,"context_line":"        if network is None:"},{"line_number":116,"context_line":"            return dict()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4eb2ae07","line":114,"in_reply_to":"9f560f44_ae138a58","updated":"2020-09-24 12:40:26.000000000","message":"This is the network name, not the subnet name. We never allow changeing that. \n\n\u0027local_subnet\u0027 defaults to \u0027ctlplane-subnet\u0027.","commit_id":"f015409092f274a91418dcc99d6c6b94279741d2"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cc18cc38438f0480c6529557330543ced99f4686","unresolved":false,"context_lines":[{"line_number":703,"context_line":"            stack_name\u003dparsed_args.stack,"},{"line_number":704,"context_line":"            role_name\u003dself._get_primary_role_name("},{"line_number":705,"context_line":"                roles_file_path, parsed_args.templates)))"},{"line_number":706,"context_line":"        tmp_env.update("},{"line_number":707,"context_line":"            {"},{"line_number":708,"context_line":"                \u0027CtlplaneNetworkAttributes\u0027: {"},{"line_number":709,"context_line":"                    \u0027subnets\u0027: {"},{"line_number":710,"context_line":"                        \u0027ctlplane-subnet\u0027: {"},{"line_number":711,"context_line":"                            \u0027cidr\u0027: str(ip_nw.cidr),"},{"line_number":712,"context_line":"                            \u0027host_routes\u0027: []"},{"line_number":713,"context_line":"                        }"},{"line_number":714,"context_line":"                    }"},{"line_number":715,"context_line":"                }"},{"line_number":716,"context_line":"            }"},{"line_number":717,"context_line":"        )"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        with open(maps_file, \u0027w\u0027) as env_file:"},{"line_number":720,"context_line":"            yaml.safe_dump({\u0027parameter_defaults\u0027: tmp_env}, env_file,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_5fe86879","line":717,"range":{"start_line":706,"start_character":8,"end_line":717,"end_character":9},"updated":"2020-09-28 10:01:41.000000000","message":"I will do a follow up to improve this a bit. We can populate this better if we read some values of the standalone user environment. For example - InterfaceLocalMtu, ControlPlaneStaticRoutes and from StandaloneCtlplaneSubnets which quicstart set\u0027s. ref: https://609391c36419d101c9fa-c21ba3df839786eb7baa2d6ac30080ab.ssl.cf2.rackcdn.com/753941/9/check/tripleo-ci-centos-8-standalone/a55807a/logs/undercloud/home/zuul/standalone_parameters.yaml","commit_id":"6ced9c71db18c07279d4dfe80842eb631f6b0179"}]}