)]}'
{"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c343b8b88ae70934db5b27c48e440bc63645930f","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                      \"inventory or use authentication.\"))"},{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            if plan:"},{"line_number":349,"context_line":"                if not deployment.get_deployment_status(clients, plan):"},{"line_number":350,"context_line":"                    raise exceptions.CommandError("},{"line_number":351,"context_line":"                        _(\"The plan and the stack \u0027{}\u0027 doesn\u0027t exist. \""},{"line_number":352,"context_line":"                          \"Please use a valid plan\".format(plan)))"}],"source_content_type":"text/x-python","patch_set":7,"id":"43fbd54c_30fa04ea","line":349,"range":{"start_line":349,"start_character":23,"end_line":349,"end_character":70},"updated":"2020-12-03 05:13:52.000000000","message":"Would you allow running overcloud validation when the initial heat stack deployment fails? Probably not right?\n\nI think this condition would be false in that case[1]\n\n[1] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/workflows/deployment.py#L93-L95","commit_id":"1e38c536d52b1070814d09736d68eba318a11ee9"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"e2882a65dbac49b09397a2462543270d60ef7cdf","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                      \"inventory or use authentication.\"))"},{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            if plan:"},{"line_number":349,"context_line":"                if not deployment.get_deployment_status(clients, plan):"},{"line_number":350,"context_line":"                    raise exceptions.CommandError("},{"line_number":351,"context_line":"                        _(\"The plan and the stack \u0027{}\u0027 doesn\u0027t exist. \""},{"line_number":352,"context_line":"                          \"Please use a valid plan\".format(plan)))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5cfb60ed_dbe5d0bb","line":349,"range":{"start_line":349,"start_character":23,"end_line":349,"end_character":70},"in_reply_to":"43fbd54c_30fa04ea","updated":"2020-12-03 08:31:13.000000000","message":"Hey Rabi,\n\nThank you for comment. Actually, I don\u0027t know if we have to go until the deployment status.\nI\u0027m wondering in particular cases like for example, my TripleO deployment has failed but I want to run some Validations to check some status or services or params on my nodes.\nAnother one would be to launch some check when the stack is currently deploying (in parallel).\nWdyt ?\n\nSo the initial goal in this review was mostly to be sure that we are trying to run validations on an existing stack, handling in particular the case where the user specify another stack name and forgot to pass the --plan option to the validation CLI.","commit_id":"1e38c536d52b1070814d09736d68eba318a11ee9"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ff780030edeeb04bbc1ec4ad78d72893f9aa6d69","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                      \"inventory or use authentication.\"))"},{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            if plan:"},{"line_number":349,"context_line":"                if not deployment.get_deployment_status(clients, plan):"},{"line_number":350,"context_line":"                    raise exceptions.CommandError("},{"line_number":351,"context_line":"                        _(\"The plan and the stack \u0027{}\u0027 doesn\u0027t exist. \""},{"line_number":352,"context_line":"                          \"Please use a valid plan\".format(plan)))"}],"source_content_type":"text/x-python","patch_set":7,"id":"742af55a_12942256","line":349,"range":{"start_line":349,"start_character":23,"end_line":349,"end_character":70},"in_reply_to":"5cfb60ed_dbe5d0bb","updated":"2020-12-03 08:40:42.000000000","message":"I mean the stack create could fail as it could not provision nodes you want to check (or still being provisioned) and deployment_status would return DEPLOY_FAILED or DEPLOYING. stable/victoria  and master with no node provisioning by heat stack, checking the stack status/deployment status both are irrelevant for the kind of checks you mentioned.","commit_id":"1e38c536d52b1070814d09736d68eba318a11ee9"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"b39eda822849095674c455f8ae81888cc0ba5ff1","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                      \"inventory or use authentication.\"))"},{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            if plan:"},{"line_number":349,"context_line":"                if not deployment.get_deployment_status(clients, plan):"},{"line_number":350,"context_line":"                    raise exceptions.CommandError("},{"line_number":351,"context_line":"                        _(\"The plan and the stack \u0027{}\u0027 doesn\u0027t exist. \""},{"line_number":352,"context_line":"                          \"Please use a valid plan\".format(plan)))"}],"source_content_type":"text/x-python","patch_set":7,"id":"d2e0ab61_24e9a994","line":349,"range":{"start_line":349,"start_character":23,"end_line":349,"end_character":70},"in_reply_to":"742af55a_12942256","updated":"2020-12-03 14:45:51.000000000","message":"Ack ok, I just added a check for DEPLOY_FAILED, DEPLOYING in the next PS.","commit_id":"1e38c536d52b1070814d09736d68eba318a11ee9"}]}