)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bf5673b40aabfa09a7393b857eb52537517bf65b","unresolved":true,"context_lines":[{"line_number":1014,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":1015,"context_line":"            default\u003dNone,"},{"line_number":1016,"context_line":"            help\u003d_(\u0027Only used when \"--setup-only\" is invoked. \u0027"},{"line_number":1017,"context_line":"                   \u0027Directory to use for saved output when using \u0027"},{"line_number":1018,"context_line":"                   \u0027--config-download. When not \u0027"},{"line_number":1019,"context_line":"                   \u0027specified, $HOME/config-download will be used.\u0027)"},{"line_number":1020,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"57cb1882_cdd491f6","line":1017,"updated":"2021-01-28 18:31:59.000000000","message":"is that the case? looks like it\u0027s still used in workflows/deployment.py regardless.","commit_id":"03b08a173b51b92616d89b633e0409519cf838e3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"aec728b58248edd31bda16cfd0e7a18e1fd1146f","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":1015,"context_line":"            default\u003dNone,"},{"line_number":1016,"context_line":"            help\u003d_(\u0027Only used when \"--setup-only\" is invoked. \u0027"},{"line_number":1017,"context_line":"                   \u0027Directory to use for saved output when using \u0027"},{"line_number":1018,"context_line":"                   \u0027--config-download. When not \u0027"},{"line_number":1019,"context_line":"                   \u0027specified, $HOME/config-download will be used.\u0027)"},{"line_number":1020,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"03c9a0d3_f069e37a","line":1017,"in_reply_to":"54e3455d_a418663d","updated":"2021-01-28 18:48:22.000000000","message":"Done","commit_id":"03b08a173b51b92616d89b633e0409519cf838e3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"be32a39a0575d9fe3bd5cd4c6cbe2c3db370356d","unresolved":true,"context_lines":[{"line_number":1014,"context_line":"            action\u003d\u0027store\u0027,"},{"line_number":1015,"context_line":"            default\u003dNone,"},{"line_number":1016,"context_line":"            help\u003d_(\u0027Only used when \"--setup-only\" is invoked. \u0027"},{"line_number":1017,"context_line":"                   \u0027Directory to use for saved output when using \u0027"},{"line_number":1018,"context_line":"                   \u0027--config-download. When not \u0027"},{"line_number":1019,"context_line":"                   \u0027specified, $HOME/config-download will be used.\u0027)"},{"line_number":1020,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"54e3455d_a418663d","line":1017,"in_reply_to":"57cb1882_cdd491f6","updated":"2021-01-28 18:40:07.000000000","message":"++ this notice should actually be dropped from this one","commit_id":"03b08a173b51b92616d89b633e0409519cf838e3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bf5673b40aabfa09a7393b857eb52537517bf65b","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"                )"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"                if not parsed_args.config_download_only and \\"},{"line_number":1162,"context_line":"                   not parsed_args.setup_only:"},{"line_number":1163,"context_line":"                    deployment.get_hosts_and_enable_ssh_admin("},{"line_number":1164,"context_line":"                        stack,"},{"line_number":1165,"context_line":"                        parsed_args.overcloud_ssh_network,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0cf3c2bd_dfdad114","line":1162,"updated":"2021-01-28 18:31:59.000000000","message":"what\u0027s the reason why we can\u0027t go ahead and run this now, instead of having to add a 2nd call?","commit_id":"03b08a173b51b92616d89b633e0409519cf838e3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"be32a39a0575d9fe3bd5cd4c6cbe2c3db370356d","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"                )"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"                if not parsed_args.config_download_only and \\"},{"line_number":1162,"context_line":"                   not parsed_args.setup_only:"},{"line_number":1163,"context_line":"                    deployment.get_hosts_and_enable_ssh_admin("},{"line_number":1164,"context_line":"                        stack,"},{"line_number":1165,"context_line":"                        parsed_args.overcloud_ssh_network,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0863467_8c360ac0","line":1162,"in_reply_to":"0cf3c2bd_dfdad114","updated":"2021-01-28 18:40:07.000000000","message":"at this point, I don\u0027t think the inventory has been updated which would run the admin-auth playbook across an incorrect set of nodes. I kept this here so that he existing logic would remain functional should the new arg be used.","commit_id":"03b08a173b51b92616d89b633e0409519cf838e3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9af42de7a89d973d10ec1fe248fa77dd3ed13c2a","unresolved":true,"context_lines":[{"line_number":1157,"context_line":"                    status\u003d\u0027DEPLOYING\u0027"},{"line_number":1158,"context_line":"                )"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"                if not parsed_args.config_download_only and \\"},{"line_number":1161,"context_line":"                   not parsed_args.setup_only:"},{"line_number":1162,"context_line":"                    deployment.get_hosts_and_enable_ssh_admin("},{"line_number":1163,"context_line":"                        stack,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa8c126_680bcc09","line":1160,"range":{"start_line":1160,"start_character":60,"end_line":1160,"end_character":61},"updated":"2021-03-03 22:15:53.000000000","message":"nit: Useing parentheses instead of the backslash is considered better code style.","commit_id":"be580c669065c59789601f28bfbaee8318e67c0d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9af42de7a89d973d10ec1fe248fa77dd3ed13c2a","unresolved":true,"context_lines":[{"line_number":1206,"context_line":"                if parsed_args.setup_only:"},{"line_number":1207,"context_line":"                    # Download config"},{"line_number":1208,"context_line":"                    config_dir \u003d os.path.abspath(parsed_args.config_dir)"},{"line_number":1209,"context_line":"                    config_type \u003d parsed_args.config_type"},{"line_number":1210,"context_line":"                    preserve_config_dir \u003d parsed_args.preserve_config_dir"},{"line_number":1211,"context_line":"                    extra_vars \u003d {"},{"line_number":1212,"context_line":"                        \u0027plan\u0027: stack.stack_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"88c58a50_d6c40541","line":1209,"range":{"start_line":1209,"start_character":20,"end_line":1209,"end_character":57},"updated":"2021-03-03 22:15:53.000000000","message":"Is there really a need to assign config_type?\nCan do ``extra_vars[\u0027config_type\u0027] \u003d parsed_args.config_type`` at L1217.","commit_id":"be580c669065c59789601f28bfbaee8318e67c0d"}]}