)]}'
{"tripleoclient/utils.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b12eeffb8b78cddb52bc3c25dd7656612fc46ce2","unresolved":true,"context_lines":[{"line_number":607,"context_line":"            env.update(extra_env_variables)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    if \u0027ANSIBLE_CONFIG\u0027 not in env and not ansible_cfg:"},{"line_number":610,"context_line":"        ansible_cfg \u003d os.path.join(workdir, \u0027ansible.cfg\u0027)"},{"line_number":611,"context_line":"        config \u003d configparser.ConfigParser()"},{"line_number":612,"context_line":"        if os.path.isfile(ansible_cfg):"},{"line_number":613,"context_line":"            config.read(ansible_cfg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"74a3d094_ea5c4c7d","line":610,"updated":"2021-02-26 14:47:53.000000000","message":"I have a feeling this is why this is failing because previously we weren\u0027t using the ansible.cfg but rather relying on the env vars below.  The ansible.cfg was only used when run externally or after the fact by an end user.  So the change to drop inject fact vars in ansible.cfg is being picked up now.  The error you\u0027re seeing on your changes now are similar to https://review.opendev.org/c/openstack/python-tripleoclient/+/776558/5/tripleoclient/utils.py#571 when we actually switched the env vars to do it.  I think you\u0027ve changed where the ansible settings are coming from. It\u0027d be better to always use ansible.cfg, but then we should drop all the ANSIBLE_* vars.  I\u0027m uncertain the impact on ansible-runner","commit_id":"d9ad865c16bec2cd2bb199e6d36b7cfb72840182"}],"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d430e2169f741e8bfd8fdd478c2ebf82146fa078","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            template, files, env_files_tracker,"},{"line_number":286,"context_line":"            self.log, self.working_dir)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def _deploy_tripleo_heat_templates_tmpdir(self, stack, parsed_args):"},{"line_number":289,"context_line":"        tht_root \u003d os.path.abspath(parsed_args.templates)"},{"line_number":290,"context_line":"        new_tht_root \u003d \"%s/tripleo-heat-templates\" % self.working_dir"},{"line_number":291,"context_line":"        self.log.debug(\"Creating working templates tree in %s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"f1e612ed_60e0eee6","line":288,"updated":"2021-02-17 07:39:06.000000000","message":"worth revisiting the name of the function? we no longer use tempfile here","commit_id":"97fc459ee47ba14f03fdc6a375632792f7762a5c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fe35427e3f16691122ccfac68b1a2967f33bb797","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        finally:"},{"line_number":263,"context_line":"            utils.archive_deploy_artifacts(self.log, parsed_args.stack,"},{"line_number":264,"context_line":"                                           new_tht_root)"},{"line_number":265,"context_line":"            if parsed_args.no_cleanup:"},{"line_number":266,"context_line":"                self.log.warning(\"Not cleaning temporary directory %s\""},{"line_number":267,"context_line":"                                 % tht_tmp)"},{"line_number":268,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"865e1e8a_18ff2398","side":"PARENT","line":265,"range":{"start_line":265,"start_character":27,"end_line":265,"end_character":37},"updated":"2021-02-23 14:09:41.000000000","message":"please add a deprecation message that explains what this params will do (nothing?)","commit_id":"0fa8098973095cc33328fe0166c1b79ef60dc346"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7a57ba9dc28d0e4e68c6f3bf2a08235f4c16d0dd","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        finally:"},{"line_number":263,"context_line":"            utils.archive_deploy_artifacts(self.log, parsed_args.stack,"},{"line_number":264,"context_line":"                                           new_tht_root)"},{"line_number":265,"context_line":"            if parsed_args.no_cleanup:"},{"line_number":266,"context_line":"                self.log.warning(\"Not cleaning temporary directory %s\""},{"line_number":267,"context_line":"                                 % tht_tmp)"},{"line_number":268,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e115774c_c0119d1d","side":"PARENT","line":265,"range":{"start_line":265,"start_character":27,"end_line":265,"end_character":37},"in_reply_to":"865e1e8a_18ff2398","updated":"2021-02-25 20:28:33.000000000","message":"well, it\u0027s still in use as of now (see line 105 for example). until absolutely everything is switched over. once the migration is complete, I can add a deprecation message.","commit_id":"0fa8098973095cc33328fe0166c1b79ef60dc346"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2eb382717684266b9f0fbfaef63d3158d9f4465","unresolved":true,"context_lines":[{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if not parsed_args.working_dir:"},{"line_number":881,"context_line":"            self.working_dir \u003d os.path.join("},{"line_number":882,"context_line":"                os.path.expanduser(\u0027~\u0027),"},{"line_number":883,"context_line":"                \"overcloud-deploy-%s\" % parsed_args.stack)"},{"line_number":884,"context_line":"        else:"},{"line_number":885,"context_line":"            self.working_dir \u003d parsed_args.working_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"73a004c6_16ccf83a","line":882,"range":{"start_line":882,"start_character":16,"end_line":882,"end_character":39},"updated":"2021-02-23 14:12:12.000000000","message":"constants.DEFAULT_WORK_DIR ?","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"286805b52789771c3eafdfc272e6f8ef6568151b","unresolved":true,"context_lines":[{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if not parsed_args.working_dir:"},{"line_number":881,"context_line":"            self.working_dir \u003d os.path.join("},{"line_number":882,"context_line":"                os.path.expanduser(\u0027~\u0027),"},{"line_number":883,"context_line":"                \"overcloud-deploy-%s\" % parsed_args.stack)"},{"line_number":884,"context_line":"        else:"},{"line_number":885,"context_line":"            self.working_dir \u003d parsed_args.working_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aaa7434_6fdb2703","line":882,"range":{"start_line":882,"start_character":16,"end_line":882,"end_character":39},"in_reply_to":"73a004c6_16ccf83a","updated":"2021-02-25 07:07:46.000000000","message":"I think not because he wants the default working_dir to be ~/overcloud-deploy-\u003cstack\u003e\nbut the https://opendev.org/openstack/python-tripleoclient/src/commit/42aa7357fb59ebad2ef34108fa1ad3e259b10cb6/tripleoclient/constants.py#L101 DEFAULT_WORK_DIR is ~/config-download/\n\nBut I think there will be some confusion between the arg added here --working-dir with the constant DEFAULT_WORK_DIR \n\nProbably that constant should be called \u0027CONFIG_DOWNLOAD_DIR\u0027 or somethign...","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7a57ba9dc28d0e4e68c6f3bf2a08235f4c16d0dd","unresolved":true,"context_lines":[{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if not parsed_args.working_dir:"},{"line_number":881,"context_line":"            self.working_dir \u003d os.path.join("},{"line_number":882,"context_line":"                os.path.expanduser(\u0027~\u0027),"},{"line_number":883,"context_line":"                \"overcloud-deploy-%s\" % parsed_args.stack)"},{"line_number":884,"context_line":"        else:"},{"line_number":885,"context_line":"            self.working_dir \u003d parsed_args.working_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"cfb39168_734f4dcd","line":882,"range":{"start_line":882,"start_character":16,"end_line":882,"end_character":39},"in_reply_to":"9aaa7434_6fdb2703","updated":"2021-02-25 20:28:33.000000000","message":"I can call this argument stack-dir if we think that will eliminate confusion. I kind of like that better honestly anyway.\n\nFor now, I\u0027d like to leave constants.DEFAULT_WORK_DIR as it is, b/c there is a lot of code that assumes that is equivalent to ~/config-download.\n\nI\u0027ve added a symlink creation from ~/config-download to ~/overcloud-deploy/\u003cstack\u003e/config-download for now to maintain that compatibility.","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"44c98d2d72322465d3872b39b92d49ab47993e85","unresolved":true,"context_lines":[{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if not parsed_args.working_dir:"},{"line_number":881,"context_line":"            self.working_dir \u003d os.path.join("},{"line_number":882,"context_line":"                os.path.expanduser(\u0027~\u0027),"},{"line_number":883,"context_line":"                \"overcloud-deploy-%s\" % parsed_args.stack)"},{"line_number":884,"context_line":"        else:"},{"line_number":885,"context_line":"            self.working_dir \u003d parsed_args.working_dir"}],"source_content_type":"text/x-python","patch_set":4,"id":"faa85318_9fe738a3","line":882,"range":{"start_line":882,"start_character":16,"end_line":882,"end_character":39},"in_reply_to":"cfb39168_734f4dcd","updated":"2021-03-01 08:41:14.000000000","message":"i mean it does eliminate confusion between \u0027DEFAULT_WORK_DIR\u0027 and this which is a new \u0027working directory\u0027 ... sure \u0027stack-dir\u0027 or possibly something more like \u0027deployment-data\u0027 or \u0027deploy-data\u0027\n\nbut you know... naming ;)","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7e1a4baa9872c3aae9d194d5772c1db920181c6a","unresolved":true,"context_lines":[{"line_number":944,"context_line":"            # $HOME and then self.working_dir."},{"line_number":945,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":946,"context_line":"                stack, rc_params, parsed_args.no_proxy)"},{"line_number":947,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":948,"context_line":"                stack, rc_params, parsed_args.no_proxy,"},{"line_number":949,"context_line":"                self.working_dir)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"416b3db0_f88a057a","line":947,"range":{"start_line":947,"start_character":12,"end_line":947,"end_character":18},"updated":"2021-02-23 14:14:06.000000000","message":"this makes the former rcpath assignment lost, is that expected? or use _ maybe","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7a57ba9dc28d0e4e68c6f3bf2a08235f4c16d0dd","unresolved":false,"context_lines":[{"line_number":944,"context_line":"            # $HOME and then self.working_dir."},{"line_number":945,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":946,"context_line":"                stack, rc_params, parsed_args.no_proxy)"},{"line_number":947,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":948,"context_line":"                stack, rc_params, parsed_args.no_proxy,"},{"line_number":949,"context_line":"                self.working_dir)"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b352868b_31e28f49","line":947,"range":{"start_line":947,"start_character":12,"end_line":947,"end_character":18},"in_reply_to":"416b3db0_f88a057a","updated":"2021-02-25 20:28:33.000000000","message":"Done","commit_id":"040aa172305ab09820cfe2cfd59c4a9b11ba5f30"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"286805b52789771c3eafdfc272e6f8ef6568151b","unresolved":true,"context_lines":[{"line_number":940,"context_line":"                self.orchestration_client,"},{"line_number":941,"context_line":"                parsed_args.stack)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"            # For backwards compatibility, we will also write overcloudrc to"},{"line_number":944,"context_line":"            # $HOME and then self.working_dir."},{"line_number":945,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":946,"context_line":"                stack, rc_params, parsed_args.no_proxy)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dbad0bc2_f654d7ff","line":943,"updated":"2021-02-25 07:07:46.000000000","message":"hmmm perhaps considering this is a sensitive file do we also need to add some log.info or log.warning here i.e. the file is being written to foo and also bar\ni just checked and the function itself isn\u0027t printing any info https://opendev.org/openstack/python-tripleoclient/src/commit/42aa7357fb59ebad2ef34108fa1ad3e259b10cb6/tripleoclient/workflows/deployment.py#L34-L44","commit_id":"cf0e45ca8f380348fc0fa323106561bbf795a8a7"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"7a57ba9dc28d0e4e68c6f3bf2a08235f4c16d0dd","unresolved":true,"context_lines":[{"line_number":940,"context_line":"                self.orchestration_client,"},{"line_number":941,"context_line":"                parsed_args.stack)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"            # For backwards compatibility, we will also write overcloudrc to"},{"line_number":944,"context_line":"            # $HOME and then self.working_dir."},{"line_number":945,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":946,"context_line":"                stack, rc_params, parsed_args.no_proxy)"}],"source_content_type":"text/x-python","patch_set":5,"id":"feabd83c_7880cf3b","line":943,"in_reply_to":"dbad0bc2_f654d7ff","updated":"2021-02-25 20:28:33.000000000","message":"I added both paths to the output below where we print the rcpath.","commit_id":"cf0e45ca8f380348fc0fa323106561bbf795a8a7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"44c98d2d72322465d3872b39b92d49ab47993e85","unresolved":true,"context_lines":[{"line_number":940,"context_line":"                self.orchestration_client,"},{"line_number":941,"context_line":"                parsed_args.stack)"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"            # For backwards compatibility, we will also write overcloudrc to"},{"line_number":944,"context_line":"            # $HOME and then self.working_dir."},{"line_number":945,"context_line":"            rcpath \u003d deployment.create_overcloudrc("},{"line_number":946,"context_line":"                stack, rc_params, parsed_args.no_proxy)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1e7433a4_dd9a8d2b","line":943,"in_reply_to":"feabd83c_7880cf3b","updated":"2021-03-01 08:41:14.000000000","message":"thanks i see you added old_rcpath https://review.opendev.org/c/openstack/python-tripleoclient/+/775302/5..8","commit_id":"cf0e45ca8f380348fc0fa323106561bbf795a8a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"25e9955b1bf4cfa2175d58062ef3741db96fa1bb","unresolved":true,"context_lines":[{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if not parsed_args.working_dir:"},{"line_number":881,"context_line":"            self.working_dir \u003d os.path.join("},{"line_number":882,"context_line":"                os.path.expanduser(\u0027~\u0027),"},{"line_number":883,"context_line":"                \"overcloud-deploy-%s\" % parsed_args.stack)"},{"line_number":884,"context_line":"        else:"},{"line_number":885,"context_line":"            self.working_dir \u003d parsed_args.working_dir"}],"source_content_type":"text/x-python","patch_set":8,"id":"040d2449_2b22c6c7","line":882,"updated":"2021-03-03 11:37:07.000000000","message":"We have to collect this folder in CI I think. RDO jobs also don\u0027t have the config-download dir collected after this change.","commit_id":"336808ba5760b76f928ee928c2463a4609c877b7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"44c98d2d72322465d3872b39b92d49ab47993e85","unresolved":true,"context_lines":[{"line_number":1039,"context_line":"            print(\"Overcloud Endpoint: {0}\".format(overcloud_endpoint))"},{"line_number":1040,"context_line":"            print(\"Overcloud Horizon Dashboard URL: {0}\".format(horizon_url))"},{"line_number":1041,"context_line":"            print(\"Overcloud rc file: {} and {}\".format("},{"line_number":1042,"context_line":"                rcpath, old_rcpath))"},{"line_number":1043,"context_line":"            print(\"Overcloud Deployed {0}\".format(deploy_message))"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"            if parsed_args.output_dir:"}],"source_content_type":"text/x-python","patch_set":8,"id":"e679624d_329b7b0b","line":1042,"range":{"start_line":1042,"start_character":24,"end_line":1042,"end_character":34},"updated":"2021-03-01 08:41:14.000000000","message":"ack thanks","commit_id":"336808ba5760b76f928ee928c2463a4609c877b7"}],"tripleoclient/workflows/deployment.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ce164036552bdb4528a81af3939a631156bde934","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            return f.read().strip()"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"def get_deployment_status(clients, stack_name):"},{"line_number":477,"context_line":"    \"\"\"Return current deployment status.\"\"\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0b64fb3c_b63942f5","line":476,"range":{"start_line":476,"start_character":4,"end_line":476,"end_character":46},"updated":"2021-03-18 04:13:38.000000000","message":"This is broken and should use working-dir to get the status.","commit_id":"336808ba5760b76f928ee928c2463a4609c877b7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"41377761fd006872b6f07d2b99ef568f7810e2b1","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            return f.read().strip()"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"def get_deployment_status(clients, stack_name):"},{"line_number":477,"context_line":"    \"\"\"Return current deployment status.\"\"\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2482fa9a_4575c74d","line":476,"range":{"start_line":476,"start_character":4,"end_line":476,"end_character":46},"in_reply_to":"01af84a4_50d0794c","updated":"2021-03-18 09:06:34.000000000","message":"Fixed with https://review.opendev.org/c/openstack/python-tripleoclient/+/781190","commit_id":"336808ba5760b76f928ee928c2463a4609c877b7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b45b2b27358e29f7950fd60e03295032e3a4a66d","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            return f.read().strip()"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"def get_deployment_status(clients, stack_name):"},{"line_number":477,"context_line":"    \"\"\"Return current deployment status.\"\"\""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"01af84a4_50d0794c","line":476,"range":{"start_line":476,"start_character":4,"end_line":476,"end_character":46},"in_reply_to":"0b64fb3c_b63942f5","updated":"2021-03-18 08:59:35.000000000","message":"oops, sorry for that!..","commit_id":"336808ba5760b76f928ee928c2463a4609c877b7"}]}