)]}'
{"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"35ba103e567e25a93bc64bb5e18e75fbe36640a1","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        redis_vip \u003d user_params.get(\u0027RedisVirtualFixedIPs\u0027,"},{"line_number":688,"context_line":"                                    [{\u0027ip_address\u0027: c_ip}])"},{"line_number":689,"context_line":"        ovn_dbs_vip \u003d user_params.get(\u0027OVNDBsVirtualFixedIPs\u0027,"},{"line_number":690,"context_line":"                                      [{\u0027ip_address\u0027: c_ip}])"},{"line_number":691,"context_line":"        tmp_env.update("},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027RedisVirtualFixedIPs\u0027: redis_vip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c22d80f_82c2c024","line":690,"updated":"2021-03-25 00:43:53.000000000","message":"does this work if redis and ovn are actually deployed? I\u0027m not sure they are in the CI coverage on this patch. Don\u0027t you need a use_neutron:False here?","commit_id":"667dc85d1b3aa7462e9ac145a48c17ae5f907ecd"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"e13734d85aa762a0c36544d0ef99c88c80163907","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        redis_vip \u003d user_params.get(\u0027RedisVirtualFixedIPs\u0027,"},{"line_number":688,"context_line":"                                    [{\u0027ip_address\u0027: c_ip}])"},{"line_number":689,"context_line":"        ovn_dbs_vip \u003d user_params.get(\u0027OVNDBsVirtualFixedIPs\u0027,"},{"line_number":690,"context_line":"                                      [{\u0027ip_address\u0027: c_ip}])"},{"line_number":691,"context_line":"        tmp_env.update("},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027RedisVirtualFixedIPs\u0027: redis_vip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5c2748d_46d08242","line":690,"in_reply_to":"8247399d_38064467","updated":"2021-03-25 17:59:27.000000000","message":"I don\u0027t think we should attempt to connect to Keystone or Neutron for the standalone install.\n\nWorse case scenario, we end up talking to Keystone of the standalone environment we already have deployed.","commit_id":"667dc85d1b3aa7462e9ac145a48c17ae5f907ecd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"dc2efc9d86116d7f5e570eae5adebedbe569a836","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        redis_vip \u003d user_params.get(\u0027RedisVirtualFixedIPs\u0027,"},{"line_number":688,"context_line":"                                    [{\u0027ip_address\u0027: c_ip}])"},{"line_number":689,"context_line":"        ovn_dbs_vip \u003d user_params.get(\u0027OVNDBsVirtualFixedIPs\u0027,"},{"line_number":690,"context_line":"                                      [{\u0027ip_address\u0027: c_ip}])"},{"line_number":691,"context_line":"        tmp_env.update("},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027RedisVirtualFixedIPs\u0027: redis_vip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8247399d_38064467","line":690,"in_reply_to":"9c22d80f_82c2c024","updated":"2021-03-25 11:21:05.000000000","message":"The ansible module will try to connect to neutron, when the endpoint isn\u0027t there it falls back to validates that an IP address was provided in FixedIPs and uses that if that is the case.\nThis patch is required for tripleo-ci-centos-8-scenario001-standalone to pass on [1], see log [2] on that patch.\n\n\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/777259 \n[2] https://d08e901b1365b4f966ba-c2c178731190b96d718ae1e4710dfab3.ssl.cf1.rackcdn.com/777259/8/check/tripleo-ci-centos-8-scenario001-standalone/3820fb1/logs/undercloud/home/zuul/standalone-ansible-u54wx6gd/service_vip_vars.yaml","commit_id":"667dc85d1b3aa7462e9ac145a48c17ae5f907ecd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"61a503f5b741a99f4c259f6d0a573c99797aa9ba","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        redis_vip \u003d user_params.get(\u0027RedisVirtualFixedIPs\u0027,"},{"line_number":688,"context_line":"                                    [{\u0027ip_address\u0027: c_ip}])"},{"line_number":689,"context_line":"        ovn_dbs_vip \u003d user_params.get(\u0027OVNDBsVirtualFixedIPs\u0027,"},{"line_number":690,"context_line":"                                      [{\u0027ip_address\u0027: c_ip}])"},{"line_number":691,"context_line":"        tmp_env.update("},{"line_number":692,"context_line":"            {"},{"line_number":693,"context_line":"                \u0027RedisVirtualFixedIPs\u0027: redis_vip,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fef5ef1_0c71ff44","line":690,"in_reply_to":"a5c2748d_46d08242","updated":"2021-03-25 22:12:43.000000000","message":"Ok, I\u0027ve updated this to use the \u0027use_neutron\u0027: False.\n\nWe need to merge https://review.opendev.org/c/openstack/tripleo-ansible/+/779883 first, it\u0027s in the gate atm.","commit_id":"667dc85d1b3aa7462e9ac145a48c17ae5f907ecd"}]}