)]}'
{"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"d3390dc3a062dc5fb08aae566dcbb89816b09008","unresolved":true,"context_lines":[{"line_number":426,"context_line":"            # Set Field name by getting the result dict keys"},{"line_number":427,"context_line":"            t.field_names \u003d results[0].keys()"},{"line_number":428,"context_line":"            t.align \u003d \u0027l\u0027"},{"line_number":429,"context_line":"            is_failed_validation \u003d False"},{"line_number":430,"context_line":"            for r in results:"},{"line_number":431,"context_line":"                if r.get(\u0027Status_by_Host\u0027):"},{"line_number":432,"context_line":"                    h \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"466e9050_0582251e","line":429,"updated":"2021-03-26 14:48:11.000000000","message":"Hate to nitpick var names, but wouldn\u0027t `validation_failed` work better?","commit_id":"a5471a4af3b02c055c6b22e2ae022140e4dd05ec"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"696d7f6702d39ac24f49b529fbd6e2185eb53f8c","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            # Set Field name by getting the result dict keys"},{"line_number":427,"context_line":"            t.field_names \u003d results[0].keys()"},{"line_number":428,"context_line":"            t.align \u003d \u0027l\u0027"},{"line_number":429,"context_line":"            is_failed_validation \u003d False"},{"line_number":430,"context_line":"            for r in results:"},{"line_number":431,"context_line":"                if r.get(\u0027Status_by_Host\u0027):"},{"line_number":432,"context_line":"                    h \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"38fa2f7b_558ed02a","line":429,"in_reply_to":"466e9050_0582251e","updated":"2021-03-26 14:50:34.000000000","message":"Done","commit_id":"a5471a4af3b02c055c6b22e2ae022140e4dd05ec"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"d3390dc3a062dc5fb08aae566dcbb89816b09008","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            oooutils.cleanup_tripleo_ansible_inventory_file("},{"line_number":455,"context_line":"                static_inventory)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if is_failed_validation:"},{"line_number":458,"context_line":"            raise exceptions.CommandError("},{"line_number":459,"context_line":"                _(\"One or more validations have failed.\"))"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cf1bff2f_e74b29d9","line":457,"updated":"2021-03-26 14:48:11.000000000","message":"We could make the condition on any() and evaluate once here. Get rid of the flag.\nFor example:\nany(element[\u0027status\u0027] \u003d\u003d \u0027FAILED\u0027 for element in results)","commit_id":"a5471a4af3b02c055c6b22e2ae022140e4dd05ec"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"696d7f6702d39ac24f49b529fbd6e2185eb53f8c","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            oooutils.cleanup_tripleo_ansible_inventory_file("},{"line_number":455,"context_line":"                static_inventory)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if is_failed_validation:"},{"line_number":458,"context_line":"            raise exceptions.CommandError("},{"line_number":459,"context_line":"                _(\"One or more validations have failed.\"))"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"427bb5ca_c1e74bab","line":457,"in_reply_to":"cf1bff2f_e74b29d9","updated":"2021-03-26 14:50:34.000000000","message":"Done","commit_id":"a5471a4af3b02c055c6b22e2ae022140e4dd05ec"}]}