)]}'
{"tripleoclient/v1/undercloud_preflight.py":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"46e94035b044806570a6bb4db86610d7a0162d56","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"},{"line_number":101,"context_line":"        actions.run_validations("}],"source_content_type":"text/x-python","patch_set":2,"id":"d288777e_86f6b1cf","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":47},"updated":"2021-04-12 06:36:35.000000000","message":"Just wondering, if we need this comment for train cherry pick as well.\n\n* https://review.opendev.org/753845 merged for master\n* During my checks i don\u0027t find this patch was backported to train. Infact, I don\u0027t find stable/train branch for validations-libs.","commit_id":"33f3de074d7a6d3c6004e7b8b96b91d441c6047d"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"c12b2c3d8a3cfed9730fd8f2928e4c582420256e","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"},{"line_number":101,"context_line":"        actions.run_validations("}],"source_content_type":"text/x-python","patch_set":2,"id":"ebdc90d2_a2d249f0","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":47},"in_reply_to":"d288777e_86f6b1cf","updated":"2021-04-12 06:46:38.000000000","message":"validations-libs is branchless, but instead of modifying a cherry pic, I did a follow up patch. for this:\nhttps://review.opendev.org/c/openstack/python-tripleoclient/+/785819","commit_id":"33f3de074d7a6d3c6004e7b8b96b91d441c6047d"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a56d272801b585f482e957dbd31503b97adbb1d6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"},{"line_number":101,"context_line":"        actions.run_validations("}],"source_content_type":"text/x-python","patch_set":2,"id":"cc204388_49657cf9","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":47},"in_reply_to":"ebdc90d2_a2d249f0","updated":"2021-04-12 07:00:14.000000000","message":"Thanks Matbu.","commit_id":"33f3de074d7a6d3c6004e7b8b96b91d441c6047d"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"a6d60d399d36637d2dcfc69a03054fecb2b2269b","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"35caef3e_1ac68467","line":97,"updated":"2021-04-15 10:34:11.000000000","message":"That patch is merged - what\u0027s the story with modifying?  Does it apply to this backport or should we get this merged then update from master?","commit_id":"429169bde6975afd9606b2d410d81e6f32ba2a31"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"474678b3e8e109313de0760020f4d49f2221b55f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"e6db7f99_4a34f065","line":97,"in_reply_to":"1f9a04e1_80815c39","updated":"2021-04-20 12:38:40.000000000","message":"I did the clean up here coming from master:\nhttps://review.opendev.org/c/openstack/python-tripleoclient/+/785819\n\nCleaner imho than modifying a cherry pick.","commit_id":"429169bde6975afd9606b2d410d81e6f32ba2a31"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"71337821b2f8a8a3efce21d569b7f7e692ea3d26","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9a04e1_80815c39","line":97,"in_reply_to":"35caef3e_1ac68467","updated":"2021-04-20 07:48:24.000000000","message":"looks like that came with the original code from the master patch https://review.opendev.org/c/openstack/python-tripleoclient/+/753709/4/tripleoclient/v1/undercloud_preflight.py#98\n\nyou could remove it here but it would also need to be removed on master and elsewhere...\n\nbut what does the comment mean exactly? remove what?","commit_id":"429169bde6975afd9606b2d410d81e6f32ba2a31"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d1bc9e214c639a3ab3c2e6e587b159f26f27f937","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        playbook \u003d \u0027undercloud-disk-space.yaml\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    with utils.TempDirs() as tmp:"},{"line_number":97,"context_line":"        # @matbu: todo: removed this when [1] will be merged"},{"line_number":98,"context_line":"        # [1] https://review.opendev.org/753845"},{"line_number":99,"context_line":"        v_consts.VALIDATION_ANSIBLE_ARTIFACT_PATH \u003d \"{}/artifacts\".format(tmp)"},{"line_number":100,"context_line":"        actions \u003d ValidationActions()"}],"source_content_type":"text/x-python","patch_set":4,"id":"b81921ff_b39d4514","line":97,"in_reply_to":"e6db7f99_4a34f065","updated":"2021-04-21 07:38:04.000000000","message":"Ack","commit_id":"429169bde6975afd9606b2d410d81e6f32ba2a31"}]}