)]}'
{"tripleoclient/v1/overcloud_deploy.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2b0480617e838ed5de32662b55cba4096a3e0475","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"1c03f96f_ed1f6832","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"updated":"2021-05-26 14:26:39.000000000","message":"If we\u0027re not going to deploy the stack  with --config-download-only or --setup-only, why\u0027re we building the environments? I had the impression that --setup-only does not deploy the stack (does everything not done by --stack-only till the config has been downloaded for the playbooks to run). Anyway I don\u0027t see why we should build the environments if we don\u0027t deploy the stack.\n\n\nBut I\u0027m confused now after looking at the commit that added --setup-only[1] which actually deploys the stack.\n\n[1] https://github.com/openstack/python-tripleoclient/commit/be580c669065c59789601f28bfbaee8318e67c0d","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"87e5bf1d00c8bf92ecf2db1015158237aad20acd","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"e4c52565_a3b58457","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"in_reply_to":"1c03f96f_ed1f6832","updated":"2021-05-26 15:37:46.000000000","message":"aiui, --setup-only means the stack and setup, as the stack is necessary since the outputs (config-download and node ip\u0027s) are needed for the setup\n\n--stack-only means only the stack, with no setup\n\n--config-download-only means only config-download (effectively ansible-playbook ...).\n\ni agree this probably needs some refinement. All I\u0027m doing in this patch is attempting to restore the existing behavior. As thing stand without this patch, --setup-only does not work.","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"012b79bd48e41138994a05b8cfa138910c8a3b36","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"79b617b1_256ac19f","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"in_reply_to":"5bb97794_70308cc0","updated":"2021-05-27 08:15:34.000000000","message":"Each time I try to recall and understand the uses of --setup-only/--config-download-only/--stack-only combos, I found this highly confusing to figure out. May be we should drop all extra options but for the main one, for the master branch, and leave \"compatibility\" modes for stable branches.","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ca936a6dbb8a65df486eb1756b4dcc3c9d203860","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"7acad581_8da61544","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"in_reply_to":"79b617b1_256ac19f","updated":"2021-05-27 11:22:44.000000000","message":"i\u0027ll test it to see if it wfm. in the meantime, I will W-1 this one so we can find the right solution. I agree it\u0027s confusing as-is.\n\n--setup-only does require a db backup to be restored, it would never work with no stack deployed, even with installed Heat. But, I don\u0027t like that model. I guess I\u0027d like to see us save the Heat stack outputs somewhere, or provide a different way to specify the node IP\u0027s if we are going to continue to support it.","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0a0fa0eac22a3a5c8a6fe52a6a1ee2665c87709d","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"5bb97794_70308cc0","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"in_reply_to":"957beee0_90045d5c","updated":"2021-05-27 07:08:26.000000000","message":"Hmm.. it seems with --setup-only/--config-download-only we need to start the ephemeral heat and hence need the heat container image from the merged environments. This makes the installed heat option very inefficient. Though it may be probably ok as we\u0027re moving to ephemeral heat as the default in the next patch.\n\nHowever, --setup-only does not work for me. I pulled down the series and tested.\n\nWhen --setup-only used with a fresh deployment it fails with:\n\n2021-05-27 04:13:30.791 142372 ERROR openstack [-] No db backups found to restore in /home/stack/overcloud-deploy/overcloud-0/heat-launcher: Exception: No db backups found to restore in /home/stack/overcloud-deploy/overcloud-0/heat-launcher\n\nLooks like a bug in https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/heat_launcher.py#L506 (looking the wrong location), but not sure why it should look for a backup for a fresh deployment with --setup-only.\n\n\nIt also does not also work when I ran --setup-only after --stack-only ( does not deploy stack and then fails to fetch the stack from backup)\n\n2021-05-27 06:56:57.874 379689 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud   File \"/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_deploy.py\", line 1277, in take_action\n2021-05-27 06:56:57.874 379689 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud     raise(deploy_trace)\n2021-05-27 06:56:57.874 379689 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud   File \"/usr/lib/python3.6/site-packages/tripleoclient/v1/overcloud_deploy.py\", line 1079, in take_action\n2021-05-27 06:56:57.874 379689 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud     stack.get()\n2021-05-27 06:56:57.874 379689 ERROR tripleoclient.v1.overcloud_deploy.DeployOvercloud AttributeError: \u0027NoneType\u0027 object has no attribute \u0027get\u0027\n\nIf it works for you, feel free to merge.","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8342d3f2fea17d9f4291f0405ea6aef90be038b6","unresolved":true,"context_lines":[{"line_number":354,"context_line":"        if parsed_args.heat_type !\u003d \u0027installed\u0027:"},{"line_number":355,"context_line":"            self.setup_ephemeral_heat("},{"line_number":356,"context_line":"                parsed_args, env.get(\u0027parameter_defaults\u0027))"},{"line_number":357,"context_line":"        if parsed_args.setup_only or parsed_args.config_download_only:"},{"line_number":358,"context_line":"            return"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Copy the env_files to tmp folder for archiving"}],"source_content_type":"text/x-python","patch_set":16,"id":"957beee0_90045d5c","line":357,"range":{"start_line":357,"start_character":11,"end_line":357,"end_character":33},"in_reply_to":"e4c52565_a3b58457","updated":"2021-05-26 16:09:41.000000000","message":"Does --setup-only deploy the stack with this change? I can\u0027t see how it would as we return from here and don\u0027t call _try_overcloud_deploy_with_compat_yaml()/heat_deploy() for both ephemeral and installed heat. setup_ephemeral_heat() starts the service containers and initializes the client, but won\u0027t deploy the stack.","commit_id":"0ed188c31d392dca106aef6663b2e9c02ceebd77"}]}