)]}'
{"tripleoclient/tests/v1/overcloud_backup/test_backup.py":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"20aafc18b020592e7a96b51af60fd377887ea14a","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch(\u0027tripleoclient.utils.run_ansible_playbook\u0027,"},{"line_number":306,"context_line":"                autospec\u003dTrue)"},{"line_number":307,"context_line":"    def test_overcloud_backup_no_inventory(self, mock_playbook):"},{"line_number":308,"context_line":"        arglist \u003d ["},{"line_number":309,"context_line":"            \u0027--inventory\u0027,"},{"line_number":310,"context_line":"            \u0027/tmp/no_inventory.yaml\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c39d6ba_0b7eedef","line":307,"range":{"start_line":307,"start_character":8,"end_line":307,"end_character":42},"updated":"2021-05-25 14:30:56.000000000","message":"and maybe a mock stating the file exists, but isn\u0027t readable?","commit_id":"cd0e1c063c4f3460b1301caa17146fed48cad5df"}],"tripleoclient/tests/v1/undercloud/test_backup.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0b206b1c63a099e34a4648ee1e02a6196e06cf80","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        ]"},{"line_number":363,"context_line":"        verifylist \u003d []"},{"line_number":364,"context_line":"        with mock.patch(\"os.path.isfile\") as mock_isfile:"},{"line_number":365,"context_line":"            mock_isfile.return_value \u003d True"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2dd7a876_ed6c6bd9","line":365,"range":{"start_line":365,"start_character":39,"end_line":365,"end_character":43},"updated":"2021-05-24 07:54:02.000000000","message":"i expected to see at least one of those false but I didn\u0027t find it ;)  i.e. we aren\u0027t testing the thing you are adding here which is to raise the RuntimeError","commit_id":"6bceb705015eff3c327a7272311d51db86590483"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"c938f0dd3cd67227e2bdba3dd46d7d89eca45e15","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        ]"},{"line_number":363,"context_line":"        verifylist \u003d []"},{"line_number":364,"context_line":"        with mock.patch(\"os.path.isfile\") as mock_isfile:"},{"line_number":365,"context_line":"            mock_isfile.return_value \u003d True"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1c2020b2_0cbe3c5c","line":365,"range":{"start_line":365,"start_character":39,"end_line":365,"end_character":43},"in_reply_to":"2dd7a876_ed6c6bd9","updated":"2021-05-24 13:00:49.000000000","message":"Done","commit_id":"6bceb705015eff3c327a7272311d51db86590483"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"20aafc18b020592e7a96b51af60fd377887ea14a","unresolved":true,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @mock.patch(\u0027tripleoclient.utils.run_ansible_playbook\u0027,"},{"line_number":410,"context_line":"                autospec\u003dTrue)"},{"line_number":411,"context_line":"    def test_undercloud_backup_no_inventory(self, mock_playbook):"},{"line_number":412,"context_line":"        arglist \u003d ["},{"line_number":413,"context_line":"            \u0027--inventory\u0027,"},{"line_number":414,"context_line":"            \u0027/tmp/no_inventory.yaml\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"07498849_64f3c992","line":411,"updated":"2021-05-25 14:30:56.000000000","message":"and maybe a mock stating the file exists, but isn\u0027t readable?","commit_id":"cd0e1c063c4f3460b1301caa17146fed48cad5df"}],"tripleoclient/v1/overcloud_backup.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"53f79c081d0c5085985b1512f5825413456ae405","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if not os.path.isfile(parsed_args.inventory):"},{"line_number":141,"context_line":"            raise RuntimeError("},{"line_number":142,"context_line":"               _(\u0027The inventory file {} does not exit\u0027.format("},{"line_number":143,"context_line":"                   parsed_args.inventory)))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if parsed_args.setup_nfs is True or parsed_args.init \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5753431_ccc5fe56","line":142,"range":{"start_line":142,"start_character":49,"end_line":142,"end_character":53},"updated":"2021-05-25 07:49:02.000000000","message":"exist","commit_id":"9a1902745928a5f84d02076d8bbf82fe42bd1807"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8457f73d6dc805e5bae7d20fc3ba5d33b211adbd","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                \u0027tripleo_backup_and_restore_nfs_server\u0027"},{"line_number":138,"context_line":"            ] \u003d storage_ip"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        if not os.path.isfile(parsed_args.inventory):"},{"line_number":141,"context_line":"            raise RuntimeError("},{"line_number":142,"context_line":"               _(\u0027The inventory file {} does not exist\u0027.format("},{"line_number":143,"context_line":"                   parsed_args.inventory)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"2de2679b_a9652010","line":140,"updated":"2021-05-25 08:59:10.000000000","message":"Do we want to ensure this file is readable? Might be worth a check as well imho,","commit_id":"f12614e60e8ce94311b0e65bc941893188c6d341"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"20aafc18b020592e7a96b51af60fd377887ea14a","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        if not (os.path.isfile(parsed_args.inventory) and"},{"line_number":141,"context_line":"                os.access(parsed_args.inventory, os.R_OK)):"},{"line_number":142,"context_line":"            raise RuntimeError("},{"line_number":143,"context_line":"               _(\u0027The inventory file {} does not exist\u0027.format("},{"line_number":144,"context_line":"                   parsed_args.inventory)))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if parsed_args.setup_nfs is True or parsed_args.init \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae8b7d5b_43f6e2f8","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":5},"updated":"2021-05-25 14:30:56.000000000","message":"\"or is not readable\" - that would help","commit_id":"cd0e1c063c4f3460b1301caa17146fed48cad5df"}],"tripleoclient/v1/undercloud_backup.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"53f79c081d0c5085985b1512f5825413456ae405","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if not os.path.isfile(parsed_args.inventory):"},{"line_number":159,"context_line":"            raise RuntimeError("},{"line_number":160,"context_line":"               _(\u0027The inventory file {} does not exit\u0027.format("},{"line_number":161,"context_line":"                  parsed_args.inventory)))"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if parsed_args.setup_nfs is True or parsed_args.init \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"61b68061_c347b825","line":160,"range":{"start_line":160,"start_character":49,"end_line":160,"end_character":53},"updated":"2021-05-25 07:49:02.000000000","message":"same","commit_id":"9a1902745928a5f84d02076d8bbf82fe42bd1807"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"8457f73d6dc805e5bae7d20fc3ba5d33b211adbd","unresolved":true,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        extra_vars \u003d self._parse_extra_vars(parsed_args.extra_vars)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if not os.path.isfile(parsed_args.inventory):"},{"line_number":159,"context_line":"            raise RuntimeError("},{"line_number":160,"context_line":"               _(\u0027The inventory file {} does not exist\u0027.format("},{"line_number":161,"context_line":"                  parsed_args.inventory)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"e269bc03_53672a50","line":158,"updated":"2021-05-25 08:59:10.000000000","message":"Same here - might be worth ensuring we can read the file as well","commit_id":"f12614e60e8ce94311b0e65bc941893188c6d341"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"20aafc18b020592e7a96b51af60fd377887ea14a","unresolved":true,"context_lines":[{"line_number":158,"context_line":"        if not (os.path.isfile(parsed_args.inventory) and"},{"line_number":159,"context_line":"                os.access(parsed_args.inventory, os.R_OK)):"},{"line_number":160,"context_line":"            raise RuntimeError("},{"line_number":161,"context_line":"               _(\u0027The inventory file {} does not exist\u0027.format("},{"line_number":162,"context_line":"                  parsed_args.inventory)))"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if parsed_args.setup_nfs is True or parsed_args.init \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6d40b090_ea68606a","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":5},"updated":"2021-05-25 14:30:56.000000000","message":"\"or is not readable\" I guess? 😊","commit_id":"cd0e1c063c4f3460b1301caa17146fed48cad5df"}]}