)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428073a749743bad8deaa9b8f2076e00ea406d11","unresolved":true,"context_lines":[{"line_number":24,"context_line":"The correct fix for the case where the stack may have been modified out"},{"line_number":25,"context_line":"of order is to require another run of update prepare which will"},{"line_number":26,"context_line":"regenerate the playbooks."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Ib01d920112f5e84190fbcd9470dd7bac269b3987"},{"line_number":29,"context_line":"Signed-off-by: James Slagle \u003cjslagle@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bddc7f60_b905e6cb","line":27,"updated":"2021-05-24 07:31:05.000000000","message":"thanks for the explanation","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"}],"tripleoclient/v1/overcloud_external_update.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"106c27e9693a6564b390422a0e5d0e42bc2e7317","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--refresh\u0027,"},{"line_number":121,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":122,"context_line":"            help\u003d_(\u0027Refresh the config-download playbooks\u0027)"},{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3432982_6c5d0f18","line":122,"range":{"start_line":122,"start_character":55,"end_line":122,"end_character":57},"updated":"2021-05-25 08:00:28.000000000","message":"\u0027This is not valid if you are using ephemeral heat\u0027 or somesuch would be good to add to the help text.","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428073a749743bad8deaa9b8f2076e00ea406d11","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    constants.UPDATE_PROMPT, self.log)):"},{"line_number":136,"context_line":"            raise OvercloudUpdateNotConfirmed(constants.UPDATE_NO)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if parsed_args.refresh:"},{"line_number":139,"context_line":"            _, ansible_dir \u003d self.get_ansible_key_and_dir("},{"line_number":140,"context_line":"                no_workflow\u003dTrue,"},{"line_number":141,"context_line":"                stack\u003dparsed_args.stack,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3523630_b54a99ae","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":30},"updated":"2021-05-24 07:31:05.000000000","message":"do we need to guard this for ephemeral heat? Or do you just let it try to talk to heat and fail there. \n\ni.e. as you mentioned in the commit ephemeral heat and --refresh is not currently supported.","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"106c27e9693a6564b390422a0e5d0e42bc2e7317","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    constants.UPDATE_PROMPT, self.log)):"},{"line_number":136,"context_line":"            raise OvercloudUpdateNotConfirmed(constants.UPDATE_NO)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if parsed_args.refresh:"},{"line_number":139,"context_line":"            _, ansible_dir \u003d self.get_ansible_key_and_dir("},{"line_number":140,"context_line":"                no_workflow\u003dTrue,"},{"line_number":141,"context_line":"                stack\u003dparsed_args.stack,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ca05ab9_9e54c132","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":30},"in_reply_to":"72018b90_226616f6","updated":"2021-05-25 08:00:28.000000000","message":"hmm i see ... is there nothing we can check? I mean you could try and query the heat api and if it is missing then we assume ephemeral heat.\n\nI\u0027m OK to leave it as it is, possibly trying to add some more info in the helptext. \n\nIf someone tries to use --refresh with an ephemeral heat setup it will just fail. My concern is it may not be apparent why if you aren\u0027t familiar with the details about installed vs ephemeral. However I am also not sold on (my) idea of adding some check here that will try to query heat it sounds messy...","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"cbeeb83de3bc41d7e0a9f957b381bfa990940ba6","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    constants.UPDATE_PROMPT, self.log)):"},{"line_number":136,"context_line":"            raise OvercloudUpdateNotConfirmed(constants.UPDATE_NO)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if parsed_args.refresh:"},{"line_number":139,"context_line":"            _, ansible_dir \u003d self.get_ansible_key_and_dir("},{"line_number":140,"context_line":"                no_workflow\u003dTrue,"},{"line_number":141,"context_line":"                stack\u003dparsed_args.stack,"}],"source_content_type":"text/x-python","patch_set":2,"id":"72018b90_226616f6","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":30},"in_reply_to":"f3523630_b54a99ae","updated":"2021-05-24 16:59:35.000000000","message":"there\u0027s no ephemeral heat check for this command, as there\u0027s no option. i could change the option name to be --heat-type to match overcloud deploy, and then use that. would you like to see that?","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"428073a749743bad8deaa9b8f2076e00ea406d11","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                ),"},{"line_number":168,"context_line":"                forks\u003dparsed_args.ansible_forks"},{"line_number":169,"context_line":"            )"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            working_dir \u003d oooutils.get_default_working_dir(parsed_args.stack)"},{"line_number":172,"context_line":"            config_download_dir \u003d os.path.join(working_dir, \u0027config-download\u0027)"},{"line_number":173,"context_line":"            ansible_dir \u003d os.path.join(config_download_dir, parsed_args.stack)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d07d85e3_9fef32d8","line":170,"updated":"2021-05-24 07:31:05.000000000","message":"would be nice if we had at least one comment here as it is not be obvious to someone looking at the code. the if refresh implies we are using installed heat and the else is for ephemeral heat","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"106c27e9693a6564b390422a0e5d0e42bc2e7317","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                ),"},{"line_number":168,"context_line":"                forks\u003dparsed_args.ansible_forks"},{"line_number":169,"context_line":"            )"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            working_dir \u003d oooutils.get_default_working_dir(parsed_args.stack)"},{"line_number":172,"context_line":"            config_download_dir \u003d os.path.join(working_dir, \u0027config-download\u0027)"},{"line_number":173,"context_line":"            ansible_dir \u003d os.path.join(config_download_dir, parsed_args.stack)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bfbb2d3_3d43b763","line":170,"in_reply_to":"bcc5cb8e_45d5e5fe","updated":"2021-05-25 08:00:28.000000000","message":"not sure about that. --refresh tells us what the intent of the parameter is whereas if you name it \u0027--heat-type\u0027 then using heat-type \u0027installed\u0027 implies --refresh? as commented above I think it is OK to leave as it is.","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"cbeeb83de3bc41d7e0a9f957b381bfa990940ba6","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                ),"},{"line_number":168,"context_line":"                forks\u003dparsed_args.ansible_forks"},{"line_number":169,"context_line":"            )"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            working_dir \u003d oooutils.get_default_working_dir(parsed_args.stack)"},{"line_number":172,"context_line":"            config_download_dir \u003d os.path.join(working_dir, \u0027config-download\u0027)"},{"line_number":173,"context_line":"            ansible_dir \u003d os.path.join(config_download_dir, parsed_args.stack)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcc5cb8e_45d5e5fe","line":170,"in_reply_to":"d07d85e3_9fef32d8","updated":"2021-05-24 16:59:35.000000000","message":"let me know your thoughts on the above, and i\u0027ll add it if another change is needed.","commit_id":"76c95906368af3445b6dd789617c9caa5cfbe118"}]}