)]}'
{"tripleoclient/v1/tripleo_validator.py":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"aa330d97d89b25b25320c9fb0c2bac33188005af","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        return parser"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TripleOValidatorShowHistory(ListHistory):"},{"line_number":88,"context_line":"    \"\"\"Display Validations execution history\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    auth_required \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e20f0ff_73ec8df2","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":33},"updated":"2021-06-04 10:04:24.000000000","message":"You need to add the option here too","commit_id":"6c250b4934c708932a6cc819529a59af64df80b5"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"b40f4abd2c005eeb1e3272ec57dd40e8ecd9503f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return parser"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TripleOValidatorShowHistory(ListHistory):"},{"line_number":88,"context_line":"    \"\"\"Display Validations execution history\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    auth_required \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac560a5_11ce46fd","line":87,"range":{"start_line":87,"start_character":6,"end_line":87,"end_character":33},"in_reply_to":"7e20f0ff_73ec8df2","updated":"2021-06-04 12:14:13.000000000","message":"Done","commit_id":"6c250b4934c708932a6cc819529a59af64df80b5"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"aa330d97d89b25b25320c9fb0c2bac33188005af","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        return parser"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class TripleOValidatorShowRun(GetHistory):"},{"line_number":98,"context_line":"    \"\"\"Display details about a Validation execution\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    auth_required \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"f68bf771_459374cc","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":29},"updated":"2021-06-04 10:04:24.000000000","message":"and here too","commit_id":"6c250b4934c708932a6cc819529a59af64df80b5"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"b40f4abd2c005eeb1e3272ec57dd40e8ecd9503f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        return parser"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class TripleOValidatorShowRun(GetHistory):"},{"line_number":98,"context_line":"    \"\"\"Display details about a Validation execution\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    auth_required \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"19fe9538_b3531a09","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":29},"in_reply_to":"f68bf771_459374cc","updated":"2021-06-04 12:14:13.000000000","message":"Done","commit_id":"6c250b4934c708932a6cc819529a59af64df80b5"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"fdd3c78a2ea7dd133e3010b1c5c4566f55f22cdc","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        parser \u003d super(TripleOValidatorRun, self).get_parser(parser)"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":79,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":80,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":81,"context_line":"            help\u003d("},{"line_number":82,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5445dc19_a78a03e9","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":28},"updated":"2021-06-09 15:21:57.000000000","message":"can you update the dest name according to the other params:\nvalidation_log_dir","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"927264c404992945d9010e2f96886e9ee2728f2c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        parser \u003d super(TripleOValidatorRun, self).get_parser(parser)"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":79,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":80,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":81,"context_line":"            help\u003d("},{"line_number":82,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3b4c05a_d63d9f07","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":28},"in_reply_to":"5445dc19_a78a03e9","updated":"2021-06-10 06:14:51.000000000","message":"Done","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"fdd3c78a2ea7dd133e3010b1c5c4566f55f22cdc","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        parser \u003d super(TripleOValidatorShowHistory, self).get_parser(parser)"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":96,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":97,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":98,"context_line":"            help\u003d("},{"line_number":99,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"05fe14e7_1a65f6b0","line":96,"updated":"2021-06-09 15:21:57.000000000","message":"same here","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"927264c404992945d9010e2f96886e9ee2728f2c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parser \u003d super(TripleOValidatorShowHistory, self).get_parser(parser)"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":96,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":97,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":98,"context_line":"            help\u003d("},{"line_number":99,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"c203fb54_a22decec","line":96,"in_reply_to":"05fe14e7_1a65f6b0","updated":"2021-06-10 06:14:51.000000000","message":"Done","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"fdd3c78a2ea7dd133e3010b1c5c4566f55f22cdc","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":115,"context_line":"            help\u003d("},{"line_number":116,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"21276720_e5efc475","line":113,"updated":"2021-06-09 15:21:57.000000000","message":"same here","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"927264c404992945d9010e2f96886e9ee2728f2c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027log_path\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"},{"line_number":115,"context_line":"            help\u003d("},{"line_number":116,"context_line":"                \"Path where the log files and artifacts will be located. \"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"8f82c7c5_e4e02403","line":113,"in_reply_to":"21276720_e5efc475","updated":"2021-06-10 06:14:51.000000000","message":"Done","commit_id":"8aad06fde29b14d950982013a1850f49f2f93604"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"258f3bea67d06abcaa406e06e150cbd0fc5119cb","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_parser(self, parser):"},{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027validation_log_dir\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3bb53f2d_7a7387da","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":25},"updated":"2021-08-04 07:28:27.000000000","message":"repetition isn\u0027t very cool though\n\nis there no shared parent class it can go into instead?","commit_id":"ff91bea4d320d059a024ea7f588d0bd6eb1d76d9"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"d896fba2527e7ae524b5a400936e9dd7eaf10136","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_parser(self, parser):"},{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027validation_log_dir\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"}],"source_content_type":"text/x-python","patch_set":10,"id":"421635c1_8f33d48a","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":25},"in_reply_to":"3bb53f2d_7a7387da","updated":"2021-08-04 08:23:26.000000000","message":"We were discussing ways to handle this problem some time ago, two moths ago I think. \nOne of those was to refactor the inheritance graph of the CLI so we can loose some of these redundancies. \n\nEventually we decided for a different approach. Which required merging patch in the cliff itself to work. \n\nNow, there is still a way to get rid of the repetitions, as they are also in the VL.\nBut it wouldn\u0027t be easy to reach some sort of consensus on how it is supposed to look.","commit_id":"ff91bea4d320d059a024ea7f588d0bd6eb1d76d9"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"c12e468ebd2ac917597432d562a58669e22d9832","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_parser(self, parser):"},{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027validation_log_dir\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f67d25d6_c45c19a4","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":25},"in_reply_to":"421635c1_8f33d48a","updated":"2021-08-06 13:16:04.000000000","message":"Well actually you can just do like this instead:\ndefault \u003d {\u0027validation_log_dir\u0027:\u0027/var/log/validations\u0027}\nparser.set_defaults(**default)\n\nsed the hardcoded value by the constant 😊","commit_id":"ff91bea4d320d059a024ea7f588d0bd6eb1d76d9"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"72d60847fc712f65c2c2feedbd00fcae7bf3fdbb","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_parser(self, parser):"},{"line_number":110,"context_line":"        parser \u003d super(TripleOValidatorShowRun, self).get_parser(parser)"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--validation-log-dir\u0027,"},{"line_number":113,"context_line":"            dest\u003d\u0027validation_log_dir\u0027,"},{"line_number":114,"context_line":"            default\u003dconstants.VALIDATIONS_LOG_BASEDIR,"}],"source_content_type":"text/x-python","patch_set":10,"id":"2a1a8f79_2d1734f8","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":25},"in_reply_to":"f67d25d6_c45c19a4","updated":"2021-08-06 13:58:34.000000000","message":"Why did we have to change it in the cliff then?\nIf we could have just specified it here?","commit_id":"ff91bea4d320d059a024ea7f588d0bd6eb1d76d9"}]}