)]}'
{"tripleoclient/v1/overcloud_export.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6c36bdddbb1627cef8f4c428b0f479e8f84c9f1c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            heat.stacks.client.session.get_endpoint("},{"line_number":94,"context_line":"                service_type\u003d\u0027orchestration\u0027)"},{"line_number":95,"context_line":"        except EndpointNotFound:"},{"line_number":96,"context_line":"            self.log.error("},{"line_number":97,"context_line":"                \"Heat endpoint not found. When using ephemeral Heat, \""},{"line_number":98,"context_line":"                \"the export file exists in the stack working directory \""},{"line_number":99,"context_line":"                \"as $HOME/overlcoud-deploy/\u003cstack\u003e/\u003cstack\u003e-export.yaml. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"ddcd9214_98dad9b9","line":96,"updated":"2022-03-08 12:31:24.000000000","message":"if it logs an error, shouldn\u0027t it raise some exception?","commit_id":"15a1f7defe1875f7b05c5d06e2d79dc785527918"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bddd6775ee887d91e8bf1ed7fdd8da4aa336d21c","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            heat.stacks.client.session.get_endpoint("},{"line_number":94,"context_line":"                service_type\u003d\u0027orchestration\u0027)"},{"line_number":95,"context_line":"        except EndpointNotFound:"},{"line_number":96,"context_line":"            self.log.error("},{"line_number":97,"context_line":"                \"Heat endpoint not found. When using ephemeral Heat, \""},{"line_number":98,"context_line":"                \"the export file exists in the stack working directory \""},{"line_number":99,"context_line":"                \"as $HOME/overlcoud-deploy/\u003cstack\u003e/\u003cstack\u003e-export.yaml. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"75ee2cf3_7d99d9bf","line":96,"in_reply_to":"ddcd9214_98dad9b9","updated":"2022-03-08 20:42:32.000000000","message":"i\u0027ll change it to a warning, that was my original intent","commit_id":"15a1f7defe1875f7b05c5d06e2d79dc785527918"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6c36bdddbb1627cef8f4c428b0f479e8f84c9f1c","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                shutil.copy(export_file_path, output_file)"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                print(\"Export file not found at {}.\".format("},{"line_number":111,"context_line":"                    export_file_path))"},{"line_number":112,"context_line":"            return"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        data \u003d export.export_overcloud("}],"source_content_type":"text/x-python","patch_set":2,"id":"946cbfd7_8d6ab46c","line":111,"updated":"2022-03-08 12:31:24.000000000","message":"shouldn\u0027t it fail right here?","commit_id":"15a1f7defe1875f7b05c5d06e2d79dc785527918"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"bddd6775ee887d91e8bf1ed7fdd8da4aa336d21c","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                shutil.copy(export_file_path, output_file)"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                print(\"Export file not found at {}.\".format("},{"line_number":111,"context_line":"                    export_file_path))"},{"line_number":112,"context_line":"            return"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        data \u003d export.export_overcloud("}],"source_content_type":"text/x-python","patch_set":2,"id":"bcf56467_c86d33dc","line":111,"in_reply_to":"946cbfd7_8d6ab46c","updated":"2022-03-08 20:42:32.000000000","message":"well, i don\u0027t think it needs to fail, this is the end of this code path, the next statement is return. but I can exit 1","commit_id":"15a1f7defe1875f7b05c5d06e2d79dc785527918"}]}