)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"9297710b0e3258fb296b56a1f3fdb6b08d6363be","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Also contains I2ee5a5454ec1211b8c8aa1ec7f6e694995885882"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I8b0129e6b4b545f3e895470e9d2421291798ed32"},{"line_number":20,"context_line":"(cherry picked from commit 43af68d4fcc706a61070e1512eb7a9f9e9a83c69)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"83aa625b_86ade2e4","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":68},"updated":"2022-05-27 11:49:06.000000000","message":"Normally we add both squashed commits here.","commit_id":"b07a4e0d539b4d5069bd199600bf73700bb16c6c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4db672e6016c345dfce0826a15e4f9af44623af2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Also contains I2ee5a5454ec1211b8c8aa1ec7f6e694995885882"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I8b0129e6b4b545f3e895470e9d2421291798ed32"},{"line_number":20,"context_line":"(cherry picked from commit 43af68d4fcc706a61070e1512eb7a9f9e9a83c69)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9975ade7_c14f48c0","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"83aa625b_86ade2e4","updated":"2022-05-30 07:32:20.000000000","message":"+1 but I think lets just merge this now its been in review for a while","commit_id":"b07a4e0d539b4d5069bd199600bf73700bb16c6c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a3102ea6c8a673ccbc114d4bbd8aaec5dd8aecc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34676cf4_82ad14d8","updated":"2022-04-12 08:05:28.000000000","message":"Yeah, let\u0027s fix the help text nit on master,squash the patches that also includes https://github.com/openstack/python-tripleoclient/commit/719a26aaf1c59d0f407f8a9951950032e9d4cb33 and then backport.","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"877182eaa145c49baddefea374954c6047fc27ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4d2bfff_1c4a37a7","updated":"2022-04-12 07:27:12.000000000","message":"adding -1 for visibility on the \u0027delete\u0027 bit please check inline","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1a11fbfd0fd05c5f19d6187a3f502c8024a22604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a29a8db5_8f34eebe","updated":"2022-04-11 06:19:14.000000000","message":"i don\u0027t want to block but the \u0027delete\u0027 seems wrong and potentially confusing for users. if you prefer we can merge this and then you fix on master and cherrypick? or for some reason that really should be delete... ","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b4e17565a91fb2f1d2bca975e9f3c7990d2baccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5d5f503_f3a67635","updated":"2022-04-14 07:48:05.000000000","message":"k removing my -1 thanks for checking","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"39f025c3888e19e3b06b130039d0c261b10c30d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"19b0b58d_877a7c13","updated":"2022-04-04 10:15:26.000000000","message":"recheck","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"362c2cd0955afecbcf4919b1c250de63533fa411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9419e32f_96623372","updated":"2022-03-30 13:09:20.000000000","message":"recheck","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"e6322b7aa9c3e4227fedf1a870cb170fa2e61646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b3c2b07_9653812d","updated":"2022-03-31 07:36:58.000000000","message":"recheck","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"d465d5cce9289794ba93ba8222d9026e602d7362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c63775e5_5484ceac","in_reply_to":"34676cf4_82ad14d8","updated":"2022-04-20 07:58:19.000000000","message":"Thanks Rabi! Patch sent for master: https://review.opendev.org/c/openstack/python-tripleoclient/+/838652","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"aac4809b4fa2bad2d449208bfd37d36f9232b7c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6456b1e_f0e6e0e4","updated":"2022-05-27 08:40:58.000000000","message":"https://review.opendev.org/c/openstack/python-tripleoclient/+/841749 has an empty commit and you\u0027ve rebased this on top of that. You need to fix that.","commit_id":"98679c3cae144694cf5246956596d967c11145d6"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"7fa81eb173e0ad3e113b815b76d37b699f175b4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"866d523b_9f7ff442","updated":"2022-05-16 15:23:01.000000000","message":"recheck","commit_id":"98679c3cae144694cf5246956596d967c11145d6"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"4b5463c5069d8b67ca52a305df6e77d7e10f6eef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75538d0d_377eee83","in_reply_to":"a6456b1e_f0e6e0e4","updated":"2022-05-27 11:37:41.000000000","message":"Rebased to wallaby branch to break the relation chain, and squashed to include the changes of 841749 (reference in the commit message) as you suggested in your previous comment.","commit_id":"98679c3cae144694cf5246956596d967c11145d6"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"c5b2a8ae3fc37c4c735a655ced14a444c4b403cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"764537cc_97dbd62d","updated":"2022-05-31 07:54:32.000000000","message":"recheck","commit_id":"b07a4e0d539b4d5069bd199600bf73700bb16c6c"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"f217b62803c399baa876e8f4c4fc00b1881b184d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97257dd3_f7780f48","updated":"2022-05-30 21:38:31.000000000","message":"recheck","commit_id":"b07a4e0d539b4d5069bd199600bf73700bb16c6c"}],"tripleoclient/v1/overcloud_restore.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1a11fbfd0fd05c5f19d6187a3f502c8024a22604","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--inventory\u0027,"},{"line_number":44,"context_line":"            default\u003dINVENTORY,"},{"line_number":45,"context_line":"            help\u003d_(\"Tripleo inventory file generated with \""},{"line_number":46,"context_line":"                   \"tripleo-ansible-inventory command. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"666f393a_7f0121a8","side":"PARENT","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":15},"updated":"2022-04-11 06:19:14.000000000","message":"its a big breaking change e.g. anyone with tooling that expects to pass --inventory.\n\ni realise this is a cherrypick but worth a comment for future reference/for your consideration. It would have been better to try and keep some backwards compatibility\n\n[EDIT]: I see Rabi made the same comment on master but it was ignored","commit_id":"2909e0022279453798182012067aab8fb7209e25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b4e17565a91fb2f1d2bca975e9f3c7990d2baccb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--inventory\u0027,"},{"line_number":44,"context_line":"            default\u003dINVENTORY,"},{"line_number":45,"context_line":"            help\u003d_(\"Tripleo inventory file generated with \""},{"line_number":46,"context_line":"                   \"tripleo-ansible-inventory command. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"00ed5ce3_e553b8f7","side":"PARENT","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":15},"in_reply_to":"1baf20ca_d0f843b5","updated":"2022-04-14 07:48:05.000000000","message":"ok... so to be clear you need this to merge and then you\u0027ll merge https://review.opendev.org/c/openstack/python-tripleoclient/+/834474 to restore the backwards compatibility. Sounds fine, but can you please line them up so they are ready and it is clearer what you\u0027re going to do i.e. rebase python-tripleoclient/+/834474 onto this one and remove the WIP on it.","commit_id":"2909e0022279453798182012067aab8fb7209e25"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"aa775859da1bd1f03b31887ff27d7521fb0bf878","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--inventory\u0027,"},{"line_number":44,"context_line":"            default\u003dINVENTORY,"},{"line_number":45,"context_line":"            help\u003d_(\"Tripleo inventory file generated with \""},{"line_number":46,"context_line":"                   \"tripleo-ansible-inventory command. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1baf20ca_d0f843b5","side":"PARENT","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":15},"in_reply_to":"430799eb_ce708979","updated":"2022-04-12 08:19:20.000000000","message":"Here the link: https://review.opendev.org/c/openstack/python-tripleoclient/+/830321\nI create the cherry pick for it to merge to wallaby but I found conficts with this change, so I need to have this one merged before.","commit_id":"2909e0022279453798182012067aab8fb7209e25"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"3cb012386e78dace1866febe2c7d2daf32643006","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--inventory\u0027,"},{"line_number":44,"context_line":"            default\u003dINVENTORY,"},{"line_number":45,"context_line":"            help\u003d_(\"Tripleo inventory file generated with \""},{"line_number":46,"context_line":"                   \"tripleo-ansible-inventory command. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ddff55ca_264a3d10","side":"PARENT","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":15},"in_reply_to":"666f393a_7f0121a8","updated":"2022-04-11 09:10:57.000000000","message":"The patch 830321 adds again this parameter to maintain the backwards compatibility","commit_id":"2909e0022279453798182012067aab8fb7209e25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"877182eaa145c49baddefea374954c6047fc27ec","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--inventory\u0027,"},{"line_number":44,"context_line":"            default\u003dINVENTORY,"},{"line_number":45,"context_line":"            help\u003d_(\"Tripleo inventory file generated with \""},{"line_number":46,"context_line":"                   \"tripleo-ansible-inventory command. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"430799eb_ce708979","side":"PARENT","line":43,"range":{"start_line":43,"start_character":12,"end_line":43,"end_character":15},"in_reply_to":"ddff55ca_264a3d10","updated":"2022-04-12 07:27:12.000000000","message":"link please i cant find it at https://review.opendev.org/q/owner:fdiazbra%2540redhat.com\n\nso are we going to wait for that? or are we going to merge this first?","commit_id":"2909e0022279453798182012067aab8fb7209e25"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1a11fbfd0fd05c5f19d6187a3f502c8024a22604","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8030a90e_6cdb2f5b","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"updated":"2022-04-11 06:19:14.000000000","message":"is that right or copy/paste nit? delete?","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"913f642eff779227a2dc7ca9e80691d7adaa400b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5c71be93_0880209c","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"272a3e40_5899f547","updated":"2022-05-16 06:28:26.000000000","message":"ok that merged will you rebase this?","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b4e17565a91fb2f1d2bca975e9f3c7990d2baccb","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f61b6ff_4ba3b16f","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"5293bf01_53cd95fc","updated":"2022-04-14 07:48:05.000000000","message":"OK - up to you what you want to do with this one. either merge this (seems wrong though...) and then fix it with a followup from master,","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"6c1a60fa84b41b3b2e6b2e7d24c29fb47aeb0918","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0d3c93c5_5b4a3502","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"5c71be93_0880209c","updated":"2022-05-16 09:18:23.000000000","message":"Done","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"d465d5cce9289794ba93ba8222d9026e602d7362","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"272a3e40_5899f547","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"5f61b6ff_4ba3b16f","updated":"2022-04-20 07:58:19.000000000","message":"Thanks for your comments Marios! I have just sent a patch to master to fix this error: https://review.opendev.org/c/openstack/python-tripleoclient/+/838652","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"877182eaa145c49baddefea374954c6047fc27ec","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3c23e_3c5819fb","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"8030a90e_6cdb2f5b","updated":"2022-04-12 07:27:12.000000000","message":"what about this one?","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"aa775859da1bd1f03b31887ff27d7521fb0bf878","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5293bf01_53cd95fc","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"bfb3c23e_3c5819fb","updated":"2022-04-12 08:19:20.000000000","message":"I am not sure about this, Juan Badia will answer that","commit_id":"ecfeeefd1de0e6a39ca8eadd086eed0aa7d08f6f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"33dd4ba8ca80915659100da72eeb904b5335bc9f","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f3c74c73_98e07855","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"updated":"2022-05-17 07:19:47.000000000","message":"k so the plan is to merge this, then cherrypick https://review.opendev.org/c/openstack/python-tripleoclient/+/838652 and https://github.com/openstack/python-tripleoclient/commit/719a26aaf1c59d0f407f8a9951950032e9d4cb33 together  right?","commit_id":"98679c3cae144694cf5246956596d967c11145d6"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"eed1c2f4aa68874c1e99cc8b812492478effc127","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"efd15b21_060e69c3","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"9616df53_cdfdb09f","updated":"2022-05-27 08:09:46.000000000","message":"Done","commit_id":"98679c3cae144694cf5246956596d967c11145d6"},{"author":{"_account_id":34423,"name":"Fernando Díaz Bravo","email":"fdiazbra@redhat.com","username":"fdiazbra"},"change_message_id":"eaedc52c2b351e831deadac9d91f6178a12f9e17","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--stack\u0027,"},{"line_number":44,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Name or ID of heat stack to delete\u0027"},{"line_number":46,"context_line":"                   \u0027(default\u003dEnv: OVERCLOUD_STACK_NAME)\u0027),"},{"line_number":47,"context_line":"            default\u003dosc_utils.env(\u0027OVERCLOUD_STACK_NAME\u0027))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9616df53_cdfdb09f","line":45,"range":{"start_line":45,"start_character":48,"end_line":45,"end_character":54},"in_reply_to":"f3c74c73_98e07855","updated":"2022-05-17 08:29:45.000000000","message":"I rebased this one and created the relation chain with https://review.opendev.org/c/openstack/python-tripleoclient/+/841749/2 to have them in wallaby together. Once it is done, I will be able to cherry pick https://github.com/openstack/python-tripleoclient/commit/719a26aaf1c59d0f407f8a9951950032e9d4cb33 with no conflicts","commit_id":"98679c3cae144694cf5246956596d967c11145d6"}]}