)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b04e3c12d88501457942ff2a9591a0d608f6331","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"757044a0_e8eaa096","updated":"2022-04-28 12:59:24.000000000","message":"Great start. Thanks Francesco.","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"554d97d95bdcd4c1561dc050bfd2239cd3b71909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7dc6a2a2_4ded222e","updated":"2022-05-04 09:22:46.000000000","message":"recheck","commit_id":"e8f66d0b5dd6ccf76dab28b66d762a49c52ea258"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"a1df289449ce3a2d566f6536aaeeed1e230013b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3350cba5_0d8e6cad","updated":"2022-06-29 11:45:45.000000000","message":"Emilien, I\u0027m adding you to this review just to make sure you\u0027re aware of the coming change.","commit_id":"c55639757557810658755654e23e289d6ff4275b"}],"tripleoclient/utils.py":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b04e3c12d88501457942ff2a9591a0d608f6331","unresolved":true,"context_lines":[{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":""},{"line_number":1076,"context_line":"def check_deployed_ceph_stage(environment):"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"    resource_registry \u003d environment.get(\u0027resource_registry\u0027, {})"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    if not resource_registry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d301f58b_6d0e8d95","line":1077,"updated":"2022-04-28 12:59:24.000000000","message":"Please add something like the following:\n\n    \"\"\"Raises an exception if Ceph is being deployed without DeployedCeph true.\n       If Ceph is not being deployed or DeployedCeph true, then return nothing\n       so the program that calls this function can continue without error.\n       \u003cexplanation of logic\u003e\n    \"\"\"","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3cec33d9e2b02c1a96487961094554910d028343","unresolved":false,"context_lines":[{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":""},{"line_number":1076,"context_line":"def check_deployed_ceph_stage(environment):"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"    resource_registry \u003d environment.get(\u0027resource_registry\u0027, {})"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    if not resource_registry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0517c08a_916aa9b3","line":1077,"in_reply_to":"d301f58b_6d0e8d95","updated":"2022-04-28 14:07:13.000000000","message":"Done","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b04e3c12d88501457942ff2a9591a0d608f6331","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"                                    {}).get(\u0027DeployedCeph\u0027, False)"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    for name, path in resource_registry.items():"},{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1029a300_dac38f3f","line":1094,"range":{"start_line":1094,"start_character":8,"end_line":1094,"end_character":47},"updated":"2022-04-28 12:59:24.000000000","message":"So if they have any ceph resources and any path with cephadm, then we want to make sure they have the THT parm DeployedCeph true. When they use deployed ceph, this will be the case. Please indicate that logic as a comment in the code.","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3cec33d9e2b02c1a96487961094554910d028343","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                    {}).get(\u0027DeployedCeph\u0027, False)"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    for name, path in resource_registry.items():"},{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"8ef4e6c9_a2d404c1","line":1094,"range":{"start_line":1094,"start_character":8,"end_line":1094,"end_character":47},"in_reply_to":"1029a300_dac38f3f","updated":"2022-04-28 14:07:13.000000000","message":"Done","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b04e3c12d88501457942ff2a9591a0d608f6331","unresolved":true,"context_lines":[{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    for name, path in resource_registry.items():"},{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"},{"line_number":1098,"context_line":"                                                  \u0027you want to deploy Ceph, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"72583097_c93450fd","line":1095,"range":{"start_line":1095,"start_character":51,"end_line":1095,"end_character":54},"updated":"2022-04-28 12:59:24.000000000","message":"cut","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3cec33d9e2b02c1a96487961094554910d028343","unresolved":false,"context_lines":[{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"    for name, path in resource_registry.items():"},{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"},{"line_number":1098,"context_line":"                                                  \u0027you want to deploy Ceph, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b90164a8_0b622b11","line":1095,"range":{"start_line":1095,"start_character":51,"end_line":1095,"end_character":54},"in_reply_to":"72583097_c93450fd","updated":"2022-04-28 14:07:13.000000000","message":"Done","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9b04e3c12d88501457942ff2a9591a0d608f6331","unresolved":true,"context_lines":[{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"},{"line_number":1098,"context_line":"                                                  \u0027you want to deploy Ceph, \u0027"},{"line_number":1099,"context_line":"                                                  \u0027please see \"openstack \u0027"},{"line_number":1100,"context_line":"                                                  \u0027 overcloud ceph deploy \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e8084cb_830d576c","line":1097,"range":{"start_line":1097,"start_character":51,"end_line":1097,"end_character":54},"updated":"2022-04-28 12:59:24.000000000","message":"cut","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3cec33d9e2b02c1a96487961094554910d028343","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"        if \u0027Ceph\u0027 in name and \u0027cephadm\u0027 in path and not deployed_ceph:"},{"line_number":1095,"context_line":"            raise exceptions.InvalidConfiguration(\u0027The Ceph deployment is not \u0027"},{"line_number":1096,"context_line":"                                                  \u0027available anymore during \u0027"},{"line_number":1097,"context_line":"                                                  \u0027the overcloud deploy. If \u0027"},{"line_number":1098,"context_line":"                                                  \u0027you want to deploy Ceph, \u0027"},{"line_number":1099,"context_line":"                                                  \u0027please see \"openstack \u0027"},{"line_number":1100,"context_line":"                                                  \u0027 overcloud ceph deploy \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"e78042d5_b7b3be90","line":1097,"range":{"start_line":1097,"start_character":51,"end_line":1097,"end_character":54},"in_reply_to":"2e8084cb_830d576c","updated":"2022-04-28 14:07:13.000000000","message":"Done","commit_id":"335b7e0e91a8d6a7b1d99832ec14d57f2a239147"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"6fae8c0139816180be739007900d83b4f81c6662","unresolved":true,"context_lines":[{"line_number":753,"context_line":"            environments, self.tht_render, parsed_args.templates,"},{"line_number":754,"context_line":"            cleanup\u003dparsed_args.cleanup)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        # check if we\u0027re trying to deploy ceph during the overcloud deployment"},{"line_number":757,"context_line":"        utils.check_deployed_ceph_stage(env)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        roles_data \u003d utils.fetch_roles_file("}],"source_content_type":"text/x-python","patch_set":5,"id":"1990810b_3b3d301d","line":756,"updated":"2022-05-04 09:07:58.000000000","message":"This file is only used for undercloud install / upgrade. I\u0027m not sure we need to check for anything Ceph related during the undercloud install / upgrade do we?","commit_id":"e8f66d0b5dd6ccf76dab28b66d762a49c52ea258"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"27986e1b979d5929378cd95d55a2cf40ff946813","unresolved":true,"context_lines":[{"line_number":753,"context_line":"            environments, self.tht_render, parsed_args.templates,"},{"line_number":754,"context_line":"            cleanup\u003dparsed_args.cleanup)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        # check if we\u0027re trying to deploy ceph during the overcloud deployment"},{"line_number":757,"context_line":"        utils.check_deployed_ceph_stage(env)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        roles_data \u003d utils.fetch_roles_file("}],"source_content_type":"text/x-python","patch_set":5,"id":"1b548783_96803a34","line":756,"in_reply_to":"1990810b_3b3d301d","updated":"2022-05-04 09:22:31.000000000","message":"I see this file is actually used in standalone [1], which is where I was able to test in the first place this patch.\nOf course we don\u0027t have to make any check during the upgrade scenario, for 2 reasons:\n\n1. ceph is supposed to be an external task\n2. the upgrade at this point is not managed by tripleo\n\nHowever, any stack update runs part of the ceph deployment process (e.g, pools, keys, clients, additional daemons), and make this kind of check doesn\u0027t hurt (you can just make sure your overcloud heat variables are consistent), but in any case, I added this check in this file because of the standalone, which is run with something like:\n\n```\nsudo openstack tripleo deploy \\\n  --templates \\\n  --local-ip\u003d192.168.24.1/24 \\\n  -e /usr/share/openstack-tripleo-heat-templates/environments/standalone/standalone-tripleo.yaml \\\n  -r /usr/share/openstack-tripleo-heat-templates/roles/Standalone.yaml \\\n  -e \"$HOME/containers-prepare-parameters.yaml\" \\\n  -e \"$HOME/standalone_parameters.yaml\" \\\n  -e /usr/share/openstack-tripleo-heat-templates/environments/low-memory-usage.yaml \\\n  -e /usr/share/openstack-tripleo-heat-templates/ci/environments/scenario004-standalone.yaml \\\n  --output-dir $HOME\n```\n\n(passing the scenario to make sure we can cover a specific ceph test case)\n\n[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/standalone.html","commit_id":"e8f66d0b5dd6ccf76dab28b66d762a49c52ea258"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"ada99a57b2eb7de29ae837ad45f96953f3779e1d","unresolved":false,"context_lines":[{"line_number":753,"context_line":"            environments, self.tht_render, parsed_args.templates,"},{"line_number":754,"context_line":"            cleanup\u003dparsed_args.cleanup)"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        # check if we\u0027re trying to deploy ceph during the overcloud deployment"},{"line_number":757,"context_line":"        utils.check_deployed_ceph_stage(env)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        roles_data \u003d utils.fetch_roles_file("}],"source_content_type":"text/x-python","patch_set":5,"id":"49087373_c58e7d2e","line":756,"in_reply_to":"1b548783_96803a34","updated":"2022-05-04 11:23:05.000000000","message":"ahhh standalone, yes. My bad.","commit_id":"e8f66d0b5dd6ccf76dab28b66d762a49c52ea258"}]}