)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cbfbaabb0a2b99c09a0c510fd8a68863d7f6d942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46dfb7c2_7ec6a3b2","updated":"2022-06-24 11:29:26.000000000","message":"recheck","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4c97d17dbb197516b835a27f7af690f33e97d06d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a85d20fe_c77c9d5b","updated":"2022-06-27 10:40:39.000000000","message":"recheck","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"}],"tripleoclient/v1/tripleo_deploy.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7d48775a9a683bc7f7dbe689e7f32b8ddcd7e4cc","unresolved":true,"context_lines":[{"line_number":678,"context_line":"                                              [\u0027datacentre:br-ex\u0027])"},{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str):"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6af70cc8_a484693e","line":681,"range":{"start_line":681,"start_character":16,"end_line":681,"end_character":60},"updated":"2022-06-23 05:48:44.000000000","message":"Would have been good to check for empty string here \u0027\u0027. Else it would create a list with one item. I think it won\u0027t be the case for standalone though.","commit_id":"8e8c2b2971b32c5deb9fbc2eb7df27c647af900b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9c423e03bc9d5e04a9e360b305629fb25434a327","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                                              [\u0027datacentre:br-ex\u0027])"},{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str):"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1093341e_5f080790","line":681,"range":{"start_line":681,"start_character":16,"end_line":681,"end_character":60},"in_reply_to":"6af70cc8_a484693e","updated":"2022-06-24 09:02:57.000000000","message":"Seem this was fixed in patch set 3","commit_id":"8e8c2b2971b32c5deb9fbc2eb7df27c647af900b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d953ac733a68246a183685a740bc456d77fb24c6","unresolved":true,"context_lines":[{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str) and bridge_mappings:"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ee0872fa_fc2e29cb","line":682,"range":{"start_line":682,"start_character":59,"end_line":682,"end_character":74},"updated":"2022-06-24 07:10:01.000000000","message":"IIUC comma_delimited_list can include spaces like \"first, second, third\", so we\u0027d need strip here to remove surrounding spaces.","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"826fd6fbdc05fe9e31bd2accd56d441969494da3","unresolved":false,"context_lines":[{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str) and bridge_mappings:"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"57dc9aed_bfe32aaa","line":682,"range":{"start_line":682,"start_character":59,"end_line":682,"end_character":74},"in_reply_to":"6bd67831_89b58f30","updated":"2022-06-24 09:04:51.000000000","message":"I noticed I didn\u0027t read the note. My bad !!!","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9c423e03bc9d5e04a9e360b305629fb25434a327","unresolved":false,"context_lines":[{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str) and bridge_mappings:"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6bd67831_89b58f30","line":682,"range":{"start_line":682,"start_character":59,"end_line":682,"end_character":74},"in_reply_to":"b3e4cee6_04719257","updated":"2022-06-24 09:02:57.000000000","message":"Hmmm ok. then we\u0027d need to update the template spec, which includes \"one, two\" as an example value of comma_delimited_list.\n\nhttps://docs.openstack.org/heat/rocky/template_guide/hot_spec.html#parameters-section","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"c696b610e2ac1d08fc7e292d051d75e74c5a17a9","unresolved":true,"context_lines":[{"line_number":679,"context_line":"            # Handle heat comma_delimited_list"},{"line_number":680,"context_line":"            if isinstance(bridge_mappings, str) and bridge_mappings:"},{"line_number":681,"context_line":"                bridge_mappings \u003d bridge_mappings.split(\u0027,\u0027)"},{"line_number":682,"context_line":"            physnets \u003d [bridge.split(\u0027:\u0027)[0] for bridge in bridge_mappings]"},{"line_number":683,"context_line":"            for idx, physnet in enumerate(physnets):"},{"line_number":684,"context_line":"                ovn_bridge_macs[physnet] \u003d \u0027fa:16:3a:00:53:{:02X}\u0027.format(idx)"},{"line_number":685,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b3e4cee6_04719257","line":682,"range":{"start_line":682,"start_character":59,"end_line":682,"end_character":74},"in_reply_to":"ee0872fa_fc2e29cb","updated":"2022-06-24 07:39:53.000000000","message":"Not really. heat does not do it.\n\nhttps://github.com/openstack/heat/blob/master/heat/common/param_utils.py#L31","commit_id":"2011e7967767edc79bbccb062f653e8d5f272a23"}]}