)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b6fda58f1a8ef3ff72f14fdce5927185bdc0d2e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30822993_8c4dadb0","updated":"2022-06-30 21:39:46.000000000","message":"Looks good, but I think we should set resource_class per-instance instead of setting the default resource_class to whatever resource class the last node in the iteration has. See inline comment.","commit_id":"81716c222bfb591ed9ccd6ac6ca2f8c2c8b5ccfe"}],"tripleoclient/v1/overcloud_node.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b6fda58f1a8ef3ff72f14fdce5927185bdc0d2e3","unresolved":true,"context_lines":[{"line_number":658,"context_line":"                    instance[\u0027name\u0027] \u003d hostname_node_map[entry]"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"                if entry in hostname_node_resource:"},{"line_number":661,"context_line":"                    defaults[\u0027resource_class\u0027] \u003d hostname_node_resource[entry]"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"                if ips_from_pool:"},{"line_number":664,"context_line":"                    instance[\u0027networks\u0027] \u003d copy.deepcopy(role_networks)"}],"source_content_type":"text/x-python","patch_set":1,"id":"62dfad0d_8bb7dc5a","line":661,"range":{"start_line":661,"start_character":20,"end_line":661,"end_character":28},"updated":"2022-06-30 21:39:46.000000000","message":"Instead of setting the resource_class in the \"defaults\" for the role, you can set it for each instance. i.e s/defaults/instance/ here.","commit_id":"81716c222bfb591ed9ccd6ac6ca2f8c2c8b5ccfe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"9fc5572fde844b11ea5b2925f34e4a2a4ca8fb96","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                    instance[\u0027name\u0027] \u003d hostname_node_map[entry]"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"                if entry in hostname_node_resource:"},{"line_number":661,"context_line":"                    defaults[\u0027resource_class\u0027] \u003d hostname_node_resource[entry]"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"                if ips_from_pool:"},{"line_number":664,"context_line":"                    instance[\u0027networks\u0027] \u003d copy.deepcopy(role_networks)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0ec8e4d_c25f1d80","line":661,"range":{"start_line":661,"start_character":20,"end_line":661,"end_character":28},"in_reply_to":"62dfad0d_8bb7dc5a","updated":"2022-07-01 09:58:38.000000000","message":"Done","commit_id":"81716c222bfb591ed9ccd6ac6ca2f8c2c8b5ccfe"}]}