)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"db2342d6a3c5843a0e803d21df2ecee1057feed1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"config-download they will have the same value for"},{"line_number":22,"context_line":"tripleo_ceph_client_vars. Update export.py to use same path."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I7717f2ce9f668e9fd77c9b49e2433d729ed3c836"},{"line_number":25,"context_line":"Depends-On: I0346bf1c6a3d8796a0aa70cbaac6e34b2f74fabb"},{"line_number":26,"context_line":"Closes-Bug: #1981467"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d5ed71eb_95ab80c0","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":52},"updated":"2022-07-26 07:23:54.000000000","message":"because this is using change id instead of specific review url, we meed to merge the wallaby backport of this dependent change, otherwise zuul does not start merging this.","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"150b013ece66d5483e619a8b7c4b29417e504531","unresolved":true,"context_lines":[{"line_number":21,"context_line":"config-download they will have the same value for"},{"line_number":22,"context_line":"tripleo_ceph_client_vars. Update export.py to use same path."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I7717f2ce9f668e9fd77c9b49e2433d729ed3c836"},{"line_number":25,"context_line":"Depends-On: I0346bf1c6a3d8796a0aa70cbaac6e34b2f74fabb"},{"line_number":26,"context_line":"Closes-Bug: #1981467"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0a639b78_c5463090","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":52},"in_reply_to":"c29e985e_055210f8","updated":"2022-07-26 16:18:32.000000000","message":"+W\u0027d https://review.opendev.org/c/openstack/tripleo-ansible/+/850045","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9376ff8ed4cdf6f0f1f63110df8938f0706ef666","unresolved":true,"context_lines":[{"line_number":21,"context_line":"config-download they will have the same value for"},{"line_number":22,"context_line":"tripleo_ceph_client_vars. Update export.py to use same path."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I7717f2ce9f668e9fd77c9b49e2433d729ed3c836"},{"line_number":25,"context_line":"Depends-On: I0346bf1c6a3d8796a0aa70cbaac6e34b2f74fabb"},{"line_number":26,"context_line":"Closes-Bug: #1981467"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c29e985e_055210f8","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":52},"in_reply_to":"d5ed71eb_95ab80c0","updated":"2022-07-26 16:16:42.000000000","message":"Thank you for pointing that out Takashi!","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b8e77144148496ca2d8293d1e6569503bcb4dcd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6dc30cd_7498b23f","updated":"2022-07-19 12:00:55.000000000","message":"recheck","commit_id":"1f25ffd615497f8f3a3d88b7a8dbd54904811d2c"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"036a19dad79dbd3725f4d5ab735c909d41176e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b80832a_cc8a5487","updated":"2022-07-19 21:30:00.000000000","message":"The logs [1] show this task [2] fails because \u0027tripleo_ceph_client_vars\u0027 is undefined.\ndeployed_ceph.yaml has \"CephClientConfigVars: /root/overcloud-deploy/standalone/ceph_client.yml\" [3]\ncephadm-extra-vars-heat.yml has \"tripleo_ceph_client_vars: /root/overcloud-deploy/standalone/ceph_client.yml\" [4]\nThe file exists and contains the variables per [1][5] (root is odd but that\u0027s standalone)\nSo it works on the real ceph client but fails on the mock ones from CephExternalMultiConfig [6]\nIt will handle that scenario fine as it will be be the external one [7]\nBut in the external scenario, it needs to gracefully handle this variable not being defined.\nPS3 adds a condition to handle this scenario.\n\n[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/ansible.log\n\n[2] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml#L27-L30\n\n[3] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/deployed_ceph.yaml\n\n[4] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b46/850307/2/check/tripleo-ci-centos-9-scenario001-standalone/b46fc4d/logs/undercloud/home/zuul/tripleo-deploy/standalone-ansible-jj_ba95g/cephadm/cephadm-extra-vars-heat.yml\n\n[5] \n2022-07-19 18:05:24,789 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:24.788924 | bc764e10-1131-0bfa-b9f6-000000002955 |       TASK | Check if the input variables exist\n2022-07-19 18:05:25,130 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.128588 | bc764e10-1131-0bfa-b9f6-000000002955 |         OK | Check if the input variables exist | undercloud\n2022-07-19 18:05:25,162 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.162184 | bc764e10-1131-0bfa-b9f6-000000002956 |       TASK | Load variables produced by the cephadm provisioning process\n2022-07-19 18:05:25,213 p\u003d91987 u\u003droot n\u003dansible | 2022-07-19 18:05:25.212447 | bc764e10-1131-0bfa-b9f6-000000002956 |         OK | Load variables produced by the cephadm provisioning process | undercloud\n\n[6] https://github.com/openstack/tripleo-heat-templates/blob/master/ci/environments/scenario001-standalone.yaml#L81\n\n[7] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_client/tasks/main.yml#L42-L45","commit_id":"bcb4dfe5dc3eebfc174001d933415ae7a4911477"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b58ed6122ca1ceb1199e58fff8f7cfde99977652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73b30730_5b26e1da","in_reply_to":"6b80832a_cc8a5487","updated":"2022-07-19 21:31:36.000000000","message":"Disregard.\n\n\u003e The logs [1] show this task [2] fails ...\n\nThis comment was meant for https://review.opendev.org/c/openstack/tripleo-ansible/+/850307/3","commit_id":"bcb4dfe5dc3eebfc174001d933415ae7a4911477"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"c4383baf846fefc970180e3287ba27ba0397066c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09be8779_5a712b90","updated":"2022-07-22 12:49:11.000000000","message":"recheck","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"db8ddcf853ebab66eb31d8c3b689cfa1faabe7fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ae132e2_99e5d018","updated":"2022-07-21 18:27:44.000000000","message":"recheck","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"eccead31e489fc91dce5c9991047a9b06b4b0180","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21f24caa_fc04dd9a","updated":"2022-07-20 13:55:16.000000000","message":"recheck","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"3a6b6bdff19abc3ffc14e093f10c4182d488991c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5adb5b52_600c5421","updated":"2022-07-20 13:33:46.000000000","message":"recheck","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"81291262c5a6cfa58684b4f431ab23a30a5611e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74aa1d17_b6a49dfe","updated":"2022-07-25 17:22:06.000000000","message":"recheck","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"}],"tripleoclient/v2/overcloud_ceph.py":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"b487c5a364b30f9af1d14898b25f212373ed15f1","unresolved":true,"context_lines":[{"line_number":392,"context_line":"            \"working_dir\": working_dir,"},{"line_number":393,"context_line":"            \"stack_name\": parsed_args.stack,"},{"line_number":394,"context_line":"            \"tripleo_cephadm_standalone\": parsed_args.standalone,"},{"line_number":395,"context_line":"            \"tripleo_ceph_client_vars\": os.path.join(working_dir,"},{"line_number":396,"context_line":"                                                     \u0027ceph_client.yml\u0027)"},{"line_number":397,"context_line":"        }"},{"line_number":398,"context_line":"        extra_vars_file \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"8d3923c0_3cb52f90","line":395,"range":{"start_line":395,"start_character":53,"end_line":395,"end_character":64},"updated":"2022-07-25 07:40:42.000000000","message":"tripleoclient knows the working_dir: it\u0027s a good idea driving this parameter from this layer.","commit_id":"29fe3996bbe8cdaaa86c73cfb3dda443e789bd96"}]}