)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f504554ae8865fa435e43e8c79c597f49af3fb1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2bdff955_ce115929","updated":"2022-10-17 06:13:32.000000000","message":"I know this is still WIP but just dumping a few more thoughts.\n\n- We also want the capability to replicate role specific parameters or resources. \n\n- We might want to make the command work based on templates instead of the exported stack data, because what we basically need to tweak is the environment files and the role file.\n\n- To split the instances to multiple nodes, we have two approaches\n 1. Split instances completely and add a single instance to only one of the destination roles\n 2. Replicate the whole instances and use RemovalPolicies to control which role taks control\n  While 1 is likely to work well, 2 might have some benefit (for example users don\u0027t need to be aware of the new hostname format)","commit_id":"aecf877c4d495587545ca6982f6591075389c7a3"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5515274b86f22bb0be1b9a04f52a3faa438c72ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0512ce6_799eff66","updated":"2022-09-12 04:58:10.000000000","message":"check-rdo Error: statfs /var/lib/config-data/puppet-generated/rabbitmq: no such file or directory","commit_id":"aecf877c4d495587545ca6982f6591075389c7a3"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6a048ef89c7d8795ee7c2eb703ca9670f7b8f863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f2a414a_a4cdd271","in_reply_to":"2bdff955_ce115929","updated":"2022-10-17 06:21:16.000000000","message":"\u003e I know this is still WIP but just dumping a few more thoughts.\n\nYeah, depending on where we integrate the role split, this would change. Lucas wanted us to integrate this as part of system upgrade command before \u0027overcloud upgrade prepare\u0027 is run and not part of undercloud upgrade that I thought initially.\n\n\u003e 2 might have some benefit\n\nI think this patch uses 2 when splitting roles and we would probably stick with that approach(?).","commit_id":"aecf877c4d495587545ca6982f6591075389c7a3"}],"tripleoclient/v1/overcloud_node.py":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d0f8ce0972f6bed2e17724501129861ef2c30fa5","unresolved":true,"context_lines":[{"line_number":498,"context_line":"        parser.add_argument(\u0027--roles-file\u0027, \u0027-r\u0027, dest\u003d\u0027roles_file\u0027,"},{"line_number":499,"context_line":"                            required\u003dFalse,"},{"line_number":500,"context_line":"                            help\u003d_(\u0027Role data definition file\u0027))"},{"line_number":501,"context_line":"        parser.add_argument(\u0027--split-role-data\u0027, dest\u003d\u0027split_role_data\u0027,"},{"line_number":502,"context_line":"                            required\u003dFalse,"},{"line_number":503,"context_line":"                            help\u003d_(\u0027Split roles for multi-os-support.\u0027"},{"line_number":504,"context_line":"                                   \u0027Specify in the format:\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"e31d9d26_b5dee47e","line":501,"updated":"2022-09-12 13:58:54.000000000","message":"As discussed today, I agree that this would be better if we could pass in a yaml file and read from that rather than a json input which could be complicated for users.","commit_id":"aecf877c4d495587545ca6982f6591075389c7a3"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"255da8db53fd02425d92662f6a184d20e3164c01","unresolved":true,"context_lines":[{"line_number":498,"context_line":"        parser.add_argument(\u0027--roles-file\u0027, \u0027-r\u0027, dest\u003d\u0027roles_file\u0027,"},{"line_number":499,"context_line":"                            required\u003dFalse,"},{"line_number":500,"context_line":"                            help\u003d_(\u0027Role data definition file\u0027))"},{"line_number":501,"context_line":"        parser.add_argument(\u0027--split-role-data\u0027, dest\u003d\u0027split_role_data\u0027,"},{"line_number":502,"context_line":"                            required\u003dFalse,"},{"line_number":503,"context_line":"                            help\u003d_(\u0027Split roles for multi-os-support.\u0027"},{"line_number":504,"context_line":"                                   \u0027Specify in the format:\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"053d0bb8_fc97de22","line":501,"in_reply_to":"e31d9d26_b5dee47e","updated":"2022-09-13 08:08:58.000000000","message":"I\u0027ll update it once we decide on what path we\u0027re going to take;) Looks like we\u0027re still debating it. I proposed this just to demonstrate that it\u0027s not difficult.","commit_id":"aecf877c4d495587545ca6982f6591075389c7a3"}]}
