)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c87572a85bff0539a8b62da824cd6a85d5c09728","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9372ef9e_0f95fc34","updated":"2023-01-10 01:19:12.000000000","message":"Should we rather allow executing CIP without any environment files because we define the default value for CIP parameter here[1] ?\n\n[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/kolla_builder.py#L39-L50","commit_id":"2e5ea5cceb828d6374f30ad26b3bd4df6d5797b2"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"405d4abc5ea5929c9b9760f45e7bea3230b1673e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5f236b9_2b789d0a","in_reply_to":"9372ef9e_0f95fc34","updated":"2023-01-11 02:40:00.000000000","message":"I don\u0027t think so. And primarily because it won\u0027t work for RHOSP because the user credentials won\u0027t be provided. So while it might work fine for tripleo without authentication required, it won\u0027t work downstream.\n\nRather than handle each case separately, I thought it might just be best to make it required?","commit_id":"2e5ea5cceb828d6374f30ad26b3bd4df6d5797b2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6efa9607e5062ae4f11d36632f7bfde008275eef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff748dac_9dbc1cc0","in_reply_to":"e5f236b9_2b789d0a","updated":"2023-01-11 02:49:14.000000000","message":"Requiring auth is specific to downstream then we should handle it as downstream-only.\n\nIIUC we intentionally implemented the fallback mechanism to the default CIP parameter[1] assuming that would be the enough default so we better keep this behavior consistent with that concept, IMO.\n\n[1] https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/kolla_builder.py#L177-L180","commit_id":"2e5ea5cceb828d6374f30ad26b3bd4df6d5797b2"}],"tripleoclient/v1/container_image.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2a9e7e76bf4367379f9c0f05ce04a30be7bf66cb","unresolved":true,"context_lines":[{"line_number":565,"context_line":"                                      \u0027, \u0027.join(image_uploader.CLEANUP))"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        role_file \u003d None"},{"line_number":568,"context_line":"        env_files \u003d None"},{"line_number":569,"context_line":"        if parsed_args.roles_file:"},{"line_number":570,"context_line":"            role_file \u003d utils.rel_or_abs_path(parsed_args.roles_file,"},{"line_number":571,"context_line":"                                              constants.TRIPLEO_HEAT_TEMPLATES)"}],"source_content_type":"text/x-python","patch_set":5,"id":"99e3d564_015ee155","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":24},"updated":"2023-01-12 04:37:25.000000000","message":"I was checking the underlying playbook but I believe it expects a list and can\u0027t handle None properly. Should we use an empty list ?\n\nAlso, we may want to simplify this by \n```\nenv_files \u003d [os.path.abspath(x)\n             for x in (parsed_args.environment_files or [])]\n```\n(or even updating the default to []) but that\u0027s just my own preference.","commit_id":"2c6c8482fbab9d417c8ef327b554a69b3eccdfd6"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d4836e9c90159341bdacf0b93067408af8f06419","unresolved":true,"context_lines":[{"line_number":565,"context_line":"                                      \u0027, \u0027.join(image_uploader.CLEANUP))"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        role_file \u003d None"},{"line_number":568,"context_line":"        env_files \u003d None"},{"line_number":569,"context_line":"        if parsed_args.roles_file:"},{"line_number":570,"context_line":"            role_file \u003d utils.rel_or_abs_path(parsed_args.roles_file,"},{"line_number":571,"context_line":"                                              constants.TRIPLEO_HEAT_TEMPLATES)"}],"source_content_type":"text/x-python","patch_set":5,"id":"14a263fc_fa2fe2b6","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":24},"in_reply_to":"577c4ba6_30b398ab","updated":"2023-01-16 07:01:38.000000000","message":"Could have ignored the extra_var for no env files too.","commit_id":"2c6c8482fbab9d417c8ef327b554a69b3eccdfd6"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"c9779d9a01e1c8411e37c5385508f8bd305a6a4d","unresolved":true,"context_lines":[{"line_number":565,"context_line":"                                      \u0027, \u0027.join(image_uploader.CLEANUP))"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        role_file \u003d None"},{"line_number":568,"context_line":"        env_files \u003d None"},{"line_number":569,"context_line":"        if parsed_args.roles_file:"},{"line_number":570,"context_line":"            role_file \u003d utils.rel_or_abs_path(parsed_args.roles_file,"},{"line_number":571,"context_line":"                                              constants.TRIPLEO_HEAT_TEMPLATES)"}],"source_content_type":"text/x-python","patch_set":5,"id":"577c4ba6_30b398ab","line":568,"range":{"start_line":568,"start_character":8,"end_line":568,"end_character":24},"in_reply_to":"99e3d564_015ee155","updated":"2023-01-12 05:14:40.000000000","message":"Yeah, you might be right. I thought it would just take None and default. But you might be right about it needing an empty list. \n\nDefining it just once in the list comprehension seems like the cleanest way to me. New patchset features that change.","commit_id":"2c6c8482fbab9d417c8ef327b554a69b3eccdfd6"}]}