)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"change_message_id":"a82ab35505a789694ca8646ff3ce13dfa0bc45c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3bc04db9_a023bd0c","updated":"2023-02-20 12:40:50.000000000","message":"recheck","commit_id":"3192ff8cd57948ebded8456c2036f27c569023b3"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"0348972bc4a3dda0fc6097b1a3f2196a132cf6a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6efc0385_29425c38","updated":"2023-03-01 11:33:52.000000000","message":"recheck","commit_id":"4d8fe985e0992bc93c048507fd78075058146e07"}],"tripleoclient/v1/overcloud_admin.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0301592e7571ad42d4c58261d6c5ed73f3aad091","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            ssh_user\u003dparsed_args.overcloud_ssh_user,"},{"line_number":131,"context_line":"            extra_vars\u003d{"},{"line_number":132,"context_line":"                \"ANSIBLE_PRIVATE_KEY_FILE\": key_file,"},{"line_number":133,"context_line":"                \"ssh_servers\": all_hosts"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            limit_hosts\u003dlimit_hosts,"},{"line_number":136,"context_line":"            ansible_timeout\u003dparsed_args.overcloud_ssh_port_timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"acde5119_79114261","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":40},"updated":"2023-02-22 09:25:42.000000000","message":"I don\u0027t think this would work as we create in memory inventory with ssh_servers and then use it in the playbook. limit_hosts is useless here. Did we test it with ansible limit?\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/cli-enable-ssh-admin.yaml#L147-L157","commit_id":"3192ff8cd57948ebded8456c2036f27c569023b3"},{"author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"change_message_id":"067af621ea5914cf627394a5167cb0110a38f7aa","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            ssh_user\u003dparsed_args.overcloud_ssh_user,"},{"line_number":131,"context_line":"            extra_vars\u003d{"},{"line_number":132,"context_line":"                \"ANSIBLE_PRIVATE_KEY_FILE\": key_file,"},{"line_number":133,"context_line":"                \"ssh_servers\": all_hosts"},{"line_number":134,"context_line":"            },"},{"line_number":135,"context_line":"            limit_hosts\u003dlimit_hosts,"},{"line_number":136,"context_line":"            ansible_timeout\u003dparsed_args.overcloud_ssh_port_timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f814d1a_281a36d8","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":40},"in_reply_to":"acde5119_79114261","updated":"2023-02-22 14:26:58.000000000","message":"I\u0027ve done some testing and limit_hosts filtering seems to apply even to the in-memory tripleo_queues group.\n\nIn the cli-enable-ssh-admin.yaml playbook, when it gets to the \"Run Create admin\" task which uses \"hosts: localhost:tripleo_queues\", that task doesn\u0027t run on any hosts excluded by limit_hosts.\n\nSo:\n\"ssh_servers\": [\"compute-0\", \"compute-1\", \"compute-2\", \"ceph-0\", \"ceph-1\"]\nlimit_hosts\u003d\"localhost,*1\"\nResults in \"Run Create admin\" running for and only for localhost, compute-1, ceph-1.\n\nBut it turns out we do need to add localhost explicitly in limit_hosts, otherwise all the previous steps don\u0027t run and everything breaks. Fixing that now.","commit_id":"3192ff8cd57948ebded8456c2036f27c569023b3"}]}