)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4fd8474458b99fe8db2e31790024e6d44ab1451b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ffae9ea_b908cef1","updated":"2023-09-12 09:31:25.000000000","message":"I think this might be a better approach:\nhttps://review.opendev.org/c/openstack/python-tripleoclient/+/894604","commit_id":"0d1c0c3e81e19729f346688746011ef2ad289023"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"6535cee35fd1434ed2040590d77397cb0d9fa109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"650c4713_ed00dabe","updated":"2023-09-12 07:02:20.000000000","message":"I think you want to be fixing this in Train right? Wallaby would use ansible for the Network config, in which case you would create an environment file like so:\n```\nparameter_defaults:\n  UndercloudNetworkConfigTemplate: \"path/to/undercloud/nic-config/template.j2\"\n```\n\nThen pass that in to the `undercloud.conf` via `custom_env_files`","commit_id":"0d1c0c3e81e19729f346688746011ef2ad289023"}],"tripleoclient/v1/undercloud_preflight.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2c89d3b01cc7ad36a7b03e4ae01c5c6e88a786b9","unresolved":true,"context_lines":[{"line_number":294,"context_line":"    need to disallow it early in the install before configurations start to"},{"line_number":295,"context_line":"    be changed."},{"line_number":296,"context_line":"    \"\"\""},{"line_number":297,"context_line":"    if CONF.net_config_override:"},{"line_number":298,"context_line":"        os_net_config_file \u003d CONF.net_config_override"},{"line_number":299,"context_line":"    else:"},{"line_number":300,"context_line":"        os_net_config_file \u003d \u0027/etc/os-net-config/config.yaml\u0027"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4a9d6d1e_6d1d36a2","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":53},"updated":"2023-09-11 15:03:02.000000000","message":"I think the issue here is trying to read the net_config_override which is a template used to create \u0027/etc/os-net-config/config.yaml\u0027 or \u0027/etc/os-net-config/config.json\u0027 when the undercloud is first deployed. This validation should simply load what is in \u0027/etc/os-net-config/\u0027 and compare that?\n\nThe template specified in net_config_override is likely to have something like:\n\n```\nnetwork_config:\n  - name: br-ctlplane\n    addresses:\n    - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_cidr }}\n```\n\ni.e even if json for some reason parses that this would blow up at L327 whan netaddr fails to parse {{ ctlplane_ip }}/{{ ctlplane_cidr }} as an IP address.","commit_id":"0d1c0c3e81e19729f346688746011ef2ad289023"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"ecc77c216289c9e5ea11af861fcfb14254aae01a","unresolved":true,"context_lines":[{"line_number":294,"context_line":"    need to disallow it early in the install before configurations start to"},{"line_number":295,"context_line":"    be changed."},{"line_number":296,"context_line":"    \"\"\""},{"line_number":297,"context_line":"    if CONF.net_config_override:"},{"line_number":298,"context_line":"        os_net_config_file \u003d CONF.net_config_override"},{"line_number":299,"context_line":"    else:"},{"line_number":300,"context_line":"        os_net_config_file \u003d \u0027/etc/os-net-config/config.yaml\u0027"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a53d1a99_10b153d6","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":53},"in_reply_to":"4a9d6d1e_6d1d36a2","updated":"2023-09-11 15:47:44.000000000","message":"I don\u0027t know, this was working in Queens and the only code change I\u0027ve found is the way we load the file ... if we don\u0027t use {{}} it works, if we use {{}} it breaks.  If we use \"{{}}\" it solves part of the problem but then breaks on DnsServers because you can\u0027t \"\" the array because it already have \"\" in the values.  \n\nI tested this patch and it appears to solve the current issue we\u0027re facing but if there\u0027s a better way to solve this, I\u0027m all in.","commit_id":"0d1c0c3e81e19729f346688746011ef2ad289023"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cbbe2f30be66235dabd13610c82748a24e086f10","unresolved":true,"context_lines":[{"line_number":294,"context_line":"    need to disallow it early in the install before configurations start to"},{"line_number":295,"context_line":"    be changed."},{"line_number":296,"context_line":"    \"\"\""},{"line_number":297,"context_line":"    if CONF.net_config_override:"},{"line_number":298,"context_line":"        os_net_config_file \u003d CONF.net_config_override"},{"line_number":299,"context_line":"    else:"},{"line_number":300,"context_line":"        os_net_config_file \u003d \u0027/etc/os-net-config/config.yaml\u0027"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4d0e0e41_eca2c4c6","line":298,"range":{"start_line":297,"start_character":0,"end_line":298,"end_character":53},"in_reply_to":"a53d1a99_10b153d6","updated":"2023-09-11 20:30:20.000000000","message":"The point of this test is to validate if the current configured IP address on br-ctlplane is the same as what is in CONF.local_ip. I am not convinced the net_config_override template should have been included here at all. We want to check either what is in etc/os-net-config/config.[yaml|json], or look up the ip on the br-ctlplane interface.\n\nI think \"de-indent L300\" and delete L297,L298 and L299 is the way to go.\n\nIs there a bug report?\n Can you share the net_config_override template you are using?","commit_id":"0d1c0c3e81e19729f346688746011ef2ad289023"}]}