)]}'
{"troveclient/tests/test_instances.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"635a58c7b1866e0003259a72d98ee8e9c95b57d1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        resp \u003d mock.Mock()"},{"line_number":182,"context_line":"        resp.status_code \u003d 204"},{"line_number":183,"context_line":"        body \u003d None"},{"line_number":184,"context_line":"        self.instances.api.client.patch \u003d mock.Mock(return_value\u003d(resp, body))"},{"line_number":185,"context_line":"        self.instances.edit(123)"},{"line_number":186,"context_line":"        self.instances.edit(123, 321)"},{"line_number":187,"context_line":"        self.instances.edit(123, 321, \u0027name-1234\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_11726d7c","side":"PARENT","line":184,"updated":"2014-08-18 11:52:33.000000000","message":"same here","commit_id":"344a38a661d2379cda5675566dc4e185a3d1050f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"635a58c7b1866e0003259a72d98ee8e9c95b57d1","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_detach_replica(self):"},{"line_number":66,"context_line":"        db_detach_mock \u003d mock.Mock(return_value\u003dNone)"},{"line_number":67,"context_line":"        self.instance.manager.edit \u003d db_detach_mock"},{"line_number":68,"context_line":"        self.instance.id \u003d 1"},{"line_number":69,"context_line":"        self.instance.detach_replica()"},{"line_number":70,"context_line":"        self.assertEqual(1, db_detach_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_71bba10e","line":67,"updated":"2014-08-18 11:52:33.000000000","message":"I\u0027m not entirely certain how the setup and teardown are working in this case but please confirm that the actions of this Mock are reversed properly. \n\nI think they are but would like you to confirm.","commit_id":"a291d7ef8116861a9c474143d721a8f8e65d01d3"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"6085d75f92f49f58fd56d64ff63da579831ebd39","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_detach_replica(self):"},{"line_number":66,"context_line":"        db_detach_mock \u003d mock.Mock(return_value\u003dNone)"},{"line_number":67,"context_line":"        self.instance.manager.edit \u003d db_detach_mock"},{"line_number":68,"context_line":"        self.instance.id \u003d 1"},{"line_number":69,"context_line":"        self.instance.detach_replica()"},{"line_number":70,"context_line":"        self.assertEqual(1, db_detach_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_6a23fa55","line":67,"in_reply_to":"1abeadc6_71bba10e","updated":"2014-08-22 06:04:47.000000000","message":"This is mocking something at an instance level which is local to this test, so this should be okay.","commit_id":"a291d7ef8116861a9c474143d721a8f8e65d01d3"}],"troveclient/v1/instances.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"928718e23b8c22efc5ef1ef6abd2d8f3a2372b0a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.manager.restart(self.id)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def detach_replication(self):"},{"line_number":42,"context_line":"        \"\"\"Detach the database from its replication master.\"\"\""},{"line_number":43,"context_line":"        self.manager.detach_replication(self.id)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4e7fc866","line":42,"updated":"2014-06-24 12:37:18.000000000","message":"Detach slave instance","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc6b20237eb6d0e4bc2e009a36c9117ce545fccc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.manager.restart(self.id)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def detach_replication(self):"},{"line_number":42,"context_line":"        \"\"\"Detach the database from its replication master.\"\"\""},{"line_number":43,"context_line":"        self.manager.detach_replication(self.id)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b7731b15","line":42,"in_reply_to":"1ae5cdf2_4e7fc866","updated":"2014-08-07 20:05:20.000000000","message":"Slave is a mysql term.  Maybe something more generic like detach_replicate (since replication implies action).","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"928718e23b8c22efc5ef1ef6abd2d8f3a2372b0a","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def detach_replication(self, instance_id):"},{"line_number":167,"context_line":"        \"\"\"Detach the database from its replication master.\"\"\""},{"line_number":168,"context_line":"        body \u003d {\u0027detach_replication\u0027: {}}"},{"line_number":169,"context_line":"        self._action(instance_id, body)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def configuration(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_eee6d449","line":168,"updated":"2014-06-24 12:37:18.000000000","message":"detach_slave would be more appreciable","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc6b20237eb6d0e4bc2e009a36c9117ce545fccc","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def detach_replication(self, instance_id):"},{"line_number":167,"context_line":"        \"\"\"Detach the database from its replication master.\"\"\""},{"line_number":168,"context_line":"        body \u003d {\u0027detach_replication\u0027: {}}"},{"line_number":169,"context_line":"        self._action(instance_id, body)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def configuration(self, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_974b77b1","line":168,"in_reply_to":"1ae5cdf2_eee6d449","updated":"2014-08-07 20:05:20.000000000","message":"ditto","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"565b075262e04e83842480ea8a25652884fbdf3e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if name is not None:"},{"line_number":102,"context_line":"            body[\"instance\"][\"name\"] \u003d name"},{"line_number":103,"context_line":"        if detach_replica_source:"},{"line_number":104,"context_line":"            body[\"slave_of\"] \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        url \u003d \"/instances/%s\" % instance_id"},{"line_number":107,"context_line":"        resp, body \u003d self.api.client.patch(url, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_adda07e7","line":104,"updated":"2014-08-26 18:30:16.000000000","message":"This should be body[instance][slave_of]. \n\nTesting with the current patch set, the resulting JSON is:\n\n    {\"instance\": {}, \"slave_of\": null}\u0027","commit_id":"a291d7ef8116861a9c474143d721a8f8e65d01d3"}],"troveclient/v1/shell.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"928718e23b8c22efc5ef1ef6abd2d8f3a2372b0a","unresolved":false,"context_lines":[{"line_number":325,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":326,"context_line":"           type\u003dstr,"},{"line_number":327,"context_line":"           help\u003d\u0027ID of the instance.\u0027)"},{"line_number":328,"context_line":"def do_detach_replication(cs, args):"},{"line_number":329,"context_line":"    \"\"\"Detaches an instance from its replication master.\"\"\""},{"line_number":330,"context_line":"    cs.instances.detach_replication(args.instance)"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8ed7104f","line":328,"updated":"2014-06-24 12:37:18.000000000","message":"do_slave_detach","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc6b20237eb6d0e4bc2e009a36c9117ce545fccc","unresolved":false,"context_lines":[{"line_number":325,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":326,"context_line":"           type\u003dstr,"},{"line_number":327,"context_line":"           help\u003d\u0027ID of the instance.\u0027)"},{"line_number":328,"context_line":"def do_detach_replication(cs, args):"},{"line_number":329,"context_line":"    \"\"\"Detaches an instance from its replication master.\"\"\""},{"line_number":330,"context_line":"    cs.instances.detach_replication(args.instance)"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_92c5455f","line":328,"in_reply_to":"1ae5cdf2_8ed7104f","updated":"2014-08-07 20:05:20.000000000","message":"I would go with do_replicate_detach here.  It seems our standard is subject-verb (i.e. user-show), except of course for the resize ones where it\u0027s backwards.","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"928718e23b8c22efc5ef1ef6abd2d8f3a2372b0a","unresolved":false,"context_lines":[{"line_number":326,"context_line":"           type\u003dstr,"},{"line_number":327,"context_line":"           help\u003d\u0027ID of the instance.\u0027)"},{"line_number":328,"context_line":"def do_detach_replication(cs, args):"},{"line_number":329,"context_line":"    \"\"\"Detaches an instance from its replication master.\"\"\""},{"line_number":330,"context_line":"    cs.instances.detach_replication(args.instance)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# Backup related commands"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0ed30060","line":329,"updated":"2014-06-24 12:37:18.000000000","message":"\"\"\"Detaches a slave instance from its replication master.\"\"\"","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cc6b20237eb6d0e4bc2e009a36c9117ce545fccc","unresolved":false,"context_lines":[{"line_number":326,"context_line":"           type\u003dstr,"},{"line_number":327,"context_line":"           help\u003d\u0027ID of the instance.\u0027)"},{"line_number":328,"context_line":"def do_detach_replication(cs, args):"},{"line_number":329,"context_line":"    \"\"\"Detaches an instance from its replication master.\"\"\""},{"line_number":330,"context_line":"    cs.instances.detach_replication(args.instance)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"# Backup related commands"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d296dd48","line":329,"in_reply_to":"1ae5cdf2_0ed30060","updated":"2014-08-07 20:05:20.000000000","message":"I\u0027d avoid mysql specific terms.  I think this is fine the way it is.","commit_id":"678c9b5d8edbf9b64ee31b1a4e487477f5c0d2ab"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8355d8182e2e5070ae02967a0077bddab2c5544e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"           help\u003d\u0027Detach the replica instance from its replication source .\u0027)"},{"line_number":176,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":177,"context_line":"def do_update(cs, args):"},{"line_number":178,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":179,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name,"},{"line_number":180,"context_line":"                      args.detach_replica_source)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_f9a96f7c","line":178,"updated":"2014-08-17 08:34:36.000000000","message":"please update docstring","commit_id":"3c19598599795311f1e49353d557b874edf9ff10"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b20abdca70a766ba02c930368cb6c5d02a78bb7d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"           help\u003d\u0027Detach the replica instance from its replication source .\u0027)"},{"line_number":176,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":177,"context_line":"def do_update(cs, args):"},{"line_number":178,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":179,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name,"},{"line_number":180,"context_line":"                      args.detach_replica_source)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_663133a2","line":178,"in_reply_to":"1abeadc6_f9a96f7c","updated":"2014-08-18 06:21:18.000000000","message":"Done","commit_id":"3c19598599795311f1e49353d557b874edf9ff10"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"635a58c7b1866e0003259a72d98ee8e9c95b57d1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"           dest\u003d\u0027detach_replica_source\u0027,"},{"line_number":173,"context_line":"           action\u003d\"store_true\","},{"line_number":174,"context_line":"           default\u003dFalse,"},{"line_number":175,"context_line":"           help\u003d\u0027Detach the replica instance from its replication source .\u0027)"},{"line_number":176,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":177,"context_line":"def do_update(cs, args):"},{"line_number":178,"context_line":"    \"\"\"Updates an instance: Edits name, configuration, or replica source.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_912cbd4c","line":175,"updated":"2014-08-18 11:52:33.000000000","message":"there\u0027s a space before the period ;)","commit_id":"a291d7ef8116861a9c474143d721a8f8e65d01d3"}]}