)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d7ff0f4fc580fc6a36c8a9a7cf17319941c9975e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Associate flavor types with datastore versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature provides the ability to associate flavor types with datastore versions."},{"line_number":10,"context_line":"The management api will provide the ability to add or delete this information."},{"line_number":11,"context_line":"The normal user can view the flavor list for the default version or a"},{"line_number":12,"context_line":"specified datastore version id. The troveclient has been changed to provide the cli"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aa7fdbe_1c1ed963","line":9,"updated":"2014-10-21 17:16:58.000000000","message":"if for any reason you get to resubmit this change set, would you wrap the text here please.","commit_id":"4bb11b637f2d2bf1e185df1003e7bc8e51a7e176"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"835d1d6c8d4cda82fe33e8d9d0fbb80282606fe8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Associate flavor types with datastore versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature provides the ability to associate flavor types with datastore versions."},{"line_number":10,"context_line":"The management api will provide the ability to add or delete this information."},{"line_number":11,"context_line":"The normal user can view the flavor list for the default version or a"},{"line_number":12,"context_line":"specified datastore version id. The troveclient has been changed to provide the cli"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8c0949_c6065820","line":9,"in_reply_to":"9aa7fdbe_1c1ed963","updated":"2014-10-31 19:23:16.000000000","message":"I agree, should be capped at 72 characters","commit_id":"4bb11b637f2d2bf1e185df1003e7bc8e51a7e176"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d7ff0f4fc580fc6a36c8a9a7cf17319941c9975e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"support for this (list flavors)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I89fc2db0078d7884b7b3fa91f5daec68c0132dfb"},{"line_number":16,"context_line":"Implements: blueprint associate-flavors-datastores"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aa7fdbe_bc722dab","line":16,"updated":"2014-10-21 17:16:58.000000000","message":"Shouldn\u0027t this be partially implements? I think there are at least two other reviews for this blueprint.","commit_id":"4bb11b637f2d2bf1e185df1003e7bc8e51a7e176"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"835d1d6c8d4cda82fe33e8d9d0fbb80282606fe8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"support for this (list flavors)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I89fc2db0078d7884b7b3fa91f5daec68c0132dfb"},{"line_number":16,"context_line":"Implements: blueprint associate-flavors-datastores"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8c0949_66184482","line":16,"in_reply_to":"9aa7fdbe_bc722dab","updated":"2014-10-31 19:23:16.000000000","message":"Yes, the other two commits say partially-implements","commit_id":"4bb11b637f2d2bf1e185df1003e7bc8e51a7e176"}],"troveclient/v1/flavors.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7326c0981f99a0a478bc9e88135043201089496e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    resource_class \u003d Flavor"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self):"},{"line_number":32,"context_line":"        \"\"\"Get a list of all flavors for the default datastore version"},{"line_number":33,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_95505a0b","line":32,"updated":"2014-07-28 12:54:42.000000000","message":"lists all flavor, datastore version has nothing common for given flavors for route /{tenant_id}/flavors","commit_id":"e1d3e06c9294fa947e6873d65c581fba4a24038e"},{"author":{"_account_id":7796,"name":"Riddhi Shah","email":"ridhi.j.shah@gmail.com","username":"ridhi-j-shah"},"change_message_id":"d19d0061be4d7d12ab7c07219ea5efb73e7d619b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    resource_class \u003d Flavor"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self):"},{"line_number":32,"context_line":"        \"\"\"Get a list of all flavors for the default datastore version"},{"line_number":33,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_56eec58b","line":32,"in_reply_to":"baada198_95505a0b","updated":"2014-07-28 15:22:12.000000000","message":"I do not completely get your comment. Could you please elaborate?","commit_id":"e1d3e06c9294fa947e6873d65c581fba4a24038e"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"b97487f54aa9c68b71d86f4fa7ae79e08aea81d5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    resource_class \u003d Flavor"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self):"},{"line_number":32,"context_line":"        \"\"\"Get a list of all flavors for the default datastore version"},{"line_number":33,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_206784ea","line":32,"updated":"2014-09-04 04:03:37.000000000","message":"How is this not considered an incompatible change?","commit_id":"06eeadc8902c6162ae399e0d5a7429ebffd7fbd7"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"c540c865f894cdd2d0f78b073eb47093f08b3e89","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_by_versionid(self, datastore_version_id):"},{"line_number":38,"context_line":"        \"\"\"Get a list of all flavors for the specified datastore version"},{"line_number":39,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_fcafefe0","line":37,"updated":"2014-08-28 19:06:15.000000000","message":"not a deal breaker. but would be nice to have function name as list_by_dsv_id or list_by_datastoreversionid.\n(something to indicate its datastore version id :))","commit_id":"06eeadc8902c6162ae399e0d5a7429ebffd7fbd7"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"2ef49e43958afdca0bab8629d34627139782026a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_by_versionid(self, datastore_version_id):"},{"line_number":38,"context_line":"        \"\"\"Get a list of all flavors for the specified datastore version"},{"line_number":39,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_12fbbac1","line":37,"in_reply_to":"1abeadc6_3373524f","updated":"2014-09-04 02:38:08.000000000","message":"+1. Other places call it datastore_version_id. I don\u0027t see why not here.","commit_id":"06eeadc8902c6162ae399e0d5a7429ebffd7fbd7"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"568a6c83a227ce4b517bd413223d5e5f046a8ca9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_by_versionid(self, datastore_version_id):"},{"line_number":38,"context_line":"        \"\"\"Get a list of all flavors for the specified datastore version"},{"line_number":39,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3373524f","line":37,"in_reply_to":"1abeadc6_fcafefe0","updated":"2014-08-28 21:50:03.000000000","message":"+1 with the naming. \nI like list_by_datastore_version_id, although it might be too long.","commit_id":"06eeadc8902c6162ae399e0d5a7429ebffd7fbd7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d7ff0f4fc580fc6a36c8a9a7cf17319941c9975e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        return self._list(\"/flavors\", \"flavors\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_by_datastore_version_id(self, datastore_version_id):"},{"line_number":38,"context_line":"        \"\"\"Get a list of all flavors for the specified datastore version"},{"line_number":39,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_5cea2110","line":37,"updated":"2014-10-21 17:16:58.000000000","message":"The BP appears to also list a delete, yes?","commit_id":"4bb11b637f2d2bf1e185df1003e7bc8e51a7e176"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cf36341a20a8fe7c1d8fbd23e3980c4ca185ea70","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \"\"\"Get a list of all flavors for the specified datastore version"},{"line_number":39,"context_line":"        :rtype: list of :class:`Flavor`."},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        url \u003d \"/flavors/datastores/versions/%s\" % datastore_version_id"},{"line_number":42,"context_line":"        return self._list(url, \"flavors\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get(self, flavor):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_70e7f3e4","line":41,"updated":"2014-11-20 19:07:18.000000000","message":"I\u0027m assuming this has to change as well.","commit_id":"8047702ad6a39896994e45836a4cc384436b0ee6"}],"troveclient/v1/shell.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"13793c0e0985cfc2f28068f4a571eff11f377781","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                     labels\u003d{\u0027ram\u0027: \u0027RAM\u0027})"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"@utils.arg(\u0027datastore_version_id\u0027, metavar\u003d\u0027\u003cdatastore_version_id\u003e\u0027,"},{"line_number":96,"context_line":"           help\u003d\u0027Datastore version id.\u0027)"},{"line_number":97,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":98,"context_line":"def do_flavor_list_by_versionid(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f3fa9575","line":95,"updated":"2014-07-28 10:45:18.000000000","message":"This could be simplified.\n\nExtend previous call with \u0027--datastore-version\u0027\n\nAnd if it was passed call specific API call\n\nThis should be done because threes is no huge difference between do_flavor_list and do_flavor_list_by_versionid","commit_id":"e1d3e06c9294fa947e6873d65c581fba4a24038e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7326c0981f99a0a478bc9e88135043201089496e","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"@utils.arg(\u0027datastore_version_id\u0027, metavar\u003d\u0027\u003cdatastore_version_id\u003e\u0027,"},{"line_number":96,"context_line":"           help\u003d\u0027Datastore version id.\u0027)"},{"line_number":97,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":98,"context_line":"def do_flavor_list_by_versionid(cs, args):"},{"line_number":99,"context_line":"    \"\"\"Lists available flavors for a given datastore version id.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_95293a8b","line":96,"updated":"2014-07-28 12:54:42.000000000","message":"@utils.service_type(\u0027database\u0027)\n@util.arg(\"--datastore_version_id\", metavar\u003d\"\u003cdatastore_version_id\u003e\")\ndef do_flavor_list(cs, args):\n    \"\"\"Lists available flavors (for default datastore version).\"\"\"\n    if not args.datastore_version_id:\n        flavors \u003d cs.flavors.list()\n    else:\n        flavors \u003d cs.flavors.list_by_versionid(args.datastore_version_id\n\n    utils.print_list(flavors, [\u0027id\u0027, \u0027name\u0027, \u0027ram\u0027],\n                     labels\u003d{\u0027ram\u0027: \u0027RAM\u0027})","commit_id":"e1d3e06c9294fa947e6873d65c581fba4a24038e"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"2ef49e43958afdca0bab8629d34627139782026a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# Flavor related calls"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"@utils.arg(\"--datastore_version_id\", metavar\u003d\"\u003cdatastore_version_id\u003e\","},{"line_number":88,"context_line":"           default\u003dNone, help\u003d\"Lists flavors for the datastore version id\")"},{"line_number":89,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":90,"context_line":"def do_flavor_list(cs, args):"},{"line_number":91,"context_line":"    \"\"\"Lists available flavors.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_f229d637","line":88,"updated":"2014-09-04 02:38:08.000000000","message":"I see other help kwargs ending in a period and with \"id\" as \"ID\".","commit_id":"06eeadc8902c6162ae399e0d5a7429ebffd7fbd7"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"34f66433a15593d388d35f03d510be46436e056a","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Flavor related calls"},{"line_number":114,"context_line":"@utils.arg(\u0027--datastore_id\u0027, metavar\u003d\u0027\u003cdatastore_id\u003e\u0027,"},{"line_number":115,"context_line":"           default\u003dNone,"},{"line_number":116,"context_line":"           help\u003d\u0027ID of the datastore.\u0027)"},{"line_number":117,"context_line":"@utils.arg(\"--datastore_version_id\", metavar\u003d\"\u003cdatastore_version_id\u003e\","}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_cd096585","line":114,"updated":"2014-12-04 14:11:10.000000000","message":"if you look at the datastore-show command, the datastore ID is denoted as: --datastore \u003cdatastore\u003e.","commit_id":"af4702f2ff903b10ed4a96deed5fff63a6a996c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"34f66433a15593d388d35f03d510be46436e056a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"@utils.arg(\u0027--datastore_id\u0027, metavar\u003d\u0027\u003cdatastore_id\u003e\u0027,"},{"line_number":115,"context_line":"           default\u003dNone,"},{"line_number":116,"context_line":"           help\u003d\u0027ID of the datastore.\u0027)"},{"line_number":117,"context_line":"@utils.arg(\"--datastore_version_id\", metavar\u003d\"\u003cdatastore_version_id\u003e\","},{"line_number":118,"context_line":"           default\u003dNone, help\u003d\"ID of the datastore version.\")"},{"line_number":119,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":120,"context_line":"def do_flavor_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_ad641949","line":117,"updated":"2014-12-04 14:11:10.000000000","message":"If you look at the datastore-version-show command, the datastore-version ID is denoted as: \u003cdatastore_version\u003e.","commit_id":"af4702f2ff903b10ed4a96deed5fff63a6a996c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"34f66433a15593d388d35f03d510be46436e056a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        flavors \u003d cs.flavors.list()"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        err_msg \u003d (\"Specify both \u003cdatastore_id\u003e and \u003cdatastore_version_id\u003e\""},{"line_number":129,"context_line":"                   \" to list datastore version associated flavors.\")"},{"line_number":130,"context_line":"        raise exceptions.CommandError(err_msg)"},{"line_number":131,"context_line":"    utils.print_list(flavors, [\u0027id\u0027, \u0027name\u0027, \u0027ram\u0027],"},{"line_number":132,"context_line":"                     labels\u003d{\u0027ram\u0027: \u0027RAM\u0027})"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_e20f10de","line":129,"updated":"2014-12-04 14:11:10.000000000","message":"I see that none of the messages in this file have been translated, but shouldnt we? Also, just a small suggestion. How about rewording this to something like this \"A datastore version ID and datastore ID is required to list the flavors associated to a datastore version. \"\n\n\nJust my thoughts.Thanks","commit_id":"af4702f2ff903b10ed4a96deed5fff63a6a996c4"}]}