)]}'
{"troveclient/tests/test_shell.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"269edb84d91c11cd0cd47ac00b0780116abb3808","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from troveclient.openstack.common.apiclient import exceptions as exc"},{"line_number":20,"context_line":"from troveclient import shell as openstack_shell"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_USERNAME \u003d \u0027username\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_61a03df5","line":20,"updated":"2014-08-18 06:58:51.000000000","message":"This should probably be named something like troveclient_shell; openstack_shell seems to imply that it\u0027s openstack specific.","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_help_unknown_command(self):"},{"line_number":52,"context_line":"        shell \u003d openstack_shell.OpenStackTroveShell()"},{"line_number":53,"context_line":"        argstr \u003d \u0027help foofoo\u0027"},{"line_number":54,"context_line":"        self.assertRaises(exc.CommandError, shell.main, argstr.split())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_help(self):"},{"line_number":57,"context_line":"        shell \u003d openstack_shell.OpenStackTroveShell()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_a2d762be","line":54,"updated":"2014-08-15 21:21:46.000000000","message":"Can self.shell be used here?","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"269edb84d91c11cd0cd47ac00b0780116abb3808","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_help_unknown_command(self):"},{"line_number":52,"context_line":"        shell \u003d openstack_shell.OpenStackTroveShell()"},{"line_number":53,"context_line":"        argstr \u003d \u0027help foofoo\u0027"},{"line_number":54,"context_line":"        self.assertRaises(exc.CommandError, shell.main, argstr.split())"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_help(self):"},{"line_number":57,"context_line":"        shell \u003d openstack_shell.OpenStackTroveShell()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_a181754c","line":54,"in_reply_to":"7ac7a964_a2d762be","updated":"2014-08-18 06:58:51.000000000","message":"++","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def test_help(self):"},{"line_number":57,"context_line":"        shell \u003d openstack_shell.OpenStackTroveShell()"},{"line_number":58,"context_line":"        argstr \u003d \u0027help create\u0027"},{"line_number":59,"context_line":"        actual \u003d shell.main(argstr.split())"},{"line_number":60,"context_line":"        self.assertEqual(0, actual)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_help_on_subcommand_error(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_c2fd3e3c","line":59,"updated":"2014-08-15 21:21:46.000000000","message":"Can self.shell be used here?","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        actual \u003d shell.main(argstr.split())"},{"line_number":60,"context_line":"        self.assertEqual(0, actual)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_help_on_subcommand_error(self):"},{"line_number":63,"context_line":"        self.assertRaises(exc.CommandError, self.shell, \u0027help bad\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_base_parser(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_c259be5b","line":62,"updated":"2014-08-15 21:21:46.000000000","message":"This seems to do the same as test_help_unknown_command.","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"269edb84d91c11cd0cd47ac00b0780116abb3808","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        actual \u003d shell.main(argstr.split())"},{"line_number":60,"context_line":"        self.assertEqual(0, actual)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_help_on_subcommand_error(self):"},{"line_number":63,"context_line":"        self.assertRaises(exc.CommandError, self.shell, \u0027help bad\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_base_parser(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_61875d62","line":62,"in_reply_to":"7ac7a964_c259be5b","updated":"2014-08-18 06:58:51.000000000","message":"Yes, this seems redundant.","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_help_on_subcommand_error(self):"},{"line_number":63,"context_line":"        self.assertRaises(exc.CommandError, self.shell, \u0027help bad\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_base_parser(self):"},{"line_number":66,"context_line":"        test_shell \u003d openstack_shell.OpenStackTroveShell()"},{"line_number":67,"context_line":"        actual_parser \u003d test_shell.get_base_parser()"},{"line_number":68,"context_line":"        description \u003d \u0027Command-line interface to the OpenStack Trove API.\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_62170a52","line":65,"updated":"2014-08-15 21:21:46.000000000","message":"What value does this test method bring?","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"269edb84d91c11cd0cd47ac00b0780116abb3808","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def test_help_on_subcommand_error(self):"},{"line_number":63,"context_line":"        self.assertRaises(exc.CommandError, self.shell, \u0027help bad\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_base_parser(self):"},{"line_number":66,"context_line":"        test_shell \u003d openstack_shell.OpenStackTroveShell()"},{"line_number":67,"context_line":"        actual_parser \u003d test_shell.get_base_parser()"},{"line_number":68,"context_line":"        description \u003d \u0027Command-line interface to the OpenStack Trove API.\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_e1d9ad84","line":65,"in_reply_to":"7ac7a964_62170a52","updated":"2014-08-18 06:58:51.000000000","message":"Yes, all this seems to be doing is comparing parsers.\n\nHow is this is related to --os-auth-token which is being added by this patch?","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"}],"troveclient/tests/test_shell_v1.py":[{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ac7a964_e5b5e431","updated":"2014-08-15 21:21:46.000000000","message":"I see a bunch of *_invalid_endpoint and a bunch of *_invalid_syntax tests. It seems to me that one of each is good enough. Also, how about combining the two test_*.py files in this Gerrit change?","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d20af0b1d5e367dd1c6579f8de0485145b0d1392","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(ShellInvalidEndpointandParameterTest, self).setUp()"},{"line_number":27,"context_line":"        self.old_environment \u003d os.environ.copy()"},{"line_number":28,"context_line":"        os.environ \u003d {"},{"line_number":29,"context_line":"            \u0027OS_USERNAME\u0027: \u0027username\u0027,"},{"line_number":30,"context_line":"            \u0027OS_PASSWORD\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_85143045","line":27,"updated":"2014-08-15 21:21:46.000000000","message":"It appears you\u0027re stowing away the copy and not os.environ itself.","commit_id":"0727004a1a368cf61165a3794706f8c3bcfef93a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b0d5f759c9495897b4e145f7370f86ee0a21182b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from troveclient import shell"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShellInvalidEndpointandParameterTest(testtools.TestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(ShellInvalidEndpointandParameterTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_4cb3c497","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":42},"updated":"2014-11-17 17:55:06.000000000","message":"I\u0027m curious about this test. What exactly does it test?\n\nFor the most part, it seems to verify whether the shell knows how to parse arguments, yes?","commit_id":"f22adefd33d046d033d7ea5c19863cba945a1700"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2f8fe4d2bf0e9327231fb0570d9db738e77ee524","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from troveclient import shell"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShellInvalidEndpointandParameterTest(testtools.TestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(ShellInvalidEndpointandParameterTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_1b71f0a7","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":42},"in_reply_to":"5a890539_4cb3c497","updated":"2014-11-17 20:13:36.000000000","message":"Yes, correct. OpenStack shell and its wrapper TroveShell should parse income parameters correctly.","commit_id":"f22adefd33d046d033d7ea5c19863cba945a1700"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b0d5f759c9495897b4e145f7370f86ee0a21182b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(ShellInvalidEndpointandParameterTest, self).setUp()"},{"line_number":27,"context_line":"        self.old_environment \u003d os.environ"},{"line_number":28,"context_line":"        os.environ \u003d {"},{"line_number":29,"context_line":"            \u0027OS_USERNAME\u0027: \u0027username\u0027,"},{"line_number":30,"context_line":"            \u0027OS_PASSWORD\u0027: \u0027password\u0027,"},{"line_number":31,"context_line":"            \u0027OS_TENANT_ID\u0027: \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_ac29889c","line":28,"updated":"2014-11-17 17:55:06.000000000","message":"did you mean to overwrite the entire environment? or just add these things.","commit_id":"f22adefd33d046d033d7ea5c19863cba945a1700"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2f8fe4d2bf0e9327231fb0570d9db738e77ee524","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(ShellInvalidEndpointandParameterTest, self).setUp()"},{"line_number":27,"context_line":"        self.old_environment \u003d os.environ"},{"line_number":28,"context_line":"        os.environ \u003d {"},{"line_number":29,"context_line":"            \u0027OS_USERNAME\u0027: \u0027username\u0027,"},{"line_number":30,"context_line":"            \u0027OS_PASSWORD\u0027: \u0027password\u0027,"},{"line_number":31,"context_line":"            \u0027OS_TENANT_ID\u0027: \u0027tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_fb6d04cd","line":28,"in_reply_to":"5a890539_ac29889c","updated":"2014-11-17 20:13:36.000000000","message":"just adding required things","commit_id":"f22adefd33d046d033d7ea5c19863cba945a1700"}]}