)]}'
{"troveclient/v1/instances.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"652d6b4d8edda3b92692794c67d05411dd2c9219","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            }"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        if configuration and remove_configuration:"},{"line_number":99,"context_line":"            raise Exception(\"Cannot attach and detach configuration \""},{"line_number":100,"context_line":"                            \"simultaneosly.\")"},{"line_number":101,"context_line":"        if remove_configuration:"},{"line_number":102,"context_line":"            body[\"instance\"][\"configuration\"] \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_865eb343","line":99,"updated":"2014-08-28 16:16:18.000000000","message":"Please follow patter described by the link:\n\nhttps://github.com/openstack/python-troveclient/blob/master/troveclient/v1/shell.py#L245-L254","commit_id":"19380d17bcbd1661d0f29e30b9dd176939f547d7"}],"troveclient/v1/shell.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"92f24be0b8afc5f2e2c12249abfecc1705c2886e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"           type\u003dstr,"},{"line_number":170,"context_line":"           default\u003dNone,"},{"line_number":171,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027"},{"line_number":172,"context_line":"                \u0027Pass None explicitly to drop reference.\u0027)"},{"line_number":173,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":174,"context_line":"def do_update(cs, args):"},{"line_number":175,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_5b15129a","line":172,"updated":"2014-08-22 22:48:33.000000000","message":"This has the potential to be confusing.\n\nFirst, the default is None, why then would you ask the user to pass a reference of None explicitly?\n\nIn general, to drop a reference, wouldn\u0027t a --remove-configuration ID be the better way to accomplish this?","commit_id":"985688dadf8ce023b6e26d684c8136c03db5e04f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d361e46c2066f40f88113af09b632ca589a2c8ee","unresolved":false,"context_lines":[{"line_number":169,"context_line":"           type\u003dstr,"},{"line_number":170,"context_line":"           default\u003dNone,"},{"line_number":171,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027"},{"line_number":172,"context_line":"                \u0027Pass None explicitly to drop reference.\u0027)"},{"line_number":173,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":174,"context_line":"def do_update(cs, args):"},{"line_number":175,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_07f098c7","line":172,"in_reply_to":"1abeadc6_5b15129a","updated":"2014-08-23 11:38:53.000000000","message":"+1 to --remove-configuration","commit_id":"985688dadf8ce023b6e26d684c8136c03db5e04f"}]}